From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A2C41DDC2C for ; Thu, 16 Jan 2025 10:56:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737025017; cv=none; b=cEyCCsmMADVvxjri8iYurlPytYPgb3H2uv1WzvACDEpSiRlu2/2K7NYjIblnxMrxWTHIEHhVK9Uyl1fvvpQhM1Ibs3Dd/EZPoq+7mu7u0ObVKj/d3iwcU1IP0xCZOVpg0Xg+FA5f2ur4mVWyX0urx7DSYk2cuLlmaTgW4HcUOyw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737025017; c=relaxed/simple; bh=G6099FHO6nWJJHNre2ycddLPVGziWYRVcBYD5XNOTSk=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=LaOFlaID9Gk57OW6QJ0BSGrpsw1hXcjOK8+tzrPRvBbQV//iloLO4gXtt2w4ox3YMqrE6AcH8lj1Ywbq40jie9suAL8OPZ8gxIh+sJtQ9rdJbbjf9rzweQ1nOmaxDyw/5H3HUqyUwjzjAFAmQbhJzErTBdk5IBU7cNbD+IGaNyc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GQn0PSej; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GQn0PSej" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-43623f0c574so4410365e9.2 for ; Thu, 16 Jan 2025 02:56:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1737025014; x=1737629814; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=mnFejfmTPjeYudZjpoT12TW6mGK7qWBB/S51xWl9wMM=; b=GQn0PSejyuJfsWBID8g2br1OuEyaFxGerTZtVhugGnwuEc+XJaUAJI5COhdSd2BC/g K4sKCPONVHC4zIayASGDrkaEylVKfUw+hI3tK5cLmbMS86u0yODWkZetMkpJWZmV00Ql P/Eiq/WGl90AnjZcCiU5QzoKucS5L/8QGSVgI6gm6AThMtomucZrbwPYUJ0e6BmyAqSt G/bD5n2Tz4gPfW3W1b92f6Ej4L9YTvN1xeQOCb69ycXT6MjZ4wtqus+vL6nHSeskgifQ mt5qlc+XDdcI696PbVwAUsIn8QCy7cHHVWGbUmCe4e7Ek9roxxTS4u1OL0gMTiO8CZnA 0xbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737025014; x=1737629814; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mnFejfmTPjeYudZjpoT12TW6mGK7qWBB/S51xWl9wMM=; b=LQU6UtvT7+cHZvwWYL8611ivvSZo9ffBJgZxYL0DYB8rb8Kk3nLzGSMRPcK6Yz8MYU 0xVzqfMg3m6scLEJoemMgtBKgkJyMfbR9nNhRR4x4+2URGfvB5igNKgJaMsoT5yqY0pY E7S6yhpwAJh3nyKbv7qEBHjtlKLpU9D45dI34kkIWXP2F1EobV8Y0qgOyo7ul0p51gQm PqQOmihFGl8gAbkTqjz4B5+w8gYxdJz7QhWEpOi9Gh+7CRLHzvuqoeA/EOu0LziiS28n 23tExG6BW2bo4rpekq1vAUYrCietLDEp5i/cvxAOMEkOLxb7X1tUy8G3szAzdYBasPrr enWw== X-Forwarded-Encrypted: i=1; AJvYcCW3wabp0sv19ZqgPu/2A3/e7G2q5iXLP5mrxR48iUTc8wZJuHOSxsuw+9EUuBfbfjNJfcwy7+qcau0iDEY=@vger.kernel.org X-Gm-Message-State: AOJu0YzUCKVAzrT7QpdfF41TuzycGjRRBPqynUljX0dCPo2W7YCq8dxi kdCmRYVjvh/WOL5QLXElEPKFUZwEcfcm2vd6AenjrlHbWO/XQBCn5HPIlYXDuJk= X-Gm-Gg: ASbGncvzXJValJymE+Hqxi+JTNM0SxOzDww9kcS3TqPYg5fI09afX4Yu34vu7NfET7u dDF0qZx831tRmMGH/jAllHGEZTOWtYZNSTNhOTOYTnPEOr2yWcy7BRU8WYQTXruloHKwEp91Roj JVjt2X+nb+FMFO81BVe8qGJHzDJPriyjKbK7kWaVo8OnVvh7UBw2eEzk2/6cUFKSj4uWNSjjmrS gswpXmdBO9WDqtNwBOqxemAeKErXVFEQcC70GamZRproJpQTfVNaMQZreIe+bs1fw== X-Google-Smtp-Source: AGHT+IEaM+HUjw9DUX+MbLPNx3KI+ADTauH4ORBCsTCMfr5r1tpw6yofjrJn0lgwY5VXgcFUbkGkBA== X-Received: by 2002:a05:600c:1987:b0:434:a386:6ae with SMTP id 5b1f17b1804b1-436e267850cmr306974415e9.7.1737025013678; Thu, 16 Jan 2025 02:56:53 -0800 (PST) Received: from [192.168.68.163] ([145.224.65.18]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e383df8sm20492748f8f.38.2025.01.16.02.56.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jan 2025 02:56:53 -0800 (PST) Message-ID: <45f0bebf-6d4a-448c-8088-db2facbbfa46@linaro.org> Date: Thu, 16 Jan 2025 10:56:52 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 0/6] Mypy and pylint build support To: Ian Rogers , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Kan Liang , John Garry , Athira Jajeev , Veronika Molnarova , Ze Gao , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org References: <20241025172303.77538-1-irogers@google.com> Content-Language: en-US From: James Clark In-Reply-To: <20241025172303.77538-1-irogers@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 25/10/2024 6:22 pm, Ian Rogers wrote: > Support building perf checking the python code with mypy and/or > pylint. Currently there are too many errors to make this a default. > > Shellcheck generates no output on success, so linking shellcheck files > doesn't cause `ld` to fail. Mypy and pylint generate output that will > break `ld` so change the Makefile.build to ignore test log files. > > Address some initial mypy errors. > > Ian Rogers (6): > tools/build: Don't pass test log files to linker > perf build: Rename TEST_LOGS to SHELL_TEST_LOGS > perf build: Add mypy build tests > perf build: Add pylint build tests > perf test: Address attr.py mypy error > perf python: Fix setup.py mypy errors > > tools/build/Makefile.build | 6 +++++- > tools/perf/Build | 32 +++++++++++++++++++++++++++--- > tools/perf/Makefile.perf | 14 +++++++++++-- > tools/perf/arch/x86/Build | 6 +++--- > tools/perf/arch/x86/tests/Build | 6 +++--- > tools/perf/pmu-events/Build | 25 ++++++++++++++++++++++- > tools/perf/scripts/Build | 26 ++++++++++++++++++++++++ > tools/perf/tests/Build | 32 +++++++++++++++++++++++++++--- > tools/perf/tests/shell/lib/attr.py | 8 +------- > tools/perf/trace/beauty/Build | 6 +++--- > tools/perf/util/Build | 31 ++++++++++++++++++++++++++--- > tools/perf/util/setup.py | 10 ++++++++-- > 12 files changed, 171 insertions(+), 31 deletions(-) > Reviewed-by: James Clark $ make PYLINT=1 MYPY=1 TEST python/twatch.py.pylint_log ... Your code has been rated at -5.00/10 ...