From: "Жамбакиев Радий Рикардинович" <r.zhambakiev@prosoftsystems.ru>
To: "netdev-bot+sashiko@kernel.org" <netdev-bot+sashiko@kernel.org>
Cc: "benato.denis96@gmail.com" <benato.denis96@gmail.com>,
"petrm@nvidia.com" <petrm@nvidia.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"u.kleine-koenig@baylibre.com" <u.kleine-koenig@baylibre.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lvc-project@linuxtesting.org" <lvc-project@linuxtesting.org>,
"jacob.e.keller@intel.com" <jacob.e.keller@intel.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net 1/3] net: fealnx: fix teardown order in remove
Date: Mon, 28 Sep 2026 13:08:04 +0000 [thread overview]
Message-ID: <45f24000abd3ffa82079d79bcdfd495d6b150ace.camel@prosoftsystems.ru> (raw)
In-Reply-To: <179033317745.2160803.17677672986489038086@kernel.org>
On Fri, 2026-09-25 at 10:46 +0000, netdev-bot+sashiko@kernel.org wrote:
> - [High] The commit says unregister_netdev() -> dev_close() ->
> netdev_close() "deletes the timers ... before the rings are freed".
> - [High] The fix assumes that once unregister_netdev() returns,
> netdev_close() has stopped the Rx/Tx DMA engines, so…
>
> Pre-existing issues:
> - [Low] At this commit, fealnx_init_one() calls pci_enable_device()
> and
> pci_set_master() (lines 497/499).
>
> --
I think [High] issues is pre-existing. Sashiko points to the code, that
already been there and was not touched by this patch. It might be the
wording of the patch, that made Sashiko mark issues as freshly
introduced.
prev parent reply other threads:[~2026-09-28 13:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 10:44 Жамбакиев Радий Рикардинович
2026-09-24 10:44 ` [PATCH net 2/3] net: fealnx: disable the PCI device on remove and probe failure Жамбакиев Радий Рикардинович
2026-09-24 21:52 ` Francois Romieu
2026-09-24 10:44 ` [PATCH net 3/3] net: fealnx: allocate the card index from an IDA Жамбакиев Радий Рикардинович
2026-09-24 16:50 ` Andrew Lunn
2026-09-24 16:43 ` [PATCH net 1/3] net: fealnx: fix teardown order in remove Andrew Lunn
2026-09-28 12:31 ` Жамбакиев Радий Рикардинович
2026-09-24 21:51 ` Francois Romieu
2026-09-28 12:32 ` Жамбакиев Радий Рикардинович
2026-09-25 10:46 ` netdev-bot+sashiko
2026-09-28 13:08 ` Жамбакиев Радий Рикардинович [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45f24000abd3ffa82079d79bcdfd495d6b150ace.camel@prosoftsystems.ru \
--to=r.zhambakiev@prosoftsystems.ru \
--cc=andrew+netdev@lunn.ch \
--cc=benato.denis96@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=stable@vger.kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®