From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2068.outbound.protection.outlook.com [40.107.94.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB02E2F22 for ; Fri, 3 Jan 2025 04:29:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.94.68 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735878578; cv=fail; b=q6mqeQNLRRh7PDZ5TbomgVSPaoSW9zqTxHff9PjN51rRZkQsPUkihEvFwqrX4Hi+yhE4O4wgU8jcCKAwmqrqWHrdx2VgWB2FFk8Gd1/JF8zHcIR/aOtXICWyyrkVo5rdNZovLW8EbqrE6DdiO6serEn6fFp1TMI14gSm4mMTsOE= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735878578; c=relaxed/simple; bh=BOoBD19Ok4B4wIcaJXrfw367uELCq4hnfLv58b7G6FI=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=g5l6Dr3wd5y+2gWgBaPSD7i24o7EaAHyHisaGq9dw47eD/KVUxtpH9B5kR4tIhampvdNzJf5J+4Ob8C10vILjZmmcr/4cpndO/lTfnd8YIDwDWC6xxhs/XaFwlZkCNqDbB2YrPlkiginerj6sO/aXMTszk4NswrbokNFfXTUvis= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Zl6VHoQE; arc=fail smtp.client-ip=40.107.94.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Zl6VHoQE" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pSgWlrHeswCOeXxdN/s+ol7rhC4Jggq+zYJHIkmWeGS3uRBco2T6NTp52VNCweEeFl2ZApZScXJLC4efElup6DVUSRyYn/TCnv8yRz7JY9VX9IXc5Iykp+KmvoEFNotSwioxXhiu88XPuQfXTCwSTWqh0i6XuypNPv2tVT0MTuuX9LmuiIdb8q4F2H02iowVdGgnsYgM4EfdgLCxo8FHnJZxtqqG8y3JzV/ZHY8yokg/NvkWuXzQ6+4tBeX9bM2Jd5Jajjwx1PYJ07NHpZVpMtIVimqVNvWp/7tINPgH2uR5fmRzf4T7wDIVc3aLnpbrfnBR84LwTj74COuSQYsHNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fj+GP+u16kFb7MmyGteyTmXqpngGPHcDrszBzAgjAOE=; b=mSuOeG3FmBWB7XUMN62OHf0a1ItACxBc/BNZGquLeEbR44lM6ES1KRB03h2StIx00vf3sMigzNrXBHo1a95HT4mVU1xDmEDoFfjUvvEP0vzdKhXV2wroA0Z2aPS7nAl9NMDKpWn0pc4oadnp4pJTbQ0Xtc1u2IJcAu99wxnL/vRyTfiyKYGjPjl9h5KVKY3rH/azGw+CIhzIYREQfhPNBqH8Ksc+O1qs+36d1pMGcPo/5NsdmbRMnfXRz0lpH8FjtOxpQIVUxw2Tnxgo7cAn4uQ8DvNc27hx1wwYco0FZ/gF7h90RT04pfJnj1Zx6snp54k6lNsVyzyt7zUTa+p4BA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fj+GP+u16kFb7MmyGteyTmXqpngGPHcDrszBzAgjAOE=; b=Zl6VHoQE7BUMa3g8VesDp/UidpooGaKrj6+ZzMRLlIVeNSxMn73e+QE2czChCbxXn951Y2J4R05QuEl8HK8G3ebCZAOpjfA6ntffEyu/69zzIDSc3sT/quaDLvy4jcGj/JHeNNKLYht7sQ4QgTuVvFE3oK8zShmbCpUdKpVoHVg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from PH7PR12MB6588.namprd12.prod.outlook.com (2603:10b6:510:210::10) by DS0PR12MB9276.namprd12.prod.outlook.com (2603:10b6:8:1a0::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8293.20; Fri, 3 Jan 2025 04:29:30 +0000 Received: from PH7PR12MB6588.namprd12.prod.outlook.com ([fe80::5e9c:4117:b5e0:cf39]) by PH7PR12MB6588.namprd12.prod.outlook.com ([fe80::5e9c:4117:b5e0:cf39%5]) with mapi id 15.20.8314.012; Fri, 3 Jan 2025 04:29:24 +0000 Message-ID: <45f2b6a4-f513-48ba-9667-bbc726aba804@amd.com> Date: Fri, 3 Jan 2025 09:59:13 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 19/19] perf: Make perf_pmu_unregister() useable To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, willy@infradead.org, acme@kernel.org, namhyung@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, kan.liang@linux.intel.com, mingo@kernel.org, lucas.demarchi@intel.com, Ravi Bangoria References: <20241104133909.669111662@infradead.org> <20241104135519.715883982@infradead.org> Content-Language: en-US From: Ravi Bangoria In-Reply-To: <20241104135519.715883982@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN2PEPF000001AF.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c04::b) To PH7PR12MB6588.namprd12.prod.outlook.com (2603:10b6:510:210::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR12MB6588:EE_|DS0PR12MB9276:EE_ X-MS-Office365-Filtering-Correlation-Id: 6fbbfb6b-cc80-4607-3fab-08dd2baf3342 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZlBZNy9LSEFna3lJcDBzdGZMZm9YM0dqMEE2YW9oL2pMU2dpUG9UUzVqQjNz?= =?utf-8?B?d3ZyVXpLRTJZRGMwNXRHSHZkcGhMQ2thdmI2KzNBRjNFRW9vWVFFeC93M25o?= =?utf-8?B?WmRhTDROVzhqZCtBTFR1ZjJSQkVpMzdKMjB4cFZPNTZWWTVmMUUybS9HU09t?= =?utf-8?B?aTg2TkJYNEhsaXF3WFZDcjJOaEtuUW1wV2lydWpqRTR0dytCOGlTNVFxUFBH?= =?utf-8?B?aktHaXBKZzVvZVptU0ZaNlBjekYrZ1MrYmUzeEdDNkVkMDgreEhtRlh3NGp5?= =?utf-8?B?cjdMbjJWdkR6WFAxWUxWbm1nc0JXV3RYZnZaWlVEVnB1RS9HMDhTSHlDbzNB?= =?utf-8?B?d3hPLzhIbGhwcUZOTENtSnFZWThiQ21oYUt6aWhFNm9QRG13aE56V210VC93?= =?utf-8?B?U0szOEkxbFFhN1JPZU5KSGVOL1lEQlhDeDFyY1FrbTR3cFlxU3hoSFZyL0dD?= =?utf-8?B?UDd4YkpnaVJ0bnhZckR1aWdpbzhneHVMclpFSktBdTUrWEpjS2lIdnZ6cHl1?= =?utf-8?B?UW03b2ZZZjdqZVZlNGVNRXBlZmFmYXRoVHJSN1JDOExKMWEyRGQyUkJmc1No?= =?utf-8?B?NDZzU1FZUHVEdkFnSGEvZmE0TU4yVHJZSnZiajNMYVlQYVUydkxoWlBLUmZw?= =?utf-8?B?YVRsVlRTLzNteUUvZmpWb2VXbmVEU2JsTlduQ1lpN0RtOVV6K2hJMVJ3dGVF?= =?utf-8?B?aXkvQ25ZQjNEVEV6ZUY4ZGtlaUFvZEhjRzN2bnB5Rk1WenVPR3hDRlpReC96?= =?utf-8?B?U2VkVVB6THE5ZUFNcUc3ZnZjbWZHM2d6UHJXSVVYbm93TzBOcjBMdUNGYlkx?= =?utf-8?B?MkpLZ01GRkN0eFNmUGtVMElHZE5HV05WaXNSYUhaUDVXeWljTW5EVjJYMkdF?= =?utf-8?B?WkltUXJjTlVlZlFUdThoVUV1ajZHRHpKZ2RoMzlHYW9ZbjlxTTRhc0JBUzVq?= =?utf-8?B?U3dPL1hOTCtxaGlrU0FwYnlUWFVhaVB3bCtzbURuMVRaSGhFdFZpS05HWm5Y?= =?utf-8?B?V3M0Y1ZiTDlMR3p5U2Njc3ZwM2NDWG9UNFhNY0hSUzRkS3NtU3lhMG0rcFpV?= =?utf-8?B?bFB4U2YrTkNaMlQ2eVJybHNVY3F4QjJma2crRmwzMUcvM09RZThEenVvMlJP?= =?utf-8?B?blhjdW84UjduZE55ZklWN1FtODVNeENHQzl1ZThWRkV6UnhZYVVGbUZwWlF6?= =?utf-8?B?QWVzU0RNZEFVZnpXWDBKSm1SZUkrRGpSbDB4cHVJREh6a05CVzhKZnQreU1C?= =?utf-8?B?NmRpa3ZZS1JkTllkQWF0cE9XQzY4N3hsWkl4Qm5tMVVDeERQTFBtaG1xdy9s?= =?utf-8?B?T1doQXY1N1J0VnNUaUl5VDNUbndpbFE0VGNsU043Ulp0a2hGcytJWlQ4RjEy?= =?utf-8?B?b3V3M0VEQnJXUzh2UEppd2F0a0Jzdnhidm9WRmVYTmJZdm5NYURnY21BV3Bh?= =?utf-8?B?Sm1SOHcwT2FYcEdsd3AwTkhSQVlTbk50OU5uTFcvWUZGUERSVmwzOFM1UkpM?= =?utf-8?B?NW9ZRnpwcWhPTmpRZVRYemNscFhzY1NqY0dJR0pMbUJJYmVMUDNuRWM4YmZT?= =?utf-8?B?UkdaSkNxR1ZMc2tyeEhkeElwS0dJVW9mbVcvOWhTMVBvd2JRbkQyRXpqMFlC?= =?utf-8?B?Rmcvc1ZIcHlPR2E2VkZtZFhjVlFBRnhYS0hMVTQxSkJlRXptZmZzRnc3TEg1?= =?utf-8?B?aWNZaCtjd1d6WGtETWtPbUtCMGhHSVRoMXVlSTM3eFgya0dXRm9vWjhKbjl4?= =?utf-8?B?ZHluZ1ltOTdLS3B3Z1JxcFBjTEdka2h1VzBRNlhZZ0pQd04xYi9mOWZwb2Fy?= =?utf-8?B?Y2tsaFk1UkpVUm9yalJWWDdBckRjUGx0azBabDlab2luV1l0ODllMS9EajNC?= =?utf-8?Q?P5pSi2FtAb9A0?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR12MB6588.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0ZkWlE2Z1kyMElSUytYLzVUcHJnS0MrV2UxUXNvaTc4c0RSWDhBOGFPamVW?= =?utf-8?B?MG42U3ZYdGJ3a2FlYy9rc2dsNTU3bTBXVkpWRnZTNWhvTU9uVGNVWDQ2dVg2?= =?utf-8?B?b2NlaXJISnFIOGl3dFhUZnE4QnM5MDZOaFlkNW5pdUh2dkxraXBTT2pPV0dq?= =?utf-8?B?TjIyVDdlL09pQlRmdXYxZXNjUUs1WmEwTE4rcXgwcGZPMnZZL3BiV0VMRzgz?= =?utf-8?B?M2F5emVtbkhZZW5OekJhamQvUVlVaHpmYUxJZUhOUTE5WWRWVDdMZmc2a2Fi?= =?utf-8?B?SDJNREl1MlRsRHlsV2JpUjIzWjZJK0VaZ1BEbmYzdG11Wk9ES2tzbFUrUXBu?= =?utf-8?B?elNjTy9kU2NjbjhSL1hVODhIcTRGZVhnTExKRGdDalg1am5OS1JMVHl2TTZ1?= =?utf-8?B?amdBeWQ1d0hJaFF6Qk1MbzFNMmhxM25WN24vR2dhYWxad0piakVGekJncG9h?= =?utf-8?B?c2hjdW90U08vOGU0c1BIQTRURWxVS0V1TG5Id0lhL0VCRWE0S1RBV0hvaXp4?= =?utf-8?B?Q3pVdTIyampEcndrek5KTXJrQ01NRC9hb3lCbGV2NHRpRTlYTDV6MzRJL0Vu?= =?utf-8?B?VjNwaFExRzR0T3hPb0g1ZmVmVDJGSXpPN1pySXRzclVSZlRWQmFTT3Y3T2Mw?= =?utf-8?B?alUrc1U2bDdvZkQwZjJWV0NnRWdGUytkeVB0bXE5Vk9KZ0tuZkhBYlQ3ejRu?= =?utf-8?B?OHJQZFZ5M2l4UXRVaktMN2lnSnUwNlh1WkNtMnN4QTNFeXRkUk9KN3RsOVEy?= =?utf-8?B?T09Gd2JNNG1ieHJETGFYYW5rTE9adkJoQjBTclJiVVFqdG9YSThZNFVYOGJD?= =?utf-8?B?dXVxa3NscW1pU3MvOTFzRjljZzN2MmZNaWk4NmNFQ0xvL2w0bEFPM2JDaTFj?= =?utf-8?B?Rmt3MUNJVjhjYXJnSVVDL01RVUQzR044K0FEenhnSEhjRkFrRkREdi9ZZHl1?= =?utf-8?B?SEVKcTMraEZDd0dHQ3ZhU2RkMmdTZVdzOS9rMzlRQkVkeXhtWEh1U2NUV0dx?= =?utf-8?B?ZmM2RGc2VFJTWmNTRnlvY3Q4SGNjYmJjRmxsZnMzZWwwbFFRMmJzK1ljWmtY?= =?utf-8?B?VHdLQ2tIWlV0VS9CYVprVWFjWllkWlZuVkJDT080dTZFTjBwY09sSElVUTRv?= =?utf-8?B?UkZha2NlRjZnRG80UEpTQ2NBTlZVbDR0SUlDOTcrNmFkNC9KZ2QrRGMyMksx?= =?utf-8?B?U0pUR05GaU1hNnhUakh2UllzZHRYc2xBUXcvT3pDSGlmQTRRTUdBZituNVNu?= =?utf-8?B?RnRaSmQrWXkvcjF0UnVxTzlyMHVVSmIrWENHWHI4Tk5UZlZyWVViOS81bDVF?= =?utf-8?B?RmhRRzQ4RXcxdXlsdEpRRUY1aUxLQmYybFF0S3E5Yk14bUpTRGVSRHVuLzJz?= =?utf-8?B?VFZORVg4dWVCdjFoZHF2TlNkMHFLaWFNOUR1ZDZHM0JZbEpZQ2x3anl5Uyty?= =?utf-8?B?eDkrVDhQeDFjcGU0TWVJWVFpcUZ5aW02N2lwVVByTlVRL053c3Z1bW5EMVZa?= =?utf-8?B?RmFXU09Uc1pTZzVrWG5TZGtHZUU1WUxLMkdud1dkYXBuL2M3Tm9FTVZnbWJE?= =?utf-8?B?ViszbExkcjlreXg1aDBHMC9HUkdCVVRNY3ZiQ0M2V1dlQTBoelZ4MElDMDhT?= =?utf-8?B?OHdxcmFEbk8rejhhUVhCdWxhVUwrNlZVdlUvRDZhZlNkQVkwMXFrMzhFUFY4?= =?utf-8?B?Yk9KWVNFQmQvcWU0MnQ5aExjNzdPUlA2MDVoZm5uRGx5bTdoQVBBaG9QU25O?= =?utf-8?B?cWtWaHNUZXRQVm93M01FN1VGbk9qeGZ2djhwVytuazUyNUNWMlkwU0U1SENN?= =?utf-8?B?WjR2QlRXWFJaVSt5YUpvQ3NqNTZUaHNVTlpDc2VOVmovY0Z0RlBIVnZuSTNy?= =?utf-8?B?VXY4UDMxZzhDWkNDemlUUHppRlRzcnhuMG5aOHQ5UTFnU0lRYXpnL0NoU3Ew?= =?utf-8?B?dXBtMmxTS0Njbys1OHpjODJBLzBaNDZiaWRtQklrdVN4elpaaXhxcHd4U2ZR?= =?utf-8?B?Qy9zQWVac05tWnhiSThFR3dnNmdmajVUVXBtNHJKaVJwSHNGRGVGYkhYKzlj?= =?utf-8?B?RGVhM284TC9OQmFrSzV4SFV4d3BLdXZCLzVGdVI5YThzRDhNQkdkWXA3dE9G?= =?utf-8?Q?4ImS8zBle/pUh/+Q9/BRS1yyK?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6fbbfb6b-cc80-4607-3fab-08dd2baf3342 X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2025 04:29:23.9535 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aOz+KryQfiJI7TY5p9mzlTE0ZVxl2TO4DddNbxXnPE6LrRm6O1PZdI+tc/pS+fXaa8IxRZ5S3uUebhK+FqtQqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB9276 Hi Peter, > @@ -12294,6 +12458,13 @@ perf_event_alloc(struct perf_event_attr > > perf_event__state_init(event); > > + /* > + * Hold SRCU critical section around perf_init_event(), until returning > + * the fully formed event put on pmu->events_list. This ensures that > + * perf_pmu_unregister() will see any in-progress event creation that > + * races. > + */ > + guard(srcu)(&pmus_srcu); Minor nit. This can go down a bit, just right before perf_init_event() ? Thanks, Ravi