From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753937AbdJIHww (ORCPT ); Mon, 9 Oct 2017 03:52:52 -0400 Received: from m12-13.163.com ([220.181.12.13]:53278 "EHLO m12-13.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751257AbdJIHwv (ORCPT ); Mon, 9 Oct 2017 03:52:51 -0400 Subject: Re: [alsa-devel] [PATCH] opl3: Fix a possible sleep-in-atomic bug in snd_opl3_find_patch To: Clemens Ladisch Cc: perex@perex.cz, tiwai@suse.com, o-takashi@sakamocchi.jp, elfring@users.sourceforge.net, fabf@skynet.be, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <1507516527-4173-1-git-send-email-baijiaju1990@163.com> <5146a06e-0199-3d03-b4d6-9a4f71e4c4af@ladisch.de> From: Jia-Ju Bai Message-ID: <45ffdd2f-ad74-c6fe-3788-da3f9e4df625@163.com> Date: Mon, 9 Oct 2017 15:51:36 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <5146a06e-0199-3d03-b4d6-9a4f71e4c4af@ladisch.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-CM-TRANSID: DcCowABHWEmMKttZzY_KMQ--.37914S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjxUq380DUUUU X-Originating-IP: [166.111.70.12] X-CM-SenderInfo: xedlyx5dmximizq6il2tof0z/1tbiTQxselc6-YgWIwAAs6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for your reply :) Yes, you are right. Sorry for this false positive. Thanks, Jia-Ju Bai On 2017/10/9 14:32, Clemens Ladisch wrote: > Jia-Ju Bai wrote: >> The driver may sleep under a spinlock, and the function call path is: >> snd_opl3_note_on (acquire the spinlock) >> snd_opl3_find_patch >> kzalloc(GFP_KERNEL) --> may sleep > This call path is not possible because create_patch is not set. > > > Regards, > Clemens