From: Jason Baron <jbaron@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: fweisbec@gmail.com, mingo@elte.hu, laijs@cn.fujitsu.com,
rostedt@goodmis.org, peterz@infradead.org,
mathieu.desnoyers@polymtl.ca, jiayingz@google.com,
mbligh@google.com, roland@redhat.com, fche@redhat.com
Subject: [PATCH 1/3] tracepoints: add tracepoint_call() to optimize tracepoints disabled
Date: Tue, 19 May 2009 17:03:39 -0400 [thread overview]
Message-ID: <4600839ddabeb9b9d0aea7a72b6812d524e698ca.1242763826.git.jbaron@redhat.com> (raw)
In-Reply-To: <cover.1242763826.git.jbaron@redhat.com>
Add a wrapper function call before the call to 'trace_##name'. This preserves
the type checking, while allowing arguments that are passed to the tracepoint
to not be evaluated until after the tracepoint on/off check is performed.
This reduces the cost when tracepoints are disabled.
Signed-off-by: Jason Baron <jbaron@redhat.com>
---
include/linux/tracepoint.h | 20 +++++++++++++++++++-
1 files changed, 19 insertions(+), 1 deletions(-)
diff --git a/include/linux/tracepoint.h b/include/linux/tracepoint.h
index 14df7e6..d747c78 100644
--- a/include/linux/tracepoint.h
+++ b/include/linux/tracepoint.h
@@ -65,7 +65,6 @@ struct tracepoint {
extern struct tracepoint __tracepoint_##name; \
static inline void trace_##name(proto) \
{ \
- if (unlikely(__tracepoint_##name.state)) \
__DO_TRACE(&__tracepoint_##name, \
TP_PROTO(proto), TP_ARGS(args)); \
} \
@@ -78,6 +77,19 @@ struct tracepoint {
return tracepoint_probe_unregister(#name, (void *)probe);\
}
+/*
+ * Use this function in the instrumented code. This wrapper call to trace_##name
+ * is added so that arguments aren't evaluated, and do not have side-effects
+ * when a tracepoint is disabled. We still call the inline for type checking.
+ */
+
+#define tracepoint_call(name, ...) \
+do { \
+ extern struct tracepoint __tracepoint_##name;\
+ if (unlikely(__tracepoint_##name.state)) \
+ trace_##name(__VA_ARGS__); \
+} while (0)
+
#define DEFINE_TRACE(name) \
static const char __tpstrtab_##name[] \
__attribute__((section("__tracepoints_strings"))) = #name; \
@@ -108,6 +120,12 @@ extern void tracepoint_update_probe_range(struct tracepoint *begin,
return -ENOSYS; \
}
+#define tracepoint_call(name, ...) \
+do { \
+ if (0) \
+ trace_##name(__VA_ARGS__);\
+} while (0)
+
#define DEFINE_TRACE(name)
#define EXPORT_TRACEPOINT_SYMBOL_GPL(name)
#define EXPORT_TRACEPOINT_SYMBOL(name)
--
1.6.0.6
next prev parent reply other threads:[~2009-05-19 21:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-19 21:03 [PATCH 0/3] tracepoints: delay argument evaluation Jason Baron
2009-05-19 21:03 ` Jason Baron [this message]
2009-05-19 21:03 ` [PATCH 2/3] tracepoints: convert scheduler tracepoints to 'tracepoint_call' api Jason Baron
2009-05-19 21:03 ` [PATCH 3/3] tracepoints: convert block " Jason Baron
2009-05-19 21:17 ` [PATCH 0/3] tracepoints: delay argument evaluation Mathieu Desnoyers
2009-05-19 22:16 ` Jason Baron
2009-05-19 22:25 ` Roland McGrath
2009-05-19 22:31 ` Steven Rostedt
2009-05-19 22:36 ` Steven Rostedt
2009-05-19 23:52 ` Frederic Weisbecker
2009-05-20 0:33 ` Mathieu Desnoyers
2009-05-20 0:42 ` Steven Rostedt
2009-05-20 7:01 ` Roland McGrath
2009-05-20 7:12 ` Peter Zijlstra
[not found] ` <20090520072750.DA9A0FC38D@magilla.sf.frob.com>
2009-05-20 7:38 ` Peter Zijlstra
2009-05-20 9:18 ` Roland McGrath
2009-05-20 7:33 ` Ingo Molnar
2009-05-20 15:42 ` Jason Baron
2009-05-21 1:49 ` Jiaying Zhang
2009-05-21 1:59 ` Li Zefan
2009-05-21 2:15 ` Jiaying Zhang
2009-05-21 2:41 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4600839ddabeb9b9d0aea7a72b6812d524e698ca.1242763826.git.jbaron@redhat.com \
--to=jbaron@redhat.com \
--cc=fche@redhat.com \
--cc=fweisbec@gmail.com \
--cc=jiayingz@google.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mbligh@google.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=roland@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®