From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751281AbcFWPpr (ORCPT ); Thu, 23 Jun 2016 11:45:47 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:56224 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750799AbcFWPpq (ORCPT ); Thu, 23 Jun 2016 11:45:46 -0400 From: Arnd Bergmann To: Felipe Balbi Cc: Greg Kroah-Hartman , Magnus Damm , Sebastian Reichel , Peter Chen , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: emxx_udc: allow modular build Date: Thu, 23 Jun 2016 17:47:46 +0200 Message-ID: <4602300.g8jUUKePPf@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20160622123449.1260194-1-arnd@arndb.de> References: <20160622123449.1260194-1-arnd@arndb.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:TO/B9CUwJaxv5m3i8jaAQn+FbBN3nORDi29f2Srx5xgJ8kC/CKN eVrwOoTMy09vj+9PhzvQ23aqkBfunbqtEfacXangwgMfua8PhCjb/IuWkgAk49/ULCWL3Xk OMNWxY+TnyVx4Csxzv11AtOhphYtmooT9AhCry/oFDLrsNdVtheoPdMIVKbF9m5oeb94KqR 6c5IRd5Rd+u6cE1S0sPFQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:D09jnROCMPQ=:vGfcd1covar85r5IuZ/y/x 4tbtFrQYi/OX58tsZ5ox595Ual/siBij4q+nwxYPfTWRP5PR7be4/1x3Se8XNpf6GrzGWXFxg 25qz8BfVbCryMeWRPiis97XW8UQYoGBSOOBaZOQkyyLgMlAd4z1yIygznUPn6uf4r/pC/78SN u69NbeT0Et+mePRmK0+dVszvzk3MdEI+sD+zE8h7pOVMHyyLllYVjUnIn798rJZ5kwINCgeHa q8XCt5bRnKd3QD80KBbMzVj8cKd7s4a+aQ4C2W88lNSKguE17xU0joVFhWl185a8uguQ3LsXf hv215dRi3mUNL17HCCcsuxcdW0I1g+4KTLAwCt8kxgWHvjdy3cZ4CoQNY5/9LLQEpPKojM8A2 nF5r1LXhXVVnHG1U4dPeVLjVZP7siMsVYvw/aelsSQzw1Sv127Dpme+Cl5j7zboR/cELjXs1w Ws+SurR2yWqMi8yZKTZjT++TENdrg1ruYd+MAnsTPGvNjo0ieD5TWwPj7iK0t5gKabxILOv41 YtBnXv/x8P9YafUzXIBurtdkZFnXY87nfxodtBctXCit2W9yMnYRdU8/pRT3PDIpZQV1bc7Pp +5Ofjtw1zsbPMFZ5ZHFnmv+CE8urBBgQVU7NT7NMtLYt0tZlAOWIPR8diYi9iGNgJwTgS6a2g 4DyNho8UnBEmyqN6SMgYAjh3UgpYJ5Kn1XjBLCcoPapCBN6Zgjpi00J21CAHUte1yCeXQZRff dT81PHfbnqpQB1Oy Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, June 22, 2016 2:34:33 PM CEST Arnd Bergmann wrote: > A change to the usb gadget core allowed certain API functions to be > part of a loadable module, which breaks having emxx_udc built-in: > > drivers/staging/built-in.o: In function `nbu2ss_drv_probe': > (.text+0x2428): undefined reference to `usb_ep_set_maxpacket_limit' > > The original patch already fixed tons of other cases that have the > added dependency but apparently missed this one that now appears > in an ARM allmodconfig build. > > This patch makes the symbol "tristate", which lets the Kconfig > dependency tracking handle it correctly. > > Signed-off-by: Arnd Bergmann > Fixes: 5a8d651a2bde ("usb: gadget: move gadget API functions to udc-core") > --- > drivers/staging/emxx_udc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/emxx_udc/Kconfig b/drivers/staging/emxx_udc/Kconfig > index cc3402020487..d7577096fb25 100644 > --- a/drivers/staging/emxx_udc/Kconfig > +++ b/drivers/staging/emxx_udc/Kconfig > @@ -1,5 +1,5 @@ > config USB_EMXX > - bool "EMXX USB Function Device Controller" > + tristate "EMXX USB Function Device Controller" > depends on USB_GADGET && (ARCH_SHMOBILE || (ARM && COMPILE_TEST)) > help > The Emma Mobile series of SoCs from Renesas Electronics and > I ran into another build error in some configrations, please disregard this one and use v2 instead. Arnd