From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751538AbdJCJkC (ORCPT ); Tue, 3 Oct 2017 05:40:02 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:51306 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751190AbdJCJkA (ORCPT ); Tue, 3 Oct 2017 05:40:00 -0400 X-AuditID: b6c32a48-c0fff70000001005-0b-59d35aed5522 From: Bartlomiej Zolnierkiewicz To: Lorenzo Pieralisi Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Bjorn Helgaas , Richard Henderson , Ivan Kokshaysky , "David S. Miller" , Guenter Roeck , Matt Turner Subject: Re: [PATCH v2] drivers/ide/pci: Fix legacy IRQ assignment Date: Tue, 03 Oct 2017 11:39:55 +0200 Message-id: <4605844.iOhxHctWQT@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <1506941567-10762-1-git-send-email-lorenzo.pieralisi@arm.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBKsWRmVeSWpSXmKPExsWy7bCmqe7bqMuRBnuXqlgsacqwmHO+hcXi 36mNzBbHdjxisri8aw6bxdl5x9ksniw8w2Tx5vcLdotPtw8yW0w7dYfVgctjzbw1jB5bVt5k 8tg56y67x4JNpR7/z0Z57PzewO7RN/0Ds8fnTXIBHFFcNimpOZllqUX6dglcGdNen2Mu2KBd 8Xj/U7YGxikqXYycHBICJhJ7n/5i7mLk4hAS2MEosfnROjYI5zujxN5X51lgquZ3/GSCSGxg lNjUsJYVwvnKKLHt7n9mkCo2ASuJie2rGEFsEQFDiZ5Tq8E6mAUOM0l86XzO3sXIwSEs4CTx aUYASA2LgKrEnfZ1TCA2r4CmxLbDp9hBbFEBL4kt+9rB4pxA9rqJT1ggagQlfky+B2YzC8hL 7Ns/lRXC1pE4e2wdI8guCYHnbBLX7vYxQ5ztIvF/UwcThC0s8er4FnYIW1ri2aqNjBD2dEaJ 7b8lIJo3M0qs2j0Bqsha4vDxi1Ab+CQ6Dv8Fe0BCgFeio00IosRDYsepp1C7HCU2z+thgYTK XEaJa89b2Ccwys5CcvgsJIfPQnL4AkbmVYxiqQXFuempxUYFJnrFibnFpXnpesn5uZsYwelF y2MH44FzPocYBTgYlXh4E9wuRQqxJpYVV+YeYpTgYFYS4Z3mdTlSiDclsbIqtSg/vqg0J7X4 EKM0B4uSOG/dtmsRQgLpiSWp2ampBalFMFkmDk6pBkanqj07tp9Yy6RtZnFWZH8Zd5DT5lti e7rOHb70U7Jr/ZegSyutJVOSJ6amu8YsXK8as/ZGm9G5t6cOCd246fIhe03zOVkW462iq89K yCqol+o/Wuav4741dp2nzc113Z6uhYHy0hfVBHkE2KIuBK0X2S+2Nvn4CRWxH6KiCe0Vjp3T 9Kdf/KjEUpyRaKjFXFScCADgwTaQKwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrPLMWRmVeSWpSXmKPExsVy+t9jQd23UZcjDTa18VosacqwmHO+hcXi 36mNzBbHdjxisri8aw6bxdl5x9ksniw8w2Tx5vcLdotPtw8yW0w7dYfVgctjzbw1jB5bVt5k 8tg56y67x4JNpR7/z0Z57PzewO7RN/0Ds8fnTXIBHFFcNimpOZllqUX6dglcGdNen2Mu2KBd 8Xj/U7YGxikqXYycHBICJhLzO34ydTFycQgJrGOUaN7QC+V8ZZR42jePGaSKTcBKYmL7KkYQ W0TAUKLn1GqwImaBo0wSfw7fBEpwcAgLOEl8mhEAUsMioCpxp30dE4jNK6Apse3wKXYQW1TA S2LLvnawOCeQvW7iExYQW0jAU+L3ijYWiHpBiR+T74HZzALyEvv2T2WFsLUk1u88zjSBkX8W krJZSMpmISlbwMi8ilEytaA4Nz232KjAKC+1XK84Mbe4NC9dLzk/dxMjMBq2Hdbq38H4eEn8 IUYBDkYlHt4dHpcihVgTy4orcw8xSnAwK4nwTvO6HCnEm5JYWZValB9fVJqTWnyIUZqDRUmc lz//WKSQQHpiSWp2ampBahFMlomDU6qB8cDsa/anv/3KfeXv8E65bqWRwSNfKVGxZ9ceav87 qBmgc2Y/zxWGzx7uG9X5GA44PIix2bUv/eTBu6Xh4YkTLLZdjTRV710fX+v/U4yto3Ghs9kJ 9wfSFxTTPjYV+H20XyG8KHPNxIOFXa+0pOtviDkx+U5a+Fxn94+uVw1vGBl2iX50Y65fqMRS nJFoqMVcVJwIADZr2ViCAgAA X-CMS-MailID: 20171003093957epcas2p4b14b17bb8a93bbe77b385bca6d8f0c3c X-Msg-Generator: CA X-Sender-IP: 182.195.42.143 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 102P X-CMS-RootMailID: 20171003093957epcas2p4b14b17bb8a93bbe77b385bca6d8f0c3c X-RootMTR: 20171003093957epcas2p4b14b17bb8a93bbe77b385bca6d8f0c3c References: <1506941567-10762-1-git-send-email-lorenzo.pieralisi@arm.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, October 02, 2017 11:52:47 AM Lorenzo Pieralisi wrote: > Through struct pci_host_bridge->{map/swizzle}_irq() hooks is now > possible to define IRQ mapping functions on a per PCI host bridge basis. > > Actual IRQ allocation is carried out by the pci_assign_irq() function in > pci_device_probe() - to make sure a device is assigned an IRQ only if it > is probed (ie match a driver); it retrieves a struct pci_host_bridge* > for a given PCI device and through {map/swizzle}_irq() it carries out > the PCI IRQ allocation. > > The code conversion to struct pci_host_bridge {map/swizzle}_irq() hooks > and pci_assign_irq() to deal with legacy IRQs in > > commit 30fdfb929e82 ("PCI: Add a call to pci_assign_irq() in > pci_device_probe()") > > did not take into account that the IDE subsystem relies on a special > purpose IDE PCI layer, configured by CONFIG_IDEPCI_PCIBUS_ORDER to force > devices probe ordering by sidestepping the core PCI bus layer entirely > (and therefore pci_device_probe()) by executing the registered IDE PCI > drivers probe routines (ie registered with ide_pci_register_driver()) > through ide_scan_pcidev(). > > Since this IDE PCI specific probe mechanism bypasses the PCI core > code generic probing (ie pci_device_probe()) it also misses the > pci_assign_irq() call (among other PCI initialization functions); > this triggers IDE PCI devices initialization failures caused > by the missing IRQ allocation: > > ide0: disabled, no IRQ > ide0: failed to initialize IDE interface > ide0: disabling port > cmd64x 0000:00:02.0: IDE controller (0x1095:0x0646 rev 0x07) > CMD64x_IDE 0000:00:02.0: BAR 0: can't reserve [io 0x8050-0x8057] > cmd64x 0000:00:02.0: can't reserve resources > CMD64x_IDE: probe of 0000:00:02.0 failed with error -16 > ide_generic: please use "probe_mask=0x3f" module parameter for probing > all legacy ISA IDE ports > ------------[ cut here ]------------ > WARNING: CPU: 0 PID: 1 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x94/0xd0 > sysfs: cannot create duplicate filename '/class/ide_port/ide0' > ... > > Trace: > [] __warn+0x160/0x190 > [] sysfs_warn_dup+0x94/0xd0 > [] warn_slowpath_fmt+0x58/0x70 > [] sysfs_warn_dup+0x94/0xd0 > [] kernfs_path_from_node+0x30/0x60 > [] kernfs_put+0x16c/0x2c0 > [] kernfs_put+0x16c/0x2c0 > [] sysfs_do_create_link_sd.isra.2+0x100/0x120 > [] device_add+0x2a4/0x7c0 > [] device_create_groups_vargs+0x14c/0x170 > [] device_create_groups_vargs+0x98/0x170 > [] device_create+0x50/0x70 > [] ide_host_register+0x48c/0xa00 > [] ide_host_register+0x450/0xa00 > [] device_register+0x20/0x50 > [] ide_host_register+0x450/0xa00 > [] ide_host_add+0x64/0xe0 > [] kobject_uevent_env+0x16c/0x710 > [] do_one_initcall+0x68/0x260 > [] kernel_init+0x1c/0x1a0 > [] kernel_init+0x0/0x1a0 > [] ret_from_kernel_thread+0x18/0x20 > [] kernel_init+0x0/0x1a0 > > ---[ end trace 24a70433c3e4d374 ]--- > ide0: disabling port > > Fix the IRQ allocation issue by adding a pci_assign_irq() call in the > ide_scan_pcidev() function before probing the IDE PCI drivers, so that > IRQs for a given PCI device are allocated for the IDE PCI drivers to > use them for device configuration. > > Fixes: 30fdfb929e82 ("PCI: Add a call to pci_assign_irq() in pci_device_probe()") > Link: http://lkml.kernel.org/r/32ec730f-c1b0-5584-cd35-f8a809122b96@roeck-us.net > Signed-off-by: Lorenzo Pieralisi > Reported-by: Guenter Roeck > Cc: Bjorn Helgaas > Cc: Richard Henderson > Cc: Ivan Kokshaysky > Cc: David S. Miller > Cc: Guenter Roeck > Cc: Matt Turner Reviewed-by: Bartlomiej Zolnierkiewicz > --- > v1->v2 > > - Moved fix from PCI core code to IDE subsystem following further > debugging and mailing list discussions > - Rebased against v4.14-rc3 > > drivers/ide/ide-scan-pci.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/drivers/ide/ide-scan-pci.c b/drivers/ide/ide-scan-pci.c > index 86aa88a..acf8748 100644 > --- a/drivers/ide/ide-scan-pci.c > +++ b/drivers/ide/ide-scan-pci.c > @@ -56,6 +56,7 @@ static int __init ide_scan_pcidev(struct pci_dev *dev) > { > struct list_head *l; > struct pci_driver *d; > + int ret; > > list_for_each(l, &ide_pci_drivers) { > d = list_entry(l, struct pci_driver, node); > @@ -63,10 +64,14 @@ static int __init ide_scan_pcidev(struct pci_dev *dev) > const struct pci_device_id *id = > pci_match_id(d->id_table, dev); > > - if (id != NULL && d->probe(dev, id) >= 0) { > - dev->driver = d; > - pci_dev_get(dev); > - return 1; > + if (id != NULL) { > + pci_assign_irq(dev); > + ret = d->probe(dev, id); > + if (ret >= 0) { > + dev->driver = d; > + pci_dev_get(dev); > + return 1; > + } > } > } > } Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics