From: Roger Quadros <rogerq@ti.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: <davem@davemloft.net>, <tony@atomide.com>, <nsekhar@ti.com>,
<jsarha@ti.com>, <netdev@vger.kernel.org>,
<linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: davinci_mdio: add GPIO reset logic
Date: Thu, 6 Apr 2017 19:48:50 +0300 [thread overview]
Message-ID: <4611f957-4de2-ccf6-c9e6-1ace1f3f8ac3@ti.com> (raw)
In-Reply-To: <20170406120532.GC13219@lunn.ch>
On 06/04/17 15:05, Andrew Lunn wrote:
>>> Do you really need more than one GPIO? A single gpio would make all
>>> this code a lot simpler.
>>>
>>
>> Yes we need. Some of our boards have separate GPIO RESET lines for
>> different PHYs on the same MDIO bus.
>
> If you have a one-to-one mapping of GPIO and PHY, you should really be
> modelling that differently. You want to be able to reset just a single
> PHY, i.e. make it part of the PHY driver, or maybe the PHY core.
>
> Andrew
>
I'm not sure how it would be modelled. We have never had the need to reset
just one PHY on the MDIO bus.
Some boards have a single RESET line to multiple PHYs whereas others have individual
RESET lines. In all cases we just want to do the RESET once per boot.
cheers,
-roger
next prev parent reply other threads:[~2017-04-06 16:49 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 8:33 Roger Quadros
2017-04-05 15:03 ` Andrew Lunn
2017-04-06 9:15 ` Roger Quadros
2017-04-06 12:05 ` Andrew Lunn
2017-04-06 16:48 ` Roger Quadros [this message]
2017-04-08 13:55 ` David Miller
2017-04-08 15:10 ` Andrew Lunn
2017-04-08 15:18 ` Florian Fainelli
2017-04-10 7:52 ` Roger Quadros
2017-04-19 9:24 ` [PATCH] mdio_bus: Issue GPIO RESET to PHYs Roger Quadros
2017-04-19 11:39 ` Andrew Lunn
2017-04-19 11:56 ` Roger Quadros
2017-04-19 13:38 ` Andrew Lunn
2017-04-20 7:58 ` Roger Quadros
2017-04-20 8:39 ` [PATCH v2] " Roger Quadros
2017-04-20 13:13 ` Andrew Lunn
2017-04-20 13:56 ` Roger Quadros
2017-04-20 14:11 ` [PATCH v3 net-next] " Roger Quadros
2017-04-21 1:12 ` Andrew Lunn
2017-04-21 1:23 ` Florian Fainelli
2017-04-21 1:38 ` Andrew Lunn
2017-04-21 8:04 ` Roger Quadros
2017-04-21 13:15 ` [PATCH v4 " Roger Quadros
2017-04-21 13:31 ` Lars-Peter Clausen
2017-04-23 23:35 ` Andrew Lunn
2017-04-24 9:04 ` Roger Quadros
2017-04-24 16:32 ` Florian Fainelli
2017-04-25 16:22 ` Lars-Peter Clausen
2017-04-25 16:31 ` Florian Fainelli
2017-04-26 10:46 ` Roger Quadros
2017-04-26 12:27 ` Andrew Lunn
2017-04-26 10:43 ` Roger Quadros
2017-04-24 16:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4611f957-4de2-ccf6-c9e6-1ace1f3f8ac3@ti.com \
--to=rogerq@ti.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=jsarha@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®