From: Neil Armstrong <neil.armstrong@linaro.org>
To: Johan Hovold <johan@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>
Cc: linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org,
"Álvaro Fernández Rojas" <noltari@gmail.com>
Subject: Re: [PATCH] phy: broadcom: bcm63xx-usbh: fix section mismatches
Date: Wed, 19 Nov 2025 16:07:28 +0100 [thread overview]
Message-ID: <461244a1-3bc1-478f-b97f-b0607375e596@linaro.org> (raw)
In-Reply-To: <20251017054537.6884-1-johan@kernel.org>
On 10/17/25 07:45, Johan Hovold wrote:
> Platform drivers can be probed after their init sections have been
> discarded (e.g. on probe deferral or manual rebind through sysfs) so the
> probe function and match table must not live in init.
>
> Fixes: 783f6d3dcf35 ("phy: bcm63xx-usbh: Add BCM63xx USBH driver")
> Cc: stable@vger.kernel.org # 5.9
> Cc: Álvaro Fernández Rojas <noltari@gmail.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/phy/broadcom/phy-bcm63xx-usbh.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/phy/broadcom/phy-bcm63xx-usbh.c b/drivers/phy/broadcom/phy-bcm63xx-usbh.c
> index 647644de041b..29fd6791bae6 100644
> --- a/drivers/phy/broadcom/phy-bcm63xx-usbh.c
> +++ b/drivers/phy/broadcom/phy-bcm63xx-usbh.c
> @@ -375,7 +375,7 @@ static struct phy *bcm63xx_usbh_phy_xlate(struct device *dev,
> return of_phy_simple_xlate(dev, args);
> }
>
> -static int __init bcm63xx_usbh_phy_probe(struct platform_device *pdev)
> +static int bcm63xx_usbh_phy_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct bcm63xx_usbh_phy *usbh;
> @@ -432,7 +432,7 @@ static int __init bcm63xx_usbh_phy_probe(struct platform_device *pdev)
> return 0;
> }
>
> -static const struct of_device_id bcm63xx_usbh_phy_ids[] __initconst = {
> +static const struct of_device_id bcm63xx_usbh_phy_ids[] = {
> { .compatible = "brcm,bcm6318-usbh-phy", .data = &usbh_bcm6318 },
> { .compatible = "brcm,bcm6328-usbh-phy", .data = &usbh_bcm6328 },
> { .compatible = "brcm,bcm6358-usbh-phy", .data = &usbh_bcm6358 },
> @@ -443,7 +443,7 @@ static const struct of_device_id bcm63xx_usbh_phy_ids[] __initconst = {
> };
> MODULE_DEVICE_TABLE(of, bcm63xx_usbh_phy_ids);
>
> -static struct platform_driver bcm63xx_usbh_phy_driver __refdata = {
> +static struct platform_driver bcm63xx_usbh_phy_driver = {
> .driver = {
> .name = "bcm63xx-usbh-phy",
> .of_match_table = bcm63xx_usbh_phy_ids,
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2025-11-19 15:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 5:45 Johan Hovold
2025-11-10 9:12 ` Johan Hovold
2025-11-19 15:07 ` Neil Armstrong [this message]
2025-11-20 17:11 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=461244a1-3bc1-478f-b97f-b0607375e596@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=johan@kernel.org \
--cc=kishon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=noltari@gmail.com \
--cc=stable@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®