From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010009.outbound.protection.outlook.com [52.101.201.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F9313E1208 for ; Wed, 5 Aug 2026 09:12:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.201.9 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785921160; cv=fail; b=CDPHx4Tbutvc1/eQZW7MWv/WnWILFGnk+4I594kKRFwvGKIkv+RB58RcOfZuz95ALkpSJZhC5K71hd8Fa0ckGKGCViWJ9KUxnGlhxM8+TsABW/CNfnzUdR5uWEH9dhPr4utp8Qp3wD35ziXEwU0UVM8VxWhOHrJLLFRbuEtMaaA= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785921160; c=relaxed/simple; bh=YubdxYQtDoHIg0RIsSQ9Rob26UIULhCHsAgQGcWeWcA=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=DSL2jwKyF8w3clvFC+X0FPr4vS0GINYONSPteM9CxevBssbczMC8/xN0v+zL5uTiAyvpOEclrfoMSEFec6SNtDHI7u5FtQX83uP2EUJmgNhh9Hss/wAMxEPQRA+p/y1HlUbq5celBqQ+J2djr5F6efc1X432qQruQ9frOvJDP7Q= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=IWkMS2Jp; arc=fail smtp.client-ip=52.101.201.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="IWkMS2Jp" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=u7eEDNClcPwNWryBKsr6P+lyLKWc8GHN7V9NugvBq+XPYubCctxZeoq/z/IbY9wmN0qxMpF6bmiDN1CYPYVzOJiipx5UgGuZ1Rkd4DuhdAbpV2cPcJBBugILYGaULwsWsOI7wUkFLI2Moqe+qyXzpyBfLb/y8QluiE0U0K4xbKRkUspDoM+5JPETr/bSd1EyMQ/RQVNCpuxEvHHrmZm5u/RflvMwnNaSen+f1lQmDd2vBJ2DJRQNdujWo5JggYONNr4wpz/YB/ivZZ3cijAFyGsXi2FjHYygahHLudg9WCUFq0zMTZOU9alYtzEmUUGTf3wLB51pS1hLh44oVkLrGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3utmKniIiZQnWgI5uW5Xr/OhnIFQwLQX0mNELCHCELk=; b=szZ5nhn6OU4PPXRKeUDL7k215RhWCPsdfhiyWV3jpIcrJdb6QFnHHYVdiTzQJieCqRc6sCRs3JLjpMoBMWwLrrdJSB3k0I0wYreqm/052P31e163nLFXYjesY4q8CuAT0WREs0LWkwewScEOBTZ2aX0GxdPsDOJb89nMeB56iGoZZQfTrHKhB7R7HrYQR1TOZ3ikd5h7jPB04Ax6E4HdBzfht2u08y8yEnNln4a0cBLRs5oEGi4j7AeHAdjWBIY9aVGBMuIJiv6IiG4/T/0nIGMWHocOHdv2lim5dTMBmsczPiDINVlxBaO4Ml/z1hygXDzzgQZTp3iFizOqUaBZPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kylinos.cn smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3utmKniIiZQnWgI5uW5Xr/OhnIFQwLQX0mNELCHCELk=; b=IWkMS2JpOd/2RiIkfoGH9GeO9NRmG2AsLyhhWGYsus75AdB/L03Iuqg14YoJL8sq0yETnha+PZJpTTpxUPl6qyo3TccAJSeB3WDulJfXJuS2csEoTUqxuDZt+1b1PrraJPQXIMooq18kYorap0CF+q60mUwLaDuwd4Kfi1C/Qks= Received: from CH0PR04CA0058.namprd04.prod.outlook.com (2603:10b6:610:77::33) by DM6PR12MB4123.namprd12.prod.outlook.com (2603:10b6:5:21f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.19; Wed, 5 Aug 2026 09:12:33 +0000 Received: from CH3PEPF0000000B.namprd04.prod.outlook.com (2603:10b6:610:77:cafe::28) by CH0PR04CA0058.outlook.office365.com (2603:10b6:610:77::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.270.18 via Frontend Transport; Wed, 5 Aug 2026 09:12:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by CH3PEPF0000000B.mail.protection.outlook.com (10.167.244.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.8 via Frontend Transport; Wed, 5 Aug 2026 09:12:33 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Wed, 5 Aug 2026 04:12:32 -0500 Received: from [10.136.47.95] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Wed, 5 Aug 2026 04:12:29 -0500 Message-ID: <4613455c-8e26-4746-9dc9-c2e3d793244e@amd.com> Date: Wed, 5 Aug 2026 14:42:23 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] sched/fair: Remove dead throttled check in pick_task_fair() To: fangqiurong , Ingo Molnar , Peter Zijlstra CC: Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , References: <20260805013949.151089-1-fangqiurong@kylinos.cn> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <20260805013949.151089-1-fangqiurong@kylinos.cn> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF0000000B:EE_|DM6PR12MB4123:EE_ X-MS-Office365-Filtering-Correlation-Id: 56a76a8c-c897-4816-bc9d-08def2d1af0f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|23010399003|36860700016|1800799024|82310400026|10067099003|11063799006|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: gOnJsomdgjXl6+rEkEm/6XnOuqYJpcUKWYrtPguQ2WTA6ewhl1DFXu+x0xR2eKs2T2cVgI2Vmq6BZ2RJ1ajrM+EGgZLMx4e4fm9O7ac/JzTnBpSxxNDHORKILTayFUfdDfa/wbfhc3RGE+oTfuINxpMKtZI1jxHEitEQSCEZ1g8vOBhm5W/Rit1YdTVbn1znpi8ZkgFwQhdeoVFwwq3FAfDdRMRvLF8NXi/Sdk6ZYDRJ2yMMCWe+inj2dnp4B9FgOfblF2GVJGC089HuPxXxTBsV7X9Sknum5Ijc8AK4NnOoeJUvsXO3KsdJ7b1Ox/zWqwqsPJz+Vnsn4MCGUTvzu3t0hOn6SpUc9MeJpKaiAIoT0jc9EbAhh4UP51RzdUVZBRRIQSVQiRM5cXzqr6JUcZfKTJeO4eUDzuR2+4MjPU5iqJGtSgzsEldTst9+VsdYOoz2T2ZmlsuJgshY1hDpkIv5bsZ9d8SoSFNYRMgx3qO8eCRCvQ6DF2ii9218y0VryP0teCnexV9pRNPAG3wYtXc41225IoIJULdT3NgWwyk4CaBIB6c+RBM88p3A6tYb6WC8EJFOrDhra3A2i70hubx+gsgpLHGympC9bJQgImlxp9nDU/NSoKWnHE+s3PvNr+Hv5FNAYM7EUUqZmfmr6s36yzw32nK9RHC1boOBPYFJiSnodTVAtiDSnQdj2XU6i6Nb++rdB6QxckvAqnKaRw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(7416014)(376014)(23010399003)(36860700016)(1800799024)(82310400026)(10067099003)(11063799006)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: MHr45QyiDNB3CkP2TZgh/U0p7/EDSn1NkKDPcfIXJ6fB5UU6VRkxPDzY/+QyNUG3o8fFOb/dYjCuCTgsIHL+Eo2e4SWG/XoZG7TPI2mXRv+kH87/mY3zBwBUBmHEDnLYWQDkx7okGm7A0VRAQ0U/o4DMheD/8ulz2IfbSNoNWkOJmOH4FW7ZIL0JQI4o2yEVyB79v9R9TJ4F21rzo/1e4HpIJcWETsuu/wYamMaUYS0wiTMkZ2UUjgzT40QCZ922Fi3dERQfCtmdmi4NfLH6YXzzrhRchqP13sPsDVzPy020xyJplurPDkfGpGBjrsCYGgM85Ru0yYgm4KZcGq4aE79FCgPrhiFtg2uGWnN/28Qm7nm0ewoOxhrB+ymFvTdI3d2xuTI/LB0OeJMJomIBrfZ59n2eixjA3HRQ7kmp4gzi9AHkIwX0gYGGQBQAZDHT X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2026 09:12:33.1766 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 56a76a8c-c897-4816-bc9d-08def2d1af0f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF0000000B.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4123 On 8/5/2026 7:09 AM, fangqiurong wrote: > commit f666241e6bd5 ("sched/fair: Unify cfs_rq throttling via > account_cfs_rq_runtime()") removed the only assignment to @throttled in > the pick_task_fair() walk loop, making the variable and the trailing > task_throttle_setup_work() call dead code. Drop them. Thank you for catching my oversight. Looking at tip:sched/core, Peter has already cleaned this up as a part of commit 85570f10a4c6 ("sched/eevdf: Move to a single runqueue") -- Thanks and Regards, Prateek