From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965044AbXDLTtQ (ORCPT ); Thu, 12 Apr 2007 15:49:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965529AbXDLTtP (ORCPT ); Thu, 12 Apr 2007 15:49:15 -0400 Received: from gw.goop.org ([64.81.55.164]:59173 "EHLO mail.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965044AbXDLTtO (ORCPT ); Thu, 12 Apr 2007 15:49:14 -0400 Message-ID: <461E8D16.6060202@goop.org> Date: Thu, 12 Apr 2007 12:48:38 -0700 From: Jeremy Fitzhardinge User-Agent: Thunderbird 1.5.0.10 (X11/20070302) MIME-Version: 1.0 To: Zachary Amsden CC: Andrew Morton , Andi Kleen , Rusty Russell , Chris Wright , Hugh Dickins , David Rientjes , Michel Lespinasse , Virtualization Mailing List , Linux Kernel Mailing List Subject: Re: [PATCH 1/4] Pte drop ptep_get_and_clear paravirt op.patch References: <200704120530.l3C5Ubs0022821@zach-dev.vmware.com> In-Reply-To: <200704120530.l3C5Ubs0022821@zach-dev.vmware.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Zachary Amsden wrote: > In shadow mode hypervisors, ptep_get_and_clear achieves the desired > purpose of keeping the shadows in sync by issuing a native_get_and_clear, > followed by a call to pte_update, which indicates the PTE has been > modified. > > Direct mode hypervisors (Xen) have no need for this anyway, and will trap > the update using writable pagetables. > > This means no hypervisor makes use of ptep_get_and_clear; there is no > reason to have it in the paravirt-ops structure. Change confusing > terminology about raw vs. native functions into consistent use of > native_pte_xxx for operations which do not invoke paravirt-ops. > Looks OK to me. Are you going to put this into the pvops queue? Acked-by: Jeremy Fitzhardinge J