From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Theodore Ts'o <tytso@mit.edu>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virt: vmgenid: drop redundant .owner
Date: Tue, 26 Mar 2024 09:07:52 +0100 [thread overview]
Message-ID: <461a8c3d-460b-4ca4-aa90-b70685958f6f@linaro.org> (raw)
In-Reply-To: <20240326075337.55377-1-krzysztof.kozlowski@linaro.org>
On 26/03/2024 08:53, Krzysztof Kozlowski wrote:
> Core already sets .owner in acpi_bus_register_driver().
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> drivers/virt/vmgenid.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/virt/vmgenid.c b/drivers/virt/vmgenid.c
> index b67a28da4702..8f6880c3a87f 100644
> --- a/drivers/virt/vmgenid.c
> +++ b/drivers/virt/vmgenid.c
> @@ -88,7 +88,6 @@ static const struct acpi_device_id vmgenid_ids[] = {
> static struct acpi_driver vmgenid_driver = {
> .name = "vmgenid",
> .ids = vmgenid_ids,
> - .owner = THIS_MODULE,
This does not make sense and is not correct. I need to fix
acpi_bus_register_driver first(). Please ignore.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-26 8:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 7:53 Krzysztof Kozlowski
2024-03-26 8:07 ` Krzysztof Kozlowski [this message]
2024-03-26 14:17 ` Jason A. Donenfeld
2024-03-26 16:10 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=461a8c3d-460b-4ca4-aa90-b70685958f6f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Jason@zx2c4.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®