From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E67112DECB2 for ; Fri, 13 Mar 2026 13:05:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773407118; cv=none; b=L/7etg1ziMtrHqbuX43CnNsmf0tNVqZ/5MnOUoTvvPv7mn4rBsaXkNqFNi10Tz04px4g/xYn3Ld5rnq6+A5R/GbNKQMN1UOV2Hg1ZDzLQKdhtLoUWfDsp05SYgBEwl6L0f5n17O1U8jFNwKsrwLeOI5ZQjBV4ACWDznw4vdELsY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773407118; c=relaxed/simple; bh=QlDMUd7f1JdkVm7v5UibiBKuEOhJyK5M/xPgVuOcFWw=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=KNmmTr15WoiZRV8hq39LG4xg8F1phKe+bjdfnCz30mJodLHb4pbZb6ITCwEa6Nt1q6nBGP9sDcDNPy9Tj9cUrs/Q8tRZ0sFDVUgaP1hOchyzToFuGHZNFJZubhJJ2WtjrzciJOySLF0eusftJEn8uISMfahSlg7CKTCSMBabBnI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=iyEOnwVI; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=GHMznxlD; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iyEOnwVI"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="GHMznxlD" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773407115; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QlDMUd7f1JdkVm7v5UibiBKuEOhJyK5M/xPgVuOcFWw=; b=iyEOnwVIdVfw9zoy7nlNJo/adH0F4S79X1qGLE2LPKbvfY4zHKV9EBXPouweX+hfp4tas0 M0ztce/dpd3ZAwP3kqP9V9PV8Q0oHTyMSGgSx7eiV6u5e8AZMYcUU0LHGDjDrxgi0fmvOV aBejG6zDjtyj7r/4vUb9d5k9NWoAQ6Y= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-567-wOfOzWqCOx6sdYAndwN43w-1; Fri, 13 Mar 2026 09:05:14 -0400 X-MC-Unique: wOfOzWqCOx6sdYAndwN43w-1 X-Mimecast-MFC-AGG-ID: wOfOzWqCOx6sdYAndwN43w_1773407113 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-439b8858b0cso1838249f8f.0 for ; Fri, 13 Mar 2026 06:05:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773407113; x=1774011913; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=QlDMUd7f1JdkVm7v5UibiBKuEOhJyK5M/xPgVuOcFWw=; b=GHMznxlD7MOfjtRiyHiWuP41SgfIknhFBwMBw6B/fTT4qGEgpLE+pCeXkwbDLSgrOn yWKAIYpDV3AKftwjtARkwsEwQku+tZ1pj1kSeAV4bGmoEkcYB2/s2691yaCBv4RK4LdO SN5DQeN+Jp6m2xbJ7BrhPD8IBR8LSYCzAY95QIHiyzcPdTUuUFeks9NP7j207IRc/agC UBXjKKIVvdQYT69JXK41nVhhLH09tV/yiYIXhlqlCbcrO8OQUSf6xP7ccvJIuiurpB9C qs5QayPv0nszT5lAF8Juz9HJHDoOYkb/KRaoy/WV5xnu4DVDXgX1RzlodJUfMy8m0xOR Q2Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773407113; x=1774011913; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QlDMUd7f1JdkVm7v5UibiBKuEOhJyK5M/xPgVuOcFWw=; b=ndyQVVA7clejCqY41HQIHmEVEpEo3hTADDvEwFvYD0rBnLH5f4vBWLLgLL7OW84YRR TrFVf/NpyubV6rEhSXw+BzY/IL3qPsbyGVxNs23+A/WW0oKRBsSUngjy6QzTSjB0luIk gtmzgUwtBRuFGEWWfAZMVFXHpHZPeyquO9kHPaCYXynvi61B0BhwUKuKmMETDbSIbmd0 dI2PbYsTId1VsSsldtb0q094FGq5b3TXPg4WtFfGTnDNOTfocxdMohgBu8tSNCk2Q5Sz wOWEnlw+XeDwHZ3KGpuo2TfyWA1+BsfWh4t0LtvlgdCf05LzgWDIUTLLP4Xr+HmWXPuY eWMg== X-Gm-Message-State: AOJu0Yzd1uXKemNr0EuFi2XrCakNFGRGui3a4KegJ6e0cpqqpeWT+zyc oBXGQd4ykrM4akWskEaLRM1rQp4y25v2q1XrN09/jK+pSEb0CwHmaezEKRQWe/z2zYZD/87SWcN oonoCiZSqWhYXG5EjA4KY5qRF9gJiMK2SzvXIq1R1DAzjnoQthkB11jrXBhnMWsLAoQ== X-Gm-Gg: ATEYQzzJ1Icojyp1ELgDy5WabF56SZoDYOpPPn8DCLMI69v6IK4vfZBf2pJpY6D2cx4 HzjTmH2HuWnBrJ1kxAfMUnnfVPxdQ2/NHSr++6j0DFWSmFBLdxOkxaohUtDydZEjXKjwXgJGSRJ +MqYSovRk4QzdXWppIS2nQmLVGS/cIgnszAV/Hgxcp+G0Bz1pb6w0isFMTSc7zFAj/d6bVk0kPz HrTpVj2+u8xg4Tp2Q0tSr2AVaQCFqzbz7/rrjsQJe+p6XX5Yg7gDafSsZFHwshzIAJEu7+Bt8vW E9VGrjMDv4h/Mgiv5YPNO5Y+UyUGfLIlHM3N9WMDQAzirkVVm6QiDpW1NAYplzvvtfrOU/lZvbx iWtte6vRJW8uA1GgfO2E5NULVpQ== X-Received: by 2002:a05:6000:288c:b0:439:c9dd:cd5f with SMTP id ffacd0b85a97d-43a04d863bfmr6367985f8f.19.1773407110630; Fri, 13 Mar 2026 06:05:10 -0700 (PDT) X-Received: by 2002:a05:6000:288c:b0:439:c9dd:cd5f with SMTP id ffacd0b85a97d-43a04d863bfmr6367443f8f.19.1773407106833; Fri, 13 Mar 2026 06:05:06 -0700 (PDT) Received: from [192.168.1.166] ([185.168.96.228]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fe21b631sm20184469f8f.27.2026.03.13.06.05.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 06:05:06 -0700 (PDT) Message-ID: <4620e92b1c7f4d87f192a017f3026dfc17bcaef6.camel@redhat.com> Subject: Re: [PATCH v7 05/15] Documentation/rv: Add documentation about hybrid automata From: gmonaco@redhat.com To: Juri Lelli Cc: linux-kernel@vger.kernel.org, Steven Rostedt , Nam Cao , Juri Lelli , Jonathan Corbet , linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Tomas Glozar , Clark Williams , John Kacur Date: Fri, 13 Mar 2026 14:05:05 +0100 In-Reply-To: References: <20260310105627.332044-1-gmonaco@redhat.com> <20260310105627.332044-6-gmonaco@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hello, On Thu, 2026-03-12 at 11:39 +0100, Juri Lelli wrote: > Very minor nit, feel free to ignore, but ... >=20 > The formal 7-tuple definition includes 'i' (invariant function), but > unlike other elements, 'i' isn't stored in the automaton struct - > it's implemented as generated code in ha_verify_constraint(), IIUC. > Worth a brief note clarifying this design choice so readers don't > expect to find an invariants[] member in the struct? Here or below in > the example C code section. Thanks for the review! I haven't really thought of that. At this stage we are not mentioning any struct element (it's purely theoretical), so there shouldn't be any expectation from the reader. Later I mention "The function verify_constraint checks guards, performs resets and starts timers to validate invariants according to specification". In fact, also guards are not represented as part of 'function', I may mention after that sentence something like: "those cannot easily be represented in the automaton struct". Not sure if saying more wouldn't make it even more confusing than it already is. Thanks, Gabriele