From: Alexander Graf <agraf@suse.de>
To: Jim Mattson <jmattson@google.com>
Cc: "kvm list" <kvm@vger.kernel.org>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
"Gabriel L. Somlo" <gsomlo@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"the arch/x86 maintainers" <x86@kernel.org>,
"Joerg Roedel" <joro@8bytes.org>,
linux-doc@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [PATCH v6] kvm: better MWAIT emulation for guests
Date: Tue, 11 Apr 2017 20:23:18 +0200 [thread overview]
Message-ID: <4622E361-52AB-40F2-9915-45C48F0DBCD2@suse.de> (raw)
In-Reply-To: <CALMp9eT220btgiw7S-0cLswr1j=-OCuMwOAWuWS51EmNYYRuJw@mail.gmail.com>
> Am 11.04.2017 um 19:10 schrieb Jim Mattson <jmattson@google.com>:
>
> This might be more useful if it could be dynamically toggled on and
> off, depending on system load.
What would trapping mwait (currently) buy you?
As it stands today, before this patch, mwait is simply implemented as a nop, so enabling the trap just means you're wasting as much cpu time, but never send the pCPU idle. With this patch, the CPU at least has the chance to go idle.
Keep in mind that this patch does *not* advertise the mwait cpuid feature bit to the guest.
What you're referring to I guess is actual mwait emulation. That is indeed more useful, but a bigger patch than this and needs some more thought on how to properly cache the monitor'ed pages.
Alex
next prev parent reply other threads:[~2017-04-11 18:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 11:45 Alexander Graf
2017-04-11 12:41 ` Gabriel L. Somlo
2017-04-11 12:43 ` Gabriel L. Somlo
2017-04-11 12:43 ` Alexander Graf
2017-04-11 17:10 ` Jim Mattson
2017-04-11 18:23 ` Alexander Graf [this message]
2017-04-12 14:34 ` Jim Mattson
2017-04-12 14:54 ` Alexander Graf
2017-04-12 15:20 ` Jim Mattson
2017-04-12 16:29 ` Michael S. Tsirkin
2017-04-21 10:02 ` Paolo Bonzini
2017-04-21 10:05 ` Alexander Graf
2017-04-21 10:06 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4622E361-52AB-40F2-9915-45C48F0DBCD2@suse.de \
--to=agraf@suse.de \
--cc=corbet@lwn.net \
--cc=gsomlo@gmail.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®