From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3318A3D7D9F for ; Tue, 14 Apr 2026 10:33:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776162843; cv=none; b=eCU1oqPeGB/JvwTknjzt01xAwb7BTyHFu2HVOoZUObQdD43+3Tnj232GixGYF0fP+gwOKmPO9CtdWtyChmKzkMYtzyijNJYa7818UZfj+zadqox7SUAGreJDM8aXzJJKWo4iq89Nb0C67YyVTJPsC3akglRUVzKMtR8HebDppGo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776162843; c=relaxed/simple; bh=6xVop/Vp6aPMRmYhd/BDDjugJx7MJYQ7ilDbOya3PP8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kGiUhWPaYuz97ijDN9yBWeWBqh3wqiS8El9W2O8tSqJobTQA9pS0G+gTGrqGyDVv8+KwnQnRsrkOc+3FlEystnb965Vu0kvQQCKVr3gPibqoXwDZ3dwBF3qUGcE01v065GptxsudB72X3n7A4EJ0E8Z6yz2EWvjPuCkDBdB9uFw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=O5s6uWQ7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cz2Yw2xd; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="O5s6uWQ7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cz2Yw2xd" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63E6SRGB395340 for ; Tue, 14 Apr 2026 10:33:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Dw877TpVaxRflXLBD58PE5cB0SmsbMU2KUvevDBMkuU=; b=O5s6uWQ7H9Rt3a1O QOdLyVN2ZIocXVY9FUdfMmx5g961XMXl1pBHe1dPIC9+mM1KhgPctWyTg4z2xwx4 q55Gy7EDbMxUqD/u1uIZU8sK5bMRcAgzCrd02Z4YnFTqQeZtHis+BFkHoHRxGTAp Zuxw7nGW17W7d+ILneU3Gfcn6uSxMbiEVIw5EwqR3mmj5/yaGdV4qXSSuu4FhXNT XrrcxlECKmfLtgBtZz7Rd7QtKzLlfeMPtobhAWiWD8FyhzBs/s+snq+irKjuPP0c YB3xyxbXXVtGy59vsElhtjgjGpHQiIS/ijL4+Xr7W9eJL5Qb3kxSjAHTtAgIWFtH xZdtYw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dh870tb0w-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 14 Apr 2026 10:33:56 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-50b27636835so10444421cf.3 for ; Tue, 14 Apr 2026 03:33:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776162836; x=1776767636; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Dw877TpVaxRflXLBD58PE5cB0SmsbMU2KUvevDBMkuU=; b=cz2Yw2xdo5vN/WCav8zwcFyvRVX7h9fMcelD6+S5Y4OG33/wBCwJL/F275/4abhmlT 4RXYM75usKqpr/JBQpyM/y7R+iIhk4N7XIwKEb451HEV6Neay/d6rVkNzztwyRSHXd28 IP/I9yY24/orqadhYFfIODcInb3VFG7uEwYQaER3Fa8cA+klxk/g/Ffvz1jETEt3cWCF EhEW/w2zfOL78K27NxV4p21GIEzyDbVPQm6pvpTxZhMMIuMkZUYCDSAn88I30Zn5oQFt xSaOdYdRVu3ByLi5+wpRLTEczb9a2MvB7TBPLrH64aR3qN/KwlhOwD5Fe4iLTsLYqyR5 Lqrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776162836; x=1776767636; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Dw877TpVaxRflXLBD58PE5cB0SmsbMU2KUvevDBMkuU=; b=Kjzz43x3Vx+yWFpJDn7E05Sb5DlUJaKwFkcO8rVouKmh3HNCiBFdWTvFSUF0S4Qnl6 97xgwSW+vNkZ0VwMIrdNS4W0Mo/ywcEfnUU9k69Wkx3l8CG4u3vzkqNtjOs1+9axGCnu JnPEl46jT8YwUoED44slBP9ytB6g5Cfkp0+gI+wLfQLYO1vNjLp4+MrMzuKRpns9OqEa i0iy/ZLS5P8bDBSou7SgWiDMS5BipOC6N18mRS0K3Jj/IPbV0JMX5vu5FGQ762vCeGLh RmJbEYMuNBOcKcgzlIUOAqw1y/NaoWIfYw33VqqiUEQLYf2Zd1Rk+4J70huEGL2rZraH /jgw== X-Forwarded-Encrypted: i=1; AFNElJ9kEPwgv653IqnMazUIwWuxtZbZfr3ZOEO3n/5E6hlWvWs8Eo1wKTZeJqEaL2SL/so7O1ssblwgdnrHSlo=@vger.kernel.org X-Gm-Message-State: AOJu0YxDYrSzlol9Xw9nfn5hnquXMdDr3K1DOpOjcht3wa9Dsx2iUAot txSwahu7PmTAqEF5dskd8LUTB2rKUSVW9Tdfc7qrnNtS0NrJjA5ShF+Cd3zROwEN+49C2II5mkZ XRlrC/3MZGyINtMLb07tlNGpS1m/e8qFT+exnRX7UG1Ok0fV8IjTsR3Wr6lrB36VITGY= X-Gm-Gg: AeBDiev3HH9gnzuRJa3K+EfWjp5FMRVHvJhA7Y6p9DJr3Dh/du5AKElW/r7qEmytq4H IHobE+Hn4DoZvGiMzxtkILSG5P4JWu37WoOumXZB2oyn3j33k4Gx6J825mYCGmQkzRrvmedILyd lTlMmwU2eBqJy4DaEQgEWWOqo9oFQW8WGgFOqD6/UmkbTJFVXOTvJVi9yTdO3tbTjzcbCyUT7Oa hQYueWLa1cdssF4OD7XYdHYhB7lHAcgwsvNh4f4IECK2X+O4ZJyldZ+hahaEOugPG8OQsoZ4SIl VFEb4naJPAQkJYkomKyXuA9etMjfFcJM0vDOGesDU3pMi+caM7gra+ndnvenBuBTqwuDooDe7+o 1/iInVj6S4TeuHWE6SZEaMPhNbt8x0aRHzD7L0hA1pDuOX3dMhd9KQGrP97ubWu3oRKizJVg43Q ibIOB4mF098E+4jg== X-Received: by 2002:a05:620a:178d:b0:8cf:db7b:6229 with SMTP id af79cd13be357-8ddcff969e8mr1534352685a.7.1776162836123; Tue, 14 Apr 2026 03:33:56 -0700 (PDT) X-Received: by 2002:a05:620a:178d:b0:8cf:db7b:6229 with SMTP id af79cd13be357-8ddcff969e8mr1534351385a.7.1776162835709; Tue, 14 Apr 2026 03:33:55 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6718f52c111sm1018232a12.18.2026.04.14.03.33.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Apr 2026 03:33:54 -0700 (PDT) Message-ID: <462eb5f0-e05e-4cc1-8d6a-6b06e105a517@oss.qualcomm.com> Date: Tue, 14 Apr 2026 12:33:50 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 4/7] media: qcom: camss: Add support to populate sub-devices To: Bryan O'Donoghue , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Konrad Dybcio , Vladimir Zapolskiy , Bryan O'Donoghue Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Krzysztof Kozlowski References: <20260326-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v11-0-5b93415be6dd@linaro.org> <20260326-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v11-4-5b93415be6dd@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260326-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v11-4-5b93415be6dd@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: UqqrUl0PLPnoKznvAmga_NPJRyM7Luy9 X-Proofpoint-GUID: UqqrUl0PLPnoKznvAmga_NPJRyM7Luy9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE0MDA5OCBTYWx0ZWRfX6xgJ5cZb0NeZ RRDe5fYEhHbk0tgeQZxCDTbq6Ly+59oPAgK1hlJVUpekPPTE4hK5sEWUFN1ZbESa9bsk94QkV4o i4wNXqtfQJ+anQfSdjMshFir3CKdisVrigV8G3x1PvRjRWS+YCuSMLR3oT55aQlJ1LdmmGnr46V 6uOYiZv6ZbFSpVt06TzI6gcHjwYnp26WsFqW5bfkXu3dlf0fzsst4SMiBYMTt0yAojmEhRnu5P0 HFqXNwoyVlQrPIjTrj8VGtN26jA45NJnPlBaJKdO/Tk3/17zv0i4ty0RBSDpswNglbvWs2tvSEu Tgy1bU7EgBENfyRQLwn5zAnXSNXcFJC90DQ/ao6PlZtXCjenPiF1nNVfABYGzHengmiuBDkBTcu vL2xVZArNGYiCWAbiZfEb6Q3El8IG/wxXzT5aC7qPDOeslN7pJh98amvVGsUmZUSB9TRR9QdWG0 s1XwLF58125BiRjYPwQ== X-Authority-Analysis: v=2.4 cv=MK9QXsZl c=1 sm=1 tr=0 ts=69de1814 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=KKAkSRfTAAAA:8 a=ZL2hiuJarSggSDoTJZYA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-14_02,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 clxscore=1015 suspectscore=0 spamscore=0 bulkscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604140098 On 3/26/26 2:28 AM, Bryan O'Donoghue wrote: > Use devm_of_platform_populate() to populate subs in the tree. > > Signed-off-by: Bryan O'Donoghue > --- > drivers/media/platform/qcom/camss/camss.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c > index 00b87fd9afbd8..66ea057291f6d 100644 > --- a/drivers/media/platform/qcom/camss/camss.c > +++ b/drivers/media/platform/qcom/camss/camss.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -4964,6 +4965,8 @@ static int camss_probe(struct platform_device *pdev) > if (!camss) > return -ENOMEM; > > + devm_of_platform_populate(dev); If you want the camss probe to fail if any of the PHYs' probe fails, check the return value Note that this doesn't necessarily have to be the case and I can see arguments for both approaches Konrad