From: "Jan Beulich" <jbeulich@novell.com>
To: "Haruo Tomita" <haruo.tomita@toshiba.co.jp>
Cc: <prarit@redhat.com>, "lkml" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/2] Fixed typo Intel RNG driver for2.6.21-rc7-mm1
Date: Thu, 26 Apr 2007 08:09:37 +0100 [thread overview]
Message-ID: <46306C51.76E4.0078.0@novell.com> (raw)
In-Reply-To: <BF571719A4041A478005EF3F08EA6DF0043323E0@pcsmail03.pcs.pc.ome.toshiba.co.jp>
>>> "Tomita, Haruo" <haruo.tomita@toshiba.co.jp> 26.04.07 08:56 >>>
>> But why do you remove the printk()?
>
>I think that FWH connected to LPC of ICHx are not only Intel products.
>For example, sst... etc.
>Does rng address differ in except Intel products?
I am not aware of non-Intel FWHs supporting the same RNG interface.
>I think that this driver is targeting Intel FWH.
>Therefore, printk() was removed.
If you're worried about people thinking their box being reported to have no
FWH when it does, then just make the message say so (i.e. add 82802 or
alike).
># Do you think that a "FWH not detected" message is noisy?
No, I think it helps understanding why there's no RNG device in the system.
Jan
next prev parent reply other threads:[~2007-04-26 7:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-26 6:56 Tomita, Haruo
2007-04-26 7:09 ` Jan Beulich [this message]
2007-04-26 7:27 Tomita, Haruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46306C51.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=haruo.tomita@toshiba.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=prarit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome