From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752229AbaEZMtM (ORCPT ); Mon, 26 May 2014 08:49:12 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:64416 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751670AbaEZMtJ (ORCPT ); Mon, 26 May 2014 08:49:09 -0400 From: "Rafael J. Wysocki" To: Lv Zheng Cc: "Rafael J. Wysocki" , Len Brown , Lv Zheng , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH] Tables: Restore old behavor to favor 32-bit FADT addresses. Date: Mon, 26 May 2014 15:06:12 +0200 Message-ID: <4631514.kRXiOV1YTi@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.15.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <6018e562465c35d11cf98f181baedf3b8483e812.1399970899.git.lv.zheng@intel.com> References: <38907770.bupFXhytsS@vostro.rjw.lan> <6018e562465c35d11cf98f181baedf3b8483e812.1399970899.git.lv.zheng@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lv, There was a merge conflict with the new ACPICA material queued up for 3.16 related to this. Can you please have a look at the linux-next branch in my tree and see if the ACPICA material in there is in a good shape? Rafael On Tuesday, May 13, 2014 04:50:30 PM Lv Zheng wrote: > We need to find a smarter way to switch to 64-bit FADT addresses according > to the bug report. This patch reverts Linux to the original behavior. > > Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=74021 > Reported-by: Oswald Buddenhagen > Signed-off-by: Lv Zheng > Tested-by: Oswald Buddenhagen > Cc: # 3.14.x: 0249ed24: ACPICA: Add option to favor 32-bit FADT addresses > --- > include/acpi/acpixf.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/acpi/acpixf.h b/include/acpi/acpixf.h > index 4e3044c..b66b6a8 100644 > --- a/include/acpi/acpixf.h > +++ b/include/acpi/acpixf.h > @@ -190,7 +190,7 @@ ACPI_INIT_GLOBAL(u8, acpi_gbl_do_not_use_xsdt, FALSE); > * some machines have been found to have a corrupted non-zero 64-bit > * address. Default is FALSE, do not favor the 32-bit addresses. > */ > -ACPI_INIT_GLOBAL(u8, acpi_gbl_use32_bit_fadt_addresses, FALSE); > +ACPI_INIT_GLOBAL(u8, acpi_gbl_use32_bit_fadt_addresses, TRUE); > > /* > * Optionally truncate I/O addresses to 16 bits. Provides compatibility > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.