From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA67E29ACC6 for ; Tue, 23 Jun 2026 11:37:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782214624; cv=none; b=d0MQzpos7HA5vMpQosV7i9m6f3A3ovoWAjzUYhrx+Q+6Hbfk76lJS7Zb1GSrjJPSLIUYtrJKnwKhPmYprGGgzs801SnCyjG07UvBTz94zh1NtWXVxoUQK93Xf+u8Eq4C1ESVqhsEsRMO8LI7RN0D1kYgvEornyRvaxUOsF96zSQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782214624; c=relaxed/simple; bh=aTuVaf0nYfYAWfdJkxo7EvxAlbxCaffxQrDNMK/QZvw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=q2BER96Yd9zAaGVqPVj+vf9/N6cL5DALHQGDfScleQs/DXXex5H/E8KPQUnaO5XCTUiskFnsUh6xh2LBObWYQ6dHH9ISS+4tkjPjOSNeEO63HzuVX245QaKD2GlSyKQUbhAlGSohtC0GppRM8kMk5iajDaD42HHnVbe4YSoHvx8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OetdD04s; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fhqI0p0/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OetdD04s"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fhqI0p0/" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65NBZDMh031276 for ; Tue, 23 Jun 2026 11:37:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MXNsvpmExzEXM1J7XKQU25avjaUjuFbYf81y6omDQEg=; b=OetdD04sMT8BXOHl P0ZfY0xGtL2vRhpknWkdpuLX31ixTvC6kpV0E7VQdx0gj/pE8GCrCnomrMVSoU1+ L2bCcW3nQ+aUWuIXihofuZXtk6g13KrVR2/2baRhAnB8pdxL1JML37cHNUuDwsL9 5MVe6YTHbtX2udMawnrW7aZgXiGhpEAyN2hDgmAJLUOFX6tzvK3dZK2DqvRnWAbA ndKWhmmmPYlyDqb7nmieAixUTjlWqAOE0oPFv8GUUkOsTpEFyBJ6bbgzJ1gvoniI XyL5R7akeITlahYsjQv8hfHbBlRRM23j5kPYYklFHNfS/zERxNBB56rvyaxkX1YF GewvCw== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eyqe68jkq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 11:37:01 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51a15cef334so6265821cf.3 for ; Tue, 23 Jun 2026 04:37:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782214621; x=1782819421; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MXNsvpmExzEXM1J7XKQU25avjaUjuFbYf81y6omDQEg=; b=fhqI0p0//S0ptLFS9q3SPgjA90L49YS8l2fOw8jC5j8LgGtMLdMKOAWZ6iT7/yZ4pY KqEbAQdVTqCEiKx5pxur0hNuQn25GetIndI9QLHFyaWNmw7eGbVQPHRlnXEjCTPGew5k 43ktsIg4f06uv/jCEG04lVn8/BWElrFgvGq0Kst9Wuot33QnqUbGP5QhCHAvSKep+bxA qB+ndilPmKj/600u6wbeZTsLU6dIBb+QmGixrROXRYWyqW8KfvJdFtZSJlhd3FRNccwx 3acF8jbosGBQ31sPp7yVY4DYuJWILNuXhWupEfAJ9ulS4euKMbuJY1Vntrf+IxwllmDQ idPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782214621; x=1782819421; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MXNsvpmExzEXM1J7XKQU25avjaUjuFbYf81y6omDQEg=; b=rKae5dD5AGoc6Ryp6nZc1A54M28Sx7nLQXv0ZHSudChCSoWKzukANGWRCHfVGlO4eC 35ygr7z6nQBb1uQkauqYy5uEDOhiFpHOifSEtc57jsOI/koV8KhS68ofFEcytHvof7p6 43Ww+Gx2q4oNDduv8b0qR/vXzpNHOYCpLlBP2iWt/LeIQYEQtFRxgPyGPVVYDrj0OR+n /Y8rJ1wP8z56AC1E5JR3hTXpSuwlr1n7WTXwpFQ6/wC2bsXlC4eensY+PE5jAMXC+qoE YeDvtNQjAB7QJIbhfvZPG/KmRzlvktRdBE4nbp36sEY6AH48aIDkrWPDh1FWreQJ9YNn jgug== X-Forwarded-Encrypted: i=1; AFNElJ9MBewWRrCPKIQt8GZwSe4RBBt35HVBdbb3maXxIdilgztV28L0PEE4gRh5gfb8U8Sh7JE8EIDvFqfZdTo=@vger.kernel.org X-Gm-Message-State: AOJu0YxCVxkQanmfAKGl9HR6dTa8rkqmOjcDQRzGsrXWWRifvDTUM5PX u/gKzJWCNRDzjDtoFrozWd92A4rTI2nQ0uZn1CCuPO5HZ3UIJirEoOg/0W6pgS5YKbv7FNe37Og 8avaDLb0KGWiHz6OZpaCM/K/vrvq7AuWbFcmajSvBiQ843OFySsK0XTnEjuBeUJ0Nfb0= X-Gm-Gg: AfdE7cl3ApN2xAFfOPtgM24IXWnospen1sXK8H69KDxm+HDva4LQneCnGkTp6eBipIs IWs59R6lWs8dQGIQiNadLGpeE8quEgu6K64yCXAY1DqGOwhRr7DCn8iGJSoFWZGUsEtC5LThwWD /V8c544NWygkyVuzP81mks92EMPyhmyXIyOrhKPZRezH8UYjGgP+DukKTf/HCBun+9ZjAUHkPcr AE6lKbYa+b4nspv881oh13JozkggrZsa8NoSOqXK6GAb+8RJ9gvTfTG9CdFyvTfK1HXm6tSDOuE zC8e+VzqFJHS+fIz7rN+zAvRh3qBb89yzKPjSSG0Cl3xE0EHRtqskxYfAm5pq+b2xMwHEmRDJ77 7i/tB2y94SmGMnYVBBgngJsy0IY9ahzlvtE8= X-Received: by 2002:ac8:7d49:0:b0:517:5e32:f3ac with SMTP id d75a77b69052e-51a4f380d0dmr47487381cf.0.1782214620880; Tue, 23 Jun 2026 04:37:00 -0700 (PDT) X-Received: by 2002:ac8:7d49:0:b0:517:5e32:f3ac with SMTP id d75a77b69052e-51a4f380d0dmr47486981cf.0.1782214620409; Tue, 23 Jun 2026 04:37:00 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6977be498e4sm4536670a12.20.2026.06.23.04.36.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2026 04:36:58 -0700 (PDT) Message-ID: <4635a665-f605-4647-810d-c9d83a271a86@oss.qualcomm.com> Date: Tue, 23 Jun 2026 13:36:55 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/8] phy: qcom: qmp-combo: Correct pre-emphasis table for QMP v4 DP PHYs To: esteuwu@proton.me, Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Rob Clark , Will Deacon , Robin Murphy , "Joerg Roedel (AMD)" , Vinod Koul , Neil Armstrong , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org References: <20260622-sm8450-qol-v1-0-37e2ee8df9da@proton.me> <20260622-sm8450-qol-v1-7-37e2ee8df9da@proton.me> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260622-sm8450-qol-v1-7-37e2ee8df9da@proton.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: Hkl33EnpNqPbfvtdAPrDMOdoXLd4IFTH X-Proofpoint-ORIG-GUID: Hkl33EnpNqPbfvtdAPrDMOdoXLd4IFTH X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDA5NCBTYWx0ZWRfX6ys7DggHzUwQ xzNT20Wfj5g1g0dgsjVTzEKxryAv7iflBcuOmz6ImpgX8rnFT9MnAUy8Bnwg/flpI78UUM1s6VT KyNOnW2AjP87NiG1l5wY1MENvm+glVA= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDA5NCBTYWx0ZWRfX7jBuzakOxV/K QS/sC1XXNGODU1cfyyiAPGoSjDzXU1xwX2iQndTDa7bTGy+CdRZX+KYTxFph7RilpanKn+fc9wv SckS8FXCHLiS/CGuNGlKFnP+HWKnC9rr358c8GR7Tm3wINZrdimLVzszwvT++8z5gEp6uo8XqIv 6ZB6al+YB7kV5BBwE1d+YK+vhw27QPpi32b+1uK7A7DkKfRsyAVpCex+h6ce8/s1bQUC3rEdzmM EeITkz3hIS1dPJym6Ta+CmkXhfu8Rb9I6+qyl4xhhYIxiLns9kkmZIlwU/mMEL8Lb/K9Q0gZ5dS jIAB4ZIxW7iwHHrEdgCROcJ71fqVHVV3q2QCVt/cnXV7m+dGVKn9346rhDy6Uiugt268Xjvhnzh brdohrQZsk4b4ILh8SFTBOhtQ6g5le0F6eJ/FI6DKmSn4DHDYjsCkK2r7+XM5ETYifd3eYXckyK zt2nbEt+X6R8+L9TwGg== X-Authority-Analysis: v=2.4 cv=OeKoyBTY c=1 sm=1 tr=0 ts=6a3a6fdd cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=N-WSo6sfiX0bQk_JYPcA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_03,2026-06-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 spamscore=0 malwarescore=0 adultscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230094 On 6/23/26 2:54 AM, Esteban Urrutia via B4 Relay wrote: > From: Esteban Urrutia > > Comparing sm8350 and sm8450 tables, this seems to be typo. > > Signed-off-by: Esteban Urrutia > --- > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > index 9bd666ac2c49..5b278fd54a16 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > @@ -2108,7 +2108,7 @@ static const u8 qmp_dp_v4_pre_emphasis_hbr3_hbr2[4][4] = { > static const u8 qmp_dp_v4_pre_emphasis_hbr_rbr[4][4] = { > { 0x00, 0x0d, 0x14, 0x1a }, > { 0x00, 0x0e, 0x15, 0xff }, > - { 0x00, 0x0d, 0xff, 0xff }, > + { 0x00, 0x0e, 0xff, 0xff }, > { 0x03, 0xff, 0xff, 0xff } It seems like 8350/8450 should be using what this driver calls v5 tables, with this fixup: diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c index cdcfad2e86b1..63a4f2127e3c 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c @@ -2134,7 +2134,7 @@ static const u8 qmp_dp_v5_voltage_swing_hbr3_hbr2[4][4] = { }; static const u8 qmp_dp_v5_pre_emphasis_hbr_rbr[4][4] = { - { 0x20, 0x2d, 0x34, 0x3a }, + { 0x20, 0x2e, 0x35, 0x3b }, { 0x20, 0x2e, 0x35, 0xff }, { 0x20, 0x2e, 0xff, 0xff }, { 0x24, 0xff, 0xff, 0xff } +Dmitry please confirm Konrad