From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752766AbdHGJYF (ORCPT ); Mon, 7 Aug 2017 05:24:05 -0400 Received: from mout.web.de ([212.227.15.4]:54885 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752367AbdHGJYE (ORCPT ); Mon, 7 Aug 2017 05:24:04 -0400 To: Tim Waugh , kernel-janitors@vger.kernel.org Cc: LKML From: SF Markus Elfring Subject: [PATCH] paride: Delete an error message for a failed memory allocation in two functions Message-ID: <46377d4f-aaab-a91f-9f39-f67ea98ba8ed@users.sourceforge.net> Date: Mon, 7 Aug 2017 11:23:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:K5fF8/RdU9+Lgy9rOAsPuA7xTxLK/BbclTf0P+BAmhoKnOWgk83 0Br4HKjL5Yh2LQvOU9Rfo2FkTJdu3h7K7QNvGx6Rx+8y5k6t0e2LkHHyNWVtXKTf4T9LoCh W4RCsZxn8PC0AITpU1udPlvWTvQi1gzTYpBLrbXpSREiui+KdE2XulIRObGSVQXt7R/dMoF IzyyUxTQBJjYusb1kHyHA== X-UI-Out-Filterresults: notjunk:1;V01:K0:ropyGzp/9mY=:I+xXpEfaam5i7ELuPYB5uE rqYx3zCvOm3n8RohI4i5RmjRhqQeNYQf40TWNE84kgAdndAv+D/bhf7GMs32XZb6Clc0CCcV8 pK2uffrRfkVHLtAdr4bgeR4H4AujPguIEXG9xY88axhblOJmV9BAM+qiDHCBbf0eZFG6CmXWo dKGzxlwj5jX7zqLCJaQrkz3YDrqxIy/2cv0DQ6qgMRTEaGGG131/3/74jJXIkWTGpExNQFgMI y38xAv8cpU41n8AtomGinLFjqskI5jop//5BMzZeEPAFGIkDCSrl38b5U+hLrQdS/DSw5NDOL uqSqKBT3gzrXa9JlM3MNjkiezIffH0e4tmBhON4HbRahZ+B8jY6zTkQkk118ctBzod2igZZrg Tx1cCBVEKHITHkzKH9WuRrHh6L2Yu45UGTtfBgVupfwB5dSp3F+FrAkB4XFPBdMbdgtKg3Xsg fNHlV+E/noROvEY6uN6nf9QJQB93iQqtkRr/s9uma1s+nK8VJBslE5W+yip6Ko4wTPPz/vw2k oV1eohboa9CDkXMM4PbD/DpD666Aee8BpJlVvavdhAMytmtpaU7dhouPkq3IvYFkVECMDEsF4 i+hPXnzvJIRjh5sHSU/XT1IqC2oxw3X7rlvqDr4xPnu2tuzXl4DfNcBFaD9us7zCAS110igER uDiGi7utwoytA7/IeQdcp7D3949h4Kioay5hdemCwuq0lRNt6jpambMYaSFXyJbeOVY7BQ5uG e64Ut2oomUYnQOSy9RSkTfQE0YeBR/vigMr2P6UPSJfJcEZuzJs1JLWYn0Nr6c+88JHCyAciC vLLqujOB7K9cu+Rn8iF5FKcUHbBDPUiwWuWh+NxSx9GLvpelrE= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 7 Aug 2017 11:11:34 +0200 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/block/paride/pg.c | 1 - drivers/block/paride/pt.c | 4 +--- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/block/paride/pg.c b/drivers/block/paride/pg.c index 3b5882bfb736..9b036c79c49e 100644 --- a/drivers/block/paride/pg.c +++ b/drivers/block/paride/pg.c @@ -550,7 +550,6 @@ static int pg_open(struct inode *inode, struct file *file) dev->bufptr = kmalloc(PG_MAX_DATA, GFP_KERNEL); if (dev->bufptr == NULL) { clear_bit(0, &dev->access); - printk("%s: buffer allocation failed\n", dev->name); ret = -ENOMEM; goto out; } diff --git a/drivers/block/paride/pt.c b/drivers/block/paride/pt.c index e815312a00ad..33347853b7d4 100644 --- a/drivers/block/paride/pt.c +++ b/drivers/block/paride/pt.c @@ -687,10 +687,8 @@ static int pt_open(struct inode *inode, struct file *file) err = -ENOMEM; tape->bufptr = kmalloc(PT_BUFSIZE, GFP_KERNEL); - if (tape->bufptr == NULL) { - printk("%s: buffer allocation failed\n", tape->name); + if (!tape->bufptr) goto out; - } file->private_data = tape; mutex_unlock(&pt_mutex); -- 2.13.4