From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Pierre Ossman <drzeus-list@drzeus.cx>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] MMC updates
Date: Wed, 09 May 2007 18:05:11 +1000 [thread overview]
Message-ID: <464180B7.2090703@yahoo.com.au> (raw)
In-Reply-To: <46417D97.9090108@drzeus.cx>
Pierre Ossman wrote:
> Nick Piggin wrote:
>
>>If you want to ensure you always only modify host->removed from under
>>the spinlock, it would be enforcable by introducing an accessor function
>>and doing a BUG_ON(!spin_is_locked()) in there.
>>
>>If you just want to ensure that host->removed is 0 at this point, you
>>shouldn't need any spinlocks AFAIKS... that way you can probably afford
>>to move it out from CONFIG_MMC_DEBUG and get wider testing.
>>
>
>
> The host->removed member is only used for this simple test. It is set in
> mmc_host_remove() to indicate that the removal process has begun. At
> this point it is invalid to call mmc_detect_change() (the place this
> patch fixes). So the spinlocks are mostly there so that things are
> properly ordered when we go SMP. Some creative barriers would probably
> work as well, but I find spinlocks more "normal" and hence more readable.
Fair enough. No big deal :)
--
SUSE Labs, Novell Inc.
next prev parent reply other threads:[~2007-05-09 8:06 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-08 20:45 Pierre Ossman
2007-05-09 5:55 ` Pierre Ossman
2007-05-09 6:03 ` Nick Piggin
2007-05-09 6:27 ` Pierre Ossman
2007-05-09 6:35 ` Nick Piggin
2007-05-09 7:51 ` Pierre Ossman
2007-05-09 8:05 ` Nick Piggin [this message]
2007-05-09 9:11 ` Stefan Richter
2007-05-09 15:44 ` Pierre Ossman
-- strict thread matches above, loose matches on Subject: below --
2008-04-19 7:28 Pierre Ossman
2008-02-09 9:50 Pierre Ossman
2007-12-12 19:12 Pierre Ossman
2007-12-18 7:57 ` Pierre Ossman
2007-11-21 17:56 Pierre Ossman
2007-10-17 20:44 Pierre Ossman
2007-10-17 20:48 ` Dan Williams
2007-10-10 19:21 Pierre Ossman
2007-10-12 5:30 ` Linus Torvalds
2007-10-12 5:45 ` Pierre Ossman
2007-10-12 12:18 ` Kay Sievers
2007-10-12 13:53 ` Pierre Ossman
2007-10-12 19:55 ` Pierre Ossman
2007-10-12 20:05 ` Nicolas Pitre
2007-10-12 20:35 ` Pierre Ossman
2007-10-12 21:00 ` Pierre Ossman
2007-10-13 5:29 ` Randy Dunlap
2007-10-13 7:03 ` Pierre Ossman
2007-09-11 15:26 Pierre Ossman
2007-08-23 5:18 Pierre Ossman
2007-08-09 14:34 Pierre Ossman
2007-07-26 13:15 Pierre Ossman
2007-07-21 0:36 Pierre Ossman
2007-07-10 20:43 Pierre Ossman
2007-06-13 17:24 Pierre Ossman
2007-06-08 8:09 Pierre Ossman
2007-05-24 5:46 Pierre Ossman
2007-05-14 16:55 Pierre Ossman
2007-05-01 15:22 Pierre Ossman
2007-05-05 4:24 ` Pierre Ossman
2007-05-05 4:45 ` Linus Torvalds
2007-05-09 18:56 ` Russell King
2007-05-09 19:06 ` Pierre Ossman
2007-05-09 22:12 ` Russell King
2007-05-10 5:44 ` Pierre Ossman
2007-05-10 7:51 ` Russell King
2007-05-10 13:58 ` Pierre Ossman
2007-05-10 14:52 ` Nicolas Pitre
2007-05-12 15:38 ` Nicolas Pitre
2007-05-12 16:12 ` Pierre Ossman
2007-05-12 16:22 ` Russell King
2007-05-12 17:55 ` Nicolas Pitre
2007-02-11 15:33 Pierre Ossman
2007-02-04 20:11 Pierre Ossman
2007-01-15 5:46 Pierre Ossman
2007-01-04 12:49 Pierre Ossman
2007-01-10 19:51 ` Pierre Ossman
2006-12-11 11:45 Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464180B7.2090703@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=drzeus-list@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome