From: Alexander Amelkin <alexander@amelkin.msk.ru>
To: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: [PATCH 3/3] usb: max3421-hcd: Remove function name from dev_dbg calls
Date: Fri, 26 May 2017 14:32:42 +0300 [thread overview]
Message-ID: <4642fe87795c3ec475f7c5ba6e67d025@amelkin.msk.ru> (raw)
In-Reply-To: <fe4f9b0f3a18d48dec6c0a8d79cae386@amelkin.msk.ru>
[-- Attachment #1: Type: text/plain, Size: 2865 bytes --]
NOTE:
Please don't use the plain text here as a patch because it most probably
is corrupted by my webmail client.
Attached is a copy of the following text guaranteed to have correct
tabs/spaces.
-------------------------
From b9a7559d24c0b2cb6e69124d861a943f79272681 Mon Sep 17 00:00:00 2001
From: Alexander Amelkin <amelkin@fastwel.ru>
Date: Fri, 14 Apr 2017 18:01:58 +0300
Subject: [PATCH 3/3] usb: max3421-hcd: Remove function name from dev_dbg
calls
The kernel dynamic debugging facility already has a
means for displaying the function name if the developer
wants to (the 'f' flag).
There is no need to hard-code output of the function
name into dev_dbg calls.
Signed-off-by: Alexander Amelkin <alexander@amelkin.msk.ru>
---
drivers/usb/host/max3421-hcd.c | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/host/max3421-hcd.c
b/drivers/usb/host/max3421-hcd.c
index bd59c16..cfca8a2 100644
--- a/drivers/usb/host/max3421-hcd.c
+++ b/drivers/usb/host/max3421-hcd.c
@@ -706,8 +706,8 @@ max3421_select_and_start_urb(struct usb_hcd *hcd)
urb = list_first_entry(&ep->urb_list, struct urb,
urb_list);
if (urb->unlinked) {
- dev_dbg(&spi->dev, "%s: URB %p unlinked=%d",
- __func__, urb, urb->unlinked);
+ dev_dbg(&spi->dev, "URB %p unlinked=%d",
+ urb, urb->unlinked);
max3421_hcd->curr_urb = urb;
max3421_hcd->urb_done = 1;
spin_unlock_irqrestore(&max3421_hcd->lock,
@@ -815,8 +815,8 @@ max3421_check_unlink(struct usb_hcd *hcd)
list_for_each_entry_safe(urb, next, &ep->urb_list, urb_list) {
if (urb->unlinked) {
retval = 1;
- dev_dbg(&spi->dev, "%s: URB %p unlinked=%d",
- __func__, urb, urb->unlinked);
+ dev_dbg(&spi->dev, "URB %p unlinked=%d",
+ urb, urb->unlinked);
usb_hcd_unlink_urb_from_ep(hcd, urb);
spin_unlock_irqrestore(&max3421_hcd->lock,
flags);
@@ -912,8 +912,8 @@ max3421_handle_error(struct usb_hcd *hcd, u8 hrsl)
* from; report error
*/
max3421_hcd->urb_done = hrsl_to_error[result_code];
- dev_dbg(&spi->dev, "%s: unexpected error HRSL=0x%02x",
- __func__, hrsl);
+ dev_dbg(&spi->dev, "unexpected error HRSL=0x%02x",
+ hrsl);
break;
case MAX3421_HRSL_TOGERR:
@@ -940,14 +940,12 @@ max3421_handle_error(struct usb_hcd *hcd, u8 hrsl)
else {
/* Based on ohci.h cc_to_err[]: */
max3421_hcd->urb_done = hrsl_to_error[result_code];
- dev_dbg(&spi->dev, "%s: unexpected error HRSL=0x%02x",
- __func__, hrsl);
+ dev_dbg(&spi->dev, "unexpected error HRSL=0x%02x", hrsl);
}
break;
case MAX3421_HRSL_STALL:
- dev_dbg(&spi->dev, "%s: unexpected error HRSL=0x%02x",
- __func__, hrsl);
+ dev_dbg(&spi->dev, "unexpected error HRSL=0x%02x", hrsl);
max3421_hcd->urb_done = hrsl_to_error[result_code];
break;
--
2.7.4
[-- Attachment #2: 0003-usb-max3421-hcd-Remove-function-name-from-dev_dbg-ca.patch --]
[-- Type: text/x-diff, Size: 2614 bytes --]
From b9a7559d24c0b2cb6e69124d861a943f79272681 Mon Sep 17 00:00:00 2001
From: Alexander Amelkin <amelkin@fastwel.ru>
Date: Fri, 14 Apr 2017 18:01:58 +0300
Subject: [PATCH 3/3] usb: max3421-hcd: Remove function name from dev_dbg calls
The kernel dynamic debugging facility already has a
means for displaying the function name if the developer
wants to (the 'f' flag).
There is no need to hard-code output of the function
name into dev_dbg calls.
Signed-off-by: Alexander Amelkin <alexander@amelkin.msk.ru>
---
drivers/usb/host/max3421-hcd.c | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/drivers/usb/host/max3421-hcd.c b/drivers/usb/host/max3421-hcd.c
index bd59c16..cfca8a2 100644
--- a/drivers/usb/host/max3421-hcd.c
+++ b/drivers/usb/host/max3421-hcd.c
@@ -706,8 +706,8 @@ max3421_select_and_start_urb(struct usb_hcd *hcd)
urb = list_first_entry(&ep->urb_list, struct urb,
urb_list);
if (urb->unlinked) {
- dev_dbg(&spi->dev, "%s: URB %p unlinked=%d",
- __func__, urb, urb->unlinked);
+ dev_dbg(&spi->dev, "URB %p unlinked=%d",
+ urb, urb->unlinked);
max3421_hcd->curr_urb = urb;
max3421_hcd->urb_done = 1;
spin_unlock_irqrestore(&max3421_hcd->lock,
@@ -815,8 +815,8 @@ max3421_check_unlink(struct usb_hcd *hcd)
list_for_each_entry_safe(urb, next, &ep->urb_list, urb_list) {
if (urb->unlinked) {
retval = 1;
- dev_dbg(&spi->dev, "%s: URB %p unlinked=%d",
- __func__, urb, urb->unlinked);
+ dev_dbg(&spi->dev, "URB %p unlinked=%d",
+ urb, urb->unlinked);
usb_hcd_unlink_urb_from_ep(hcd, urb);
spin_unlock_irqrestore(&max3421_hcd->lock,
flags);
@@ -912,8 +912,8 @@ max3421_handle_error(struct usb_hcd *hcd, u8 hrsl)
* from; report error
*/
max3421_hcd->urb_done = hrsl_to_error[result_code];
- dev_dbg(&spi->dev, "%s: unexpected error HRSL=0x%02x",
- __func__, hrsl);
+ dev_dbg(&spi->dev, "unexpected error HRSL=0x%02x",
+ hrsl);
break;
case MAX3421_HRSL_TOGERR:
@@ -940,14 +940,12 @@ max3421_handle_error(struct usb_hcd *hcd, u8 hrsl)
else {
/* Based on ohci.h cc_to_err[]: */
max3421_hcd->urb_done = hrsl_to_error[result_code];
- dev_dbg(&spi->dev, "%s: unexpected error HRSL=0x%02x",
- __func__, hrsl);
+ dev_dbg(&spi->dev, "unexpected error HRSL=0x%02x", hrsl);
}
break;
case MAX3421_HRSL_STALL:
- dev_dbg(&spi->dev, "%s: unexpected error HRSL=0x%02x",
- __func__, hrsl);
+ dev_dbg(&spi->dev, "unexpected error HRSL=0x%02x", hrsl);
max3421_hcd->urb_done = hrsl_to_error[result_code];
break;
--
2.7.4
next prev parent reply other threads:[~2017-05-26 11:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 11:22 [GIT][PULL] Improvements to max3421-hcd driver Alexander Amelkin
2017-05-26 11:28 ` [PATCH 1/3] usb: max3421-hcd: Add devicetree support to the driver Alexander Amelkin
2017-05-31 19:03 ` Rob Herring
2017-05-26 11:30 ` [PATCH 2/3] usb: max3421-hcd: Fix crash on the driver removal Alexander Amelkin
2017-05-26 11:32 ` Alexander Amelkin [this message]
2017-05-26 18:41 ` [PATCH 3/3] usb: max3421-hcd: Remove function name from dev_dbg calls Greg Kroah-Hartman
2017-05-26 18:40 ` [GIT][PULL] Improvements to max3421-hcd driver Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4642fe87795c3ec475f7c5ba6e67d025@amelkin.msk.ru \
--to=alexander@amelkin.msk.ru \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®