From: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Chester Lin <chester62515@gmail.com>,
Matthias Brugger <mbrugger@suse.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
NXP S32 Linux Team <s32@nxp.com>
Subject: Re: [PATCH v2 2/4] dt-bindings: gpio: add support for NXP S32G2/S32G3 SoCs
Date: Mon, 16 Sep 2024 09:01:11 +0300 [thread overview]
Message-ID: <464742a3-2aae-4980-ad33-28142d98abd4@oss.nxp.com> (raw)
In-Reply-To: <20240913141348.GA3927538-robh@kernel.org>
Hi Rob,
Thank you very much for the review!
>> +
>> + gpio-ranges:
>> + minItems: 2
>
> This gets expanded to 'maxItems: 2'. Is that what you want? If not,
> maxItems should be explicit.
Yes, 'maxItems: 2' is what I want but I can also add 'maxItems: 2' in v3 to be
explicit/more clear about it.
>> + - |
>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>> + #include <dt-bindings/interrupt-controller/irq.h>
>> +
>> + gpio: siul2-gpio@4009d700 {
>
> gpio@...
>
> Drop unused label.
I will fix in v3.
Best regards,
Andrei
next prev parent reply other threads:[~2024-09-16 6:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 8:29 [PATCH v2 0/4] gpio: siul2-s32g2: add initial GPIO driver Andrei Stefanescu
2024-09-13 8:29 ` [PATCH v2 1/4] drivers: provide devm_platform_get_and_ioremap_resource_byname() Andrei Stefanescu
2024-09-18 7:52 ` Matthias Brugger
2024-09-13 8:29 ` [PATCH v2 2/4] dt-bindings: gpio: add support for NXP S32G2/S32G3 SoCs Andrei Stefanescu
2024-09-13 9:35 ` Rob Herring (Arm)
2024-09-13 9:55 ` Andrei Stefanescu
2024-09-13 14:13 ` Rob Herring
2024-09-16 6:01 ` Andrei Stefanescu [this message]
2024-09-13 8:29 ` [PATCH v2 3/4] gpio: siul2-s32g2: add NXP S32G2/S32G3 SoCs support Andrei Stefanescu
2024-09-14 16:40 ` Markus Elfring
2024-09-16 8:14 ` Andrei Stefanescu
2024-09-13 8:29 ` [PATCH v2 4/4] MAINTAINERS: add MAINTAINER for S32G2 SIUL2 GPIO driver Andrei Stefanescu
2024-09-13 11:05 ` Greg Kroah-Hartman
2024-09-13 12:33 ` Andrei Stefanescu
2024-09-17 17:44 ` Krzysztof Kozlowski
2024-09-18 7:57 ` Andrei Stefanescu
2024-09-18 8:13 ` Krzysztof Kozlowski
2024-09-18 9:01 ` Andrei Stefanescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464742a3-2aae-4980-ad33-28142d98abd4@oss.nxp.com \
--to=andrei.stefanescu@oss.nxp.com \
--cc=brgl@bgdev.pl \
--cc=chester62515@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbrugger@suse.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=s32@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®