mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zoltan Boszormenyi <zboszor@dunaweb.hu>
To: Peer Chen <pchen@nvidia.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] drivers/ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61
Date: Thu, 17 May 2007 23:02:17 +0200	[thread overview]
Message-ID: <464CC2D9.5060409@dunaweb.hu> (raw)

Hi,

thanks for publishing this.

> Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA
> controller.
>
> This patch base on sata_nv.c file from kernel 2.6.22-rc1
>
> See attachment for the patch.
>
> Signed-off-by: Kuan Luo <kluo@nvidia.com>
> Signed-off-by: Peer Chen <pchen@nvidia.com>
> ==================================
> See attached file.
> ==================================
>   

However, I saw this in the patch:

+               /* determine if physical DMA addr spans 64K boundary.
+                * Note h/w doesn't support 64-bit, so we unconditionally
+                * truncate dma_addr_t to u32.
+                */
+               addr = (u32) sg_dma_address(sg);

Does it mean that I can't upgrade my machine to 4 GB or more
without losing NCQ or risking data corruption?
Can the code be made IOMMU-aware?

Best regards,
Zoltán Böszörményi


             reply	other threads:[~2007-05-17 21:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-17 21:02 Zoltan Boszormenyi [this message]
     [not found] <fa.NGBsZzMiMJ9x7V/pv+sqAv36hwA@ifi.uio.no>
2007-05-18 23:31 ` Robert Hancock
  -- strict thread matches above, loose matches on Subject: below --
2007-05-18 11:10 Kuan Luo
     [not found] <fa.iernIz8Xcuvw0SBwi4A99Ju0g2o@ifi.uio.no>
2007-05-18  1:58 ` Robert Hancock
2007-05-18 12:34   ` Alan Cox
2007-05-18 14:34     ` Jeff Garzik
2007-05-18 15:12       ` Alan Cox
2007-05-20  8:34       ` Zoltan Boszormenyi
2007-05-15  6:22 [PATCH] drivers/ata: correct a wrong free function for sata_nv driver Peer Chen
2007-05-16  5:21 ` Jeff Garzik
2007-05-17 10:15   ` [PATCH] drivers/ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61 Peer Chen
2007-05-17 20:12     ` Andrew Morton
2007-05-17 20:17       ` Andrew Morton
2007-05-17 21:11         ` Jan Engelhardt
2007-05-18  1:47     ` Robert Hancock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=464CC2D9.5060409@dunaweb.hu \
    --to=zboszor@dunaweb.hu \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pchen@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome