From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752780AbbKQJCS (ORCPT <rfc822;w@1wt.eu>);
	Tue, 17 Nov 2015 04:02:18 -0500
Received: from mout.kundenserver.de ([212.227.126.130]:53451 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751363AbbKQJCO (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 17 Nov 2015 04:02:14 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org,
        Viresh Kumar <viresh.kumar@linaro.org>, linux-kernel@vger.kernel.org,
        Kukjin Kim <kgene@kernel.org>
Subject: Re: [PATCH] cpufreq: do not mark s3c2410_plls_add as __init
Date: Tue, 17 Nov 2015 10:01:36 +0100
Message-ID: <4654010.UfKTsDKyes@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <564A899C.4040402@samsung.com>
References: <8497197.sYxqVOch7s@wuerfel> <4389196.cuM78vZZnJ@wuerfel> <564A899C.4040402@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:D/IWOfs3ztXAp+vc/EYq/T16MgGE7M+IFGBHdkJ4rYvU0bhbaGk
 CHG4TXzZSXRNI5i+gCAzVcFQScHaqqwKdj0idBTQg+gqq6XeAHA++mOTMA3Ov2yeRJOWyaH
 6kug2XL28R3JbewGAH+FwdxL5EQFV0AUa7XESOziArHYBSDsz8Y5lQln6ztcCttNyMbtEK3
 96A2ebbi+gox11jK3T5cQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:+os7j422DPc=:vGWMcsTa9zbX9HLMO2iUMw
 PhwJPXQWTaK7lgVyNNdJqCUAVTceT7SaO+ijqjJsv4d0VuaWXrynU0vTuCkpRaITdb8XO2hzM
 p1abY21sjffovmtGwErU1ckB1rvgQhmH/Ut0cA7jlFI0fUuPnb4fzsWoQCxqEUGtE7WDynZYr
 BO/jMs4y2P4TRKTv7OO0k0J2T3NgUPXMcLKjlfpw7agbWgb3b4rQj8DvoOioSobXSBjyQgFIH
 5TALKS5z8Ar5IJ1GCftvXg5KUCbRntQYpt2YFCs5nuHNJ2N421CFRPvUXsTa/5hQWRiTeAFO9
 N8n03Y1qPMLCKnFo92AhrYxQyPxbym3DqQ2NHap24tStdO7vKEcHgqz2UuZkXSxY2n5lhJZFO
 hujAzCPRaPeIlX1WX4yEper4akbfQMoTmeXuEbR7M0jswqPhcd7vTn6bJAdyscaaWuV3EHn4K
 Jw0cAqKN6h2Q7wKc/hMZrt5SeKHvfEBNWeAsJ7AlO1QOe6AFz95BqSzb9LkQq8Hk59bjLtGpl
 33NOR5Td0qjLD7LZNoWJqgwwjEwEMvMAIkhIe+eop94lhm0M1FxJ/hR4tmWh+aAwDIjr8g/Bx
 wrxxCbYoLEebKD14qJhXWtNkeKKqEXiPhCM3y84Eauv9uOY276aVQng+wHBVO56JSI/vpAzZz
 7Z7awD1HTjmNcMNkSRFBmuxYLGdSjQL7UdLYn4tDA3hbxCZ0cAucU1LBVNwPf5N1+zkd3IYau
 v8A9YN2JLTIoZASP
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday 17 November 2015 10:57:48 Krzysztof Kozlowski wrote:
> On 17.11.2015 07:17, Arnd Bergmann wrote:
> > On Monday 16 November 2015 23:36:42 Rafael J. Wysocki wrote:
> >>
> >> This should go in through the Samsung tree, so I'll leave it for them to pick
> >> it up (at least for the time being).
> > 
> > Ok, fair enough. Kukjin or Krzysztof, can you pick this up?
> 
> Sure.
> 
> As for the patch I think everything can be converted to init/initdata
> (as in attachment).
> 

I don't think so:

static struct subsys_interface s3c2442_plls169344_interface __initdata = {
        .name           = "s3c2442_plls169344",
        .subsys         = &s3c2442_subsys,
        .add_dev        = s3c2440_plls169344_add,
};

This gets passed into subsys_interface_register(), which is not __init
in turn. subsys_interface_register() then goes on to add
s3c2442_plls169344_interface into a linked list that is traversed
at runtime, but the __initdata section gets discarded so you now
have a broken list.

	Arnd