From: "Indan Zupancic" <indan@nul.nu>
To: tglx@linutronix.de, johnstul@us.ibm.com, linux-kernel@vger.kernel.org
Subject: [2.6.21] BUG: clocksource_watchdog isn't reset after resume
Date: Sun, 29 Apr 2007 18:20:12 +0200 (CEST) [thread overview]
Message-ID: <4655.81.207.0.53.1177863612.squirrel@secure.samage.net> (raw)
Hello,
After s2ram, basically the following happens, which shouldn't happen:
[ 0.880234] Clocksource tsc unstable (delta = 449782067799 ns)
[ 0.881221] Time: pit clocksource has been installed.
Looking at the source, it seems that clocksource_watchdog isn't reset
after resume, while the clock source used is, and hence it thinks that
the clock is unstable.
So it appears that timekeeping_resume and/or timekeeping_suspend should
do something to prevent this from happening.
Maybe by somehow updating 'watchdog_last' after resume, but it's unclear
how that should happen, as the watchdog doesn't export any functions and
the only thing that's reachable which calls anything watchdog related is
clocksource_register().
This is a UP machine with no frequency changing CPU, so the tsc is good
to use (before someone complaints that I should use the pm timer).
An alternative would be to not select CONFIG_CLOCKSOURCE_WATCHDOG, but
it's unclear how or by what that's selected.
Greetings,
Indan
next reply other threads:[~2007-04-29 16:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-29 16:20 Indan Zupancic [this message]
2007-04-29 19:25 ` Thomas Gleixner
2007-04-29 22:54 ` Indan Zupancic
2007-04-30 0:06 ` Indan Zupancic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4655.81.207.0.53.1177863612.squirrel@secure.samage.net \
--to=indan@nul.nu \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®