From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D1CF24B2B for ; Thu, 4 Jan 2024 16:08:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=joelfernandes.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=joelfernandes.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=joelfernandes.org header.i=@joelfernandes.org header.b="rf5OGYTe" Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-67f9f6ca479so2958886d6.3 for ; Thu, 04 Jan 2024 08:08:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1704384513; x=1704989313; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qWoFUFj8y9tncvSzwG/Qj6RhTu2GZ8uSYsNg8VQb2Kc=; b=rf5OGYTeSJdNW6OobyVZj4/pPDGU4TL09L1eyQhWb9dyYQRkPa4sAnZ7G2a4SQehNn h9AfDpu5+sms0OnAojgJk0pOurYKi/ROGLYzDwwVOcZrsyYkD+1CqB9kCwE8EgNcvY/r uiQaPv0yyXUHY12Bbuvg6YKx8+d6jWFo78bmo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704384513; x=1704989313; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qWoFUFj8y9tncvSzwG/Qj6RhTu2GZ8uSYsNg8VQb2Kc=; b=uSo88MgwewgHPQi1P3C72Y6hhI7TqbXcX+r0JP8zpOYWcUJtCebd9Bq8xlomA0I+Ak zmZ4DQWllvHTf7IfrurLQO5EeMVruzCphL+I2tov+B7Lg/nTHw7woA78Ps9UmHxcUUUg 0gsniya+8m0FMToxlW9guETgWC7kopitdacQxTPQdGZicj4dRwJGn8pnLo28UhLtle5O zPSeOENUPlm/hJFGumQoNF9iXbEoXjkmi2+Jixl/zllhm34/CVCQ+9qfPpk35rSuQQAq bL1mPvWQ5njLLfy3FNZWInDUwZmzbB6OgXQXUNOE6rFdAYEBHvKV8Ev87fU/mvaEF8QX PsXQ== X-Gm-Message-State: AOJu0Yz8yZM+U8c8Z9y9ST1pk44ibWrvsa9pFKi47hydjw0RkIc3fy3O 1Kc4GZzbg0VCW0fx3LwLt54kMSb3y5qEeg== X-Google-Smtp-Source: AGHT+IF7TDITJaTznAYjrrd+kY46g73rnPRz6RfIDo4M5gNoM5TQ/GTUCIrOTwJ++uYKSz9XpVBL9Q== X-Received: by 2002:a05:6214:2625:b0:680:d4c2:a5d1 with SMTP id gv5-20020a056214262500b00680d4c2a5d1mr848733qvb.66.1704384513274; Thu, 04 Jan 2024 08:08:33 -0800 (PST) Received: from [192.168.0.226] (c-98-249-43-138.hsd1.va.comcast.net. [98.249.43.138]) by smtp.gmail.com with ESMTPSA id a15-20020a0cefcf000000b0067f812c4a58sm11592869qvt.60.2024.01.04.08.08.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jan 2024 08:08:32 -0800 (PST) Message-ID: <4655f620-e43f-4381-b3d4-c8d5555fd739@joelfernandes.org> Date: Thu, 4 Jan 2024 11:08:29 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] android: removed asm-generic/errno-base.h To: Christophe JAILLET , Tanzir Hasan , Greg Kroah-Hartman , =?UTF-8?Q?Arve_Hj=C3=B8nnev=C3=A5g?= , Todd Kjos , Martijn Coenen , Christian Brauner , Carlos Llamas , Suren Baghdasaryan Cc: linux-kernel@vger.kernel.org, Nick Desaulniers , Al Viro References: <20231226-binderfs-v1-1-66829e92b523@google.com> Content-Language: en-US From: Joel Fernandes In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 1/4/2024 10:36 AM, Christophe JAILLET wrote: > Le 26/12/2023 à 18:09, Tanzir Hasan a écrit : >> asm-generic/errno-base.h can be replaced by linux/errno.h and the file >> will still build correctly. It is an asm-generic file which should be >> avoided if possible. >> >> Suggested-by: Al Viro >> Signed-off-by: Tanzir Hasan >> --- >>   drivers/android/binderfs.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c >> index 1224ab7aa070..d04ff6029480 100644 >> --- a/drivers/android/binderfs.c >> +++ b/drivers/android/binderfs.c >> @@ -29,7 +29,7 @@ >>   #include >>   #include >>   #include >> -#include >> +#include > > linux/errno.h is already included a few lines above. > Good point! With that nit addressed: Reviewed-by: Joel Fernandes (Google) Thanks.