From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Yoann Padioleau <padator@wanadoo.fr>,
kernel-janitors@lists.osdl.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] old declaration ritchie style fix
Date: Fri, 25 May 2007 10:40:16 +0200 [thread overview]
Message-ID: <4656A0F0.4050909@s5r6.in-berlin.de> (raw)
In-Reply-To: <46568F7F.1040100@gmail.com>
Jiri Slaby wrote:
> Yoann Padioleau napsal(a):
>> static int
>> -receivepkt (target, buffer)
>> - int target;
>> - unsigned char *buffer;
>> +receivepkt (int target, unsigned char *buffer)
>
> When you are at it, you can also get rid of bsd return-type-on-its-own-line
> style
return-type-on-its-own-line is IMO OK if it occurs consistently in a
file. It can improve readability particularly if long return types are
combined with long function names.
> + remove the space before parenthesis.
Indeed.
--
Stefan Richter
-=====-=-=== -=-= ==--=
http://arcgraph.de/sr/
prev parent reply other threads:[~2007-05-25 8:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-24 16:38 Yoann Padioleau
2007-05-25 7:25 ` Jiri Slaby
2007-05-25 8:40 ` Stefan Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4656A0F0.4050909@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=akpm@linux-foundation.org \
--cc=jirislaby@gmail.com \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=padator@wanadoo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®