From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20A5A1DFE23 for ; Mon, 20 Jan 2025 12:42:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=93.104.207.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737376971; cv=none; b=erINBAJZZSiGb/qJCyfQIKmYzTviCXUKLysdwnxaJrH64za3a+9cRSSPvD8TCaPz4bZ1I797FgaxIDUe+k8nuVmSeldPwPF5vFACE09ViCVV/g2t2fZDwHEsPAie4GGDbPjW3dqzbsi/C75VXXmmLXm6EjyX9bjgNHwKs2tshbg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737376971; c=relaxed/simple; bh=CHLOt/LzvAWIm/92jdzxAYHqOSMX9ep6HWnV4uYdaAI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=j/k9vYrM7hmWPvdbGLu7taXAPmgcuOpvtb4dG4ksG9j+DAyTgTwA7J+YjnVpJfKydBN6gSe4Le3+3UODa0uGfTz/fR7vAL6B0RZB3M6CWP1UzZJVKPll7YgQ5rkCHt4r+lEivlZMmG+i7KRpUgtTBkRjNFcy52aej7l5eWCgt+g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com; spf=pass smtp.mailfrom=ew.tq-group.com; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b=Bp2FxziC; dkim=fail (0-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b=bus6D5zv reason="key not found in DNS"; arc=none smtp.client-ip=93.104.207.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b="Bp2FxziC"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b="bus6D5zv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1737376968; x=1768912968; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=BFbLO2cWEj/ewd8T0a5o19kMyH/UgRwpUTORKD2vQPE=; b=Bp2FxziCZhgRQjEuHS5Jhs+/S6zMERcqD/YewoEJu7SuFRzLDkQkuChJ DwHqjQZ8ag2kEshTiOC5Y43oS3rYMyO69p3VF2LryZ6ZKq9K4yTxl7bNs vBuM7QM8qSPn8PFL44M2o7FEOHzFkev6z+ZXwY2mFion7jXhyXcz3m4K5 DQC0bskZAVKE+iQZYeGnGYWrqM2nRWUIXIOn8CCp//ViTrVZ1LXy3R4G3 h1GoLC5bmFv7PAfbp2y3wBz4MFKPer/VAjXBSrdMRNAFTDqfLMec8nIy3 g5Ougr9bL99PVSqKo6ov7orJKBkbibgqMA1nEyLlyOjG4s8ce/MvVjWy/ A==; X-CSE-ConnectionGUID: COd6TbPtS0Wo8zLnhXP/Jw== X-CSE-MsgGUID: 0SI4MExNTE+WT2b711KhVg== X-IronPort-AV: E=Sophos;i="6.13,219,1732575600"; d="scan'208";a="41176678" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 20 Jan 2025 13:42:39 +0100 X-CheckPoint: {678E44BF-19-1D00F64B-E6C57517} X-MAIL-CPID: 56D54D38078A618C932D445764D7CD5B_3 X-Control-Analysis: str=0001.0A682F24.678E44BF.0074,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 71AA71613E2; Mon, 20 Jan 2025 13:42:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1737376954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BFbLO2cWEj/ewd8T0a5o19kMyH/UgRwpUTORKD2vQPE=; b=bus6D5zvDFjT4oG9qlrEpb55JO3o+gMJDdVZDdtUQb3nSOcE0snBY3LtRAp0HgavLujZjz XBCEQopghZPuRcc0JL7tcvzCPNoOhAM6aa3RXCubSX+oQqjK1g8QTVJYbcqhzLH2+sfKrV 80iyYN0FoeGCkZc9KEdSIl56jsL25WPTEkfaTYaAvW3FGnkaehlOkmpOd40Ay6kRHXP1zQ ZfVQRKNfVhj++N/PltKnWbIPygfsjQtBmn2XtzfSf8fUk9WWh7C9SbCcf6tkmcjjWBwv8d W5afYqerakW7t/Ac2VPVYNZTCKbgHC4lwHT5DzN6/pw9XWeyQqa0oZYqp3ur9A== From: Alexander Stein To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Esben Haabendal Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Esben Haabendal Subject: Re: drm/bridge: nwl-dsi: Use vsync/hsync polarity from display mode Date: Mon, 20 Jan 2025 13:42:30 +0100 Message-ID: <4658759.LvFx2qVVIh@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20240814-nwl-dsi-sync-polarity-v1-1-ee198e369196@geanix.com> References: <20240814-nwl-dsi-sync-polarity-v1-1-ee198e369196@geanix.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Last-TLS-Session-Version: TLSv1.3 Hi, I'm sorry I'm late to the party. Am Mittwoch, 14. August 2024, 12:37:26 CET schrieb Esben Haabendal: > Using the correct bit helps. The documentation specifies bit 0 in both > registers to be controlling polarity of dpi_vsync_input and > dpi_hsync_input polarity. Bit 1 is reserved, and should therefore not be > set. >=20 > Tested with panel that requires active high vsync and hsync. >=20 > Signed-off-by: Esben Haabendal > Reviewed-by: Neil Armstrong I just noticed this commit causes a regression on my platform TQMa8Mx/MBa8M= x. DT overlay: arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx-lvds-tm070j= vhg33.dtso My bridges are configured as follow: > $ cat /sys/kernel/debug/dri/30320000.lcd-controller/encoder-0/bridges > bridge[0]: nwl_dsi_bridge_funcs [nwl_dsi] >=20 > type: [0] Unknown > OF: /soc@0/bus@30800000/dsi@30a00000:fsl,imx8mq-nwl-dsi > ops: [0x0] >=20 > bridge[1]: sn65dsi83_funcs [ti_sn65dsi83] >=20 > type: [0] Unknown > OF: /soc@0/bus@30800000/i2c@30a40000/bridge@2d:ti,sn65dsi84 > ops: [0x0] >=20 > bridge[2]: panel_bridge_bridge_funcs >=20 > type: [7] LVDS > OF: /panel-lvds:tianma,tm070jvhg33 > ops: [0x8] modes The display needs active-low sync signals, otherwise the image is shifted by the amount of sync pulse. The patch itself looks good. But there is also nwl_dsi_bridge_atomic_check() unconditionally enabling DRM_MODE_FLAG_PHSYNC and DRM_MODE_FLAG_PVSYNC. Reverting the patch immediately restores the display image correctly. Best regards, Alexander > --- > drivers/gpu/drm/bridge/nwl-dsi.c | 8 ++++---- > drivers/gpu/drm/bridge/nwl-dsi.h | 4 ++-- > 2 files changed, 6 insertions(+), 6 deletions(-) >=20 >=20 > --- > base-commit: 7c626ce4bae1ac14f60076d00eafe71af30450ba > change-id: 20240814-nwl-dsi-sync-polarity-ddc58435a4c4 >=20 > Best regards, >=20 > diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nw= l-dsi.c > index 8d54091ec66e..5f05647a3bea 100644 > --- a/drivers/gpu/drm/bridge/nwl-dsi.c > +++ b/drivers/gpu/drm/bridge/nwl-dsi.c > @@ -289,13 +289,13 @@ static int nwl_dsi_config_dpi(struct nwl_dsi *dsi) > =20 > nwl_dsi_write(dsi, NWL_DSI_INTERFACE_COLOR_CODING, NWL_DSI_DPI_24_BIT); > nwl_dsi_write(dsi, NWL_DSI_PIXEL_FORMAT, color_format); > - /* > - * Adjusting input polarity based on the video mode results in > - * a black screen so always pick active low: > - */ > nwl_dsi_write(dsi, NWL_DSI_VSYNC_POLARITY, > + dsi->mode.flags & DRM_MODE_FLAG_PVSYNC ? > + NWL_DSI_VSYNC_POLARITY_ACTIVE_HIGH : > NWL_DSI_VSYNC_POLARITY_ACTIVE_LOW); > nwl_dsi_write(dsi, NWL_DSI_HSYNC_POLARITY, > + dsi->mode.flags & DRM_MODE_FLAG_PHSYNC ? > + NWL_DSI_HSYNC_POLARITY_ACTIVE_HIGH : > NWL_DSI_HSYNC_POLARITY_ACTIVE_LOW); > =20 > burst_mode =3D (dsi->dsi_mode_flags & MIPI_DSI_MODE_VIDEO_BURST) && > diff --git a/drivers/gpu/drm/bridge/nwl-dsi.h b/drivers/gpu/drm/bridge/nw= l-dsi.h > index a247a8a11c7c..61e7d65cb1eb 100644 > --- a/drivers/gpu/drm/bridge/nwl-dsi.h > +++ b/drivers/gpu/drm/bridge/nwl-dsi.h > @@ -30,11 +30,11 @@ > #define NWL_DSI_PIXEL_FORMAT 0x20c > #define NWL_DSI_VSYNC_POLARITY 0x210 > #define NWL_DSI_VSYNC_POLARITY_ACTIVE_LOW 0 > -#define NWL_DSI_VSYNC_POLARITY_ACTIVE_HIGH BIT(1) > +#define NWL_DSI_VSYNC_POLARITY_ACTIVE_HIGH BIT(0) > =20 > #define NWL_DSI_HSYNC_POLARITY 0x214 > #define NWL_DSI_HSYNC_POLARITY_ACTIVE_LOW 0 > -#define NWL_DSI_HSYNC_POLARITY_ACTIVE_HIGH BIT(1) > +#define NWL_DSI_HSYNC_POLARITY_ACTIVE_HIGH BIT(0) > =20 > #define NWL_DSI_VIDEO_MODE 0x218 > #define NWL_DSI_HFP 0x21c >=20 =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/