mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Riesch <michael.riesch@wolfvision.net>
To: Mehdi Djait <mehdi.djait@bootlin.com>,
	mchehab@kernel.org, heiko@sntech.de, hverkuil-cisco@xs4all.nl,
	krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
	conor+dt@kernel.org
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
	alexandre.belloni@bootlin.com, maxime.chevallier@bootlin.com,
	paul.kocialkowski@bootlin.com
Subject: Re: [PATCH v11 2/3] media: rockchip: Add a driver for Rockchip's camera interface
Date: Fri, 17 Nov 2023 23:25:54 +0100	[thread overview]
Message-ID: <465b920e-9a0a-42c1-bf6c-451fb2471956@wolfvision.net> (raw)
In-Reply-To: <db605935ad21c4780b73db87605b52d30bc936a4.1700132457.git.mehdi.djait@bootlin.com>

Hi Mehdi,

One more thing:

On 11/16/23 12:04, Mehdi Djait wrote:
> [...]
> diff --git a/drivers/media/platform/rockchip/cif/capture.h b/drivers/media/platform/rockchip/cif/capture.h
> new file mode 100644
> index 000000000000..533e62f518da
> --- /dev/null
> +++ b/drivers/media/platform/rockchip/cif/capture.h
> @@ -0,0 +1,21 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Rockchip CIF Driver
> + *
> + * Copyright (C) 2023 Mehdi Djait <mehdi.djait@bootlin.com>
> + */
> +
> +#ifndef _CIF_CAPTURE_H
> +#define _CIF_CAPTURE_H
> +
> +struct cif_device;
> +
> +void cif_unregister_stream_vdev(struct cif_device *dev);
> +int cif_register_stream_vdev(struct cif_device *dev);
> +void cif_stream_init(struct cif_device *dev);
> +void cif_set_default_format(struct cif_device *dev);
> +
> +irqreturn_t cif_irq_pingpong(int irq, void *ctx);
> +void cif_soft_reset(struct cif_device *cif_dev);

This cif_soft_reset occurs only here?! I think it should be removed.

> +
> +#endif
> [...]
With that (and maybe the renaming "Rockchip CIF Camera Interface" ->
"Rockchip Camera Interface (CIF)" throughout the driver, if you find
that suitable) addressed:

Reviewed-by: Michael Riesch <michael.riesch@wolfvision.net>

Thanks and best regards,
Michael

  parent reply	other threads:[~2023-11-17 22:26 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-16 11:04 [PATCH v11 0/3] " Mehdi Djait
2023-11-16 11:04 ` [PATCH v11 1/3] media: dt-bindings: media: add bindings for Rockchip CIF Mehdi Djait
2023-11-16 12:26   ` Rob Herring
2023-11-16 17:58     ` Conor Dooley
2023-11-16 18:01   ` Conor Dooley
2023-11-17 12:15   ` Michael Riesch
2023-11-16 11:04 ` [PATCH v11 2/3] media: rockchip: Add a driver for Rockchip's camera interface Mehdi Djait
2023-11-17  0:52   ` kernel test robot
2023-11-17 22:25   ` Michael Riesch [this message]
2023-11-18 21:35   ` kernel test robot
2023-11-21 10:05   ` Michael Riesch
2023-11-21 18:41   ` Tommaso Merciai
2023-11-22 12:42     ` Michael Riesch
2023-11-22 13:19       ` Paul Kocialkowski
2023-11-22 14:02         ` Mehdi Djait
2023-11-22 13:33       ` Tommaso Merciai
2023-11-22 13:39         ` Michael Riesch
2023-11-29 15:34   ` Paul Kocialkowski
2023-11-16 11:04 ` [PATCH v11 3/3] arm64: dts: rockchip: Add the " Mehdi Djait
2023-11-17 12:18   ` Michael Riesch
2023-11-17 13:19   ` Paul Kocialkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=465b920e-9a0a-42c1-bf6c-451fb2471956@wolfvision.net \
    --to=michael.riesch@wolfvision.net \
    --cc=alexandre.belloni@bootlin.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=maxime.chevallier@bootlin.com \
    --cc=mchehab@kernel.org \
    --cc=mehdi.djait@bootlin.com \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=robh+dt@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®