From: Thomas Backlund <tmb@mageia.org>
To: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH 1/2] Correct function definition for C++
Date: Wed, 1 Mar 2017 01:15:06 +0200 [thread overview]
Message-ID: <46622022-68e2-35eb-e6d6-55f7a62c6f94@mageia.org> (raw)
In-Reply-To: <1487749844.5760.17.camel@infinera.com>
Den 22.02.2017 kl. 09:50, skrev Joakim Tjernlund:
> On Wed, 2017-02-22 at 08:10 +0100, Greg KH wrote:
>> On Tue, Feb 21, 2017 at 04:24:04PM +0100, Joakim Tjernlund wrote:
>>> C++ does does not like the extra extern before asmlinkage, remove it.
>>>
>>> Signed-off-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>
>>> ---
>>> include/linux/printk.h | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/include/linux/printk.h b/include/linux/printk.h
>>> index 3472cc6..be823f5 100644
>>> --- a/include/linux/printk.h
>>> +++ b/include/linux/printk.h
>>
>>
>> Why are you building this file with a C++ compiler?
>
> virtualbox uses C++ and includes various kernel headers and the build
> fails, virtualbox guest additions has not build for quite some time now and
> this is one of the problems.
You need this fix for virtualbox:
https://www.virtualbox.org/changeset/65874/vbox/trunk/configure
--
Thomas
prev parent reply other threads:[~2017-03-01 0:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 15:24 Joakim Tjernlund
2017-02-21 15:24 ` [PATCH 2/2] compiler.h: fix C++ uninitialized const issue Joakim Tjernlund
2017-02-22 7:10 ` [PATCH 1/2] Correct function definition for C++ Greg KH
2017-02-22 7:50 ` Joakim Tjernlund
2017-02-22 13:03 ` greg
2017-02-22 14:00 ` Joakim Tjernlund
2017-02-22 14:22 ` greg
2017-02-22 16:25 ` Joakim Tjernlund
2017-02-28 23:15 ` Thomas Backlund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46622022-68e2-35eb-e6d6-55f7a62c6f94@mageia.org \
--to=tmb@mageia.org \
--cc=Joakim.Tjernlund@infinera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®