From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753815AbbJPJeD (ORCPT ); Fri, 16 Oct 2015 05:34:03 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:65109 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753926AbbJPJd7 (ORCPT ); Fri, 16 Oct 2015 05:33:59 -0400 From: Arnd Bergmann To: huangdaode Cc: davem@davemloft.net, joe@perches.com, liguozhu@hisilicon.com, Yisen.Zhuang@huawei.com, netdev@vger.kernel.org, linuxarm@huawei.com, salil.mehta@huawei.com, kenneth-lee-2012@foxmail.com, xuwei5@hisilicon.com, lisheng011@huawei.com, linux-kernel@vger.kernel.org, lipeng321@huawei.com Subject: [PATCH] net: hisilicon: add OF dependency Date: Fri, 16 Oct 2015 11:33:49 +0200 Message-ID: <4665385.OoIztz6y5m@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1444967657-107994-1-git-send-email-huangdaode@hisilicon.com> References: <1444967657-107994-1-git-send-email-huangdaode@hisilicon.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:aam4ojEyiUEZb3ynP8T7ErCk+exNqvhb8iOq/N+FWPftuVzLqWB TDdEfB1yEmLft/LrfyQi4mE+VCrGqVmWzMCFNw9P1fE9BJwgyvshNUgLe9GCDLJVTkF6NPL 5t+P8/ETYlvHM0HYK4S21nU6sGXf9Fr0ey8o87TSpxLDqE290Uh94CbV8tbxPUNp0qn4edc gZWnurw/Lf0aDOe8dVqlQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:WwE1n8y9pts=:ccUTuEiYSmzoGmsfyMg0Ed yjOXmrdnVbBiWJXxL8Jx0YgKSn5LJ2fQTtMzjfyWIhrQ+4tQmb9KH4zSadnRCmfXRdJcmEEmk qFYKI0derlcHGs2+TbZMKL/FDYvLDXnNb0UZ8zITU1az0TVXA9XrIfr0rJfagXm2Jb97VWUeD OPh9dDl2/ZIegtJ2GPTnMTN7iGXJXSDtNfmX/sI/9SMm6c7GbrWHbK2RkvZrarvp1XMDo/Wta ayOceiyK02yBacN1mVkmsfcBuyWDyiFK0lE0/e1LMw7J8P7speEauEG5vLpd/Z7v9MzgJGigR 7LC7H0583esED33SDSeKQIIdau5DFoU1uWvmjq5sp8YKnUSZjer0krk35UjXmI8dw/LY9RlUL PRwO7yAmWin2N66f62rTXJpVWp1EI0GpIQE5lsUqGc/40aX2ym9pVI80V0sO0/CifCvWTrUW7 raPssnaVloatl8UQIxtZ58fsO0n10zdmOSKQgp+ybBPMZ9xEHgpBguIeokci1iFqwmqXEUIcX XFJlRzt7RvEdY+eDd91+DL/Zl2COTSE3asmps1yIzuiJAGZ8RsgripDqrUvno9pRvov+KZaJY h7UUmLMYFB5hgOLjPCKuWR3Df6JTjq8yJC5UjAezIPreBpB1C+dXCtzmgzJvczc4MQPSNnKuC dr1DYokZ9fAYTjUl3uQ7RI+xjA80N2woZ0h7hky6lHl1O6cKwLFK9y7bojuMXg0hby3Fdipe5 B2fhnjwqqnxKcU6F Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The HNS MDIO driver fails to build on older ARM machines that are not yet converted to CONFIG_OF: drivers/net/ethernet/hisilicon/hns_mdio.c: In function 'hns_mdio_bus_name': drivers/net/ethernet/hisilicon/hns_mdio.c:405:14: error: 'OF_BAD_ADDR' undeclared (first use in this function) u64 taddr = OF_BAD_ADDR; ^ drivers/net/ethernet/hisilicon/hns_mdio.c:405:14: note: each undeclared identifier is reported only once for each function it appears in drivers/net/ethernet/hisilicon/hns_mdio.c:409:11: error: implicit declaration of function 'of_translate_address' [-Werror=implicit-function-declaration] taddr = of_translate_address(np, addr); ^ This clarifies the dependency to ensure we don't attempt to build these drivers without CONFIG_OF, but also adds a COMPILE_TEST alternative to give us better build coverage testing. Build-tested on x86 as well to ensure this actually works. Signed-off-by: Arnd Bergmann diff --git a/drivers/net/ethernet/hisilicon/Kconfig b/drivers/net/ethernet/hisilicon/Kconfig index 8d12b587809e..f250dec488fd 100644 --- a/drivers/net/ethernet/hisilicon/Kconfig +++ b/drivers/net/ethernet/hisilicon/Kconfig @@ -5,7 +5,7 @@ config NET_VENDOR_HISILICON bool "Hisilicon devices" default y - depends on ARM || ARM64 + depends on OF && (ARM || ARM64 || COMPILE_TEST) ---help--- If you have a network (Ethernet) card belonging to this class, say Y.