From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f50.google.com (mail-oo1-f50.google.com [209.85.161.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA49C21C191 for ; Thu, 9 Jan 2025 14:54:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736434479; cv=none; b=HPkQCdyzQxUjP4/4fJyUwwQAJG28IuPmgJS/9dXjQ8Q7qC/YufyBfHpbAYPJYi2mCwsPGiYAUFEN9VQUCNnwIHIqFC17wY0cDq1rb6W+qk+tZ/D4kZDxpaoZ87aaOjVeWMmjeJ3ywUIgYRNm3Gd6I/OGOCt/QxAAty8CnXyFBTc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736434479; c=relaxed/simple; bh=wOsesOoGMFQwvrii1vVjREg0VcRWtZbQQYagw76DDMs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TI7XXtDULx3KouIwZ3r7LobQUxAxv7MZU8dObPFWve+sOUpLaNOH9qkCKgAofENyCyXMShkHSKv/KmtSOQbLxmEvoUpVMgJu3b3mD6HcRurmGjd2TLG0YBfvMuuQFaFaa+2kkhTdo90p76X6oYDouhnIM1GteCF5nWtNimbs9AM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ieee.org; spf=pass smtp.mailfrom=ieee.org; dkim=pass (1024-bit key) header.d=ieee.org header.i=@ieee.org header.b=N/gAEuz9; arc=none smtp.client-ip=209.85.161.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ieee.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ieee.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ieee.org header.i=@ieee.org header.b="N/gAEuz9" Received: by mail-oo1-f50.google.com with SMTP id 006d021491bc7-5f6b65c89c4so210200eaf.2 for ; Thu, 09 Jan 2025 06:54:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; t=1736434476; x=1737039276; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5VULE0UjHIqRlagW/OYJxPj5F0JvqA3RxB6BIakMShg=; b=N/gAEuz9ie5rVvI0CzMjm51v1QbELfm8F5Ufbk+YTjXoVFKZTHDBAGZCTJ9/G52EnR fA4LETeso71ZJam7EPfjbuUA6U6/exat/Dxh5KNc69ojHDIGClchehu6gnicMV16Kv6W nSJdZlhyrKiEVkgKVkVf4Fdkca92LO88y014I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736434476; x=1737039276; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5VULE0UjHIqRlagW/OYJxPj5F0JvqA3RxB6BIakMShg=; b=ZX7dU28LpFWW0RFN5wBornlgyOZCcbH+ktUBTjj1nPlB+TItKAhtlUcv1JpBPozKM3 o22cXWv9Sfrj5naulitdIg10gS6pnQafleyRf3EhLgccaLisHQEYG0KZOhY4cQqdfcP5 zleWrLtyyMFiMSml/4jGVZoLIoNFKdbito1v+XTEFljuPoVULb3OEHpcHYyG/0u5EiGy bcl6S9aoSyVmbF4W/YFqAZ2jQTio+9rwXzZu9cAHOnPzn2j1GhzV86I45M/rLwPKbydL TTf+m61ahcQo3CQc24uNl4nku0KlnIbzdFgwRGVUnvGzBQ2GGBoJrSa3PnbBzYhoMBZu TDLQ== X-Forwarded-Encrypted: i=1; AJvYcCXmb+qgbSse+5bQuVHqqbav7OBdWPlQNq1q6x5rnA+f1VS3hnkXml0zI0lRUN7dzTaO0OTNmKEUCM8pSiM=@vger.kernel.org X-Gm-Message-State: AOJu0YybiJgu74eJQtVXjiUuz5tkEc7pnFZi+W001l4EHNAQnBUUD7Ph pnq2QGoCKqGXGVJA7VYqbe1mggYAFNUmXlQ/A9qCAQnQyX2qjHWDhqsyMd9b5A== X-Gm-Gg: ASbGncuVzbIpFg7j2uZzjNqalECaBVsG8MZGMd4tWVt8aNMFnAxHujn+gNBE+BysxOG 091YdR0iyXOohc0i+ZrrcRizcbtVrMSmGTleUzg37mZBv/1uY8sRjEdamz1dkSJ6BP7Ko8UTqpa 1LaxOOJtBSm6C/x8LIMkB2L8uFtw4hx5Qrl3sJCgBf4JgITocxeM0+w1Iz+GcFoXSc4ipvGbwHu B2J5CrWLSWSDt38dfYg/Pg8VgbXyF033a60DOPWvfz/N78onizBEqlF6phDyiYb8dVECfeOl1W4 4QBQKKHKqAaPkpM= X-Google-Smtp-Source: AGHT+IGX2grguxXy8gLo4Q2N5Rw0zTtUivQW6kIzq7+qZBHhu/OTKNSPcrnL7pgVNEyxcTF+JDsc/Q== X-Received: by 2002:a05:6870:b9c7:b0:29e:69d9:8834 with SMTP id 586e51a60fabf-2aa0609b208mr3769848fac.0.1736434474369; Thu, 09 Jan 2025 06:54:34 -0800 (PST) Received: from [172.22.22.28] (c-73-228-159-35.hsd1.mn.comcast.net. [73.228.159.35]) by smtp.googlemail.com with ESMTPSA id 586e51a60fabf-2ad8059e39esm350832fac.31.2025.01.09.06.54.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jan 2025 06:54:33 -0800 (PST) Message-ID: <46653b18-42b1-4511-afad-4f5a15e2fceb@ieee.org> Date: Thu, 9 Jan 2025 08:54:30 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] staging: greybus: remove unnecessary parentheses To: Dan Carpenter Cc: Will Walsh , Vaibhav Agarwal , Mark Greer , Johan Hovold , Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev References: <20250109003624.37323-1-iron.will.walsh@gmail.com> Content-Language: en-US From: Alex Elder In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/9/25 1:45 AM, Dan Carpenter wrote: > On Wed, Jan 08, 2025 at 08:56:50PM -0600, Alex Elder wrote: >> On 1/8/25 6:36 PM, Will Walsh wrote: >>> Unnecessary parentheses in boolean comparisons make it harder to read. >>> >>> Removed the extra parentheses on line 305 for code readability. >>> >>> Signed-off-by: Will Walsh >> >> I'm not sure this makes a big difference in readability but I >> personally avoid extra parentheses unless adding them makes a >> compiler warning go away. > > It's not a compiler warning, it checkpatch. I meant compiler "-Wparentheses" warnings, like "suggest parentheses around ‘+’ inside ‘<<’". But anyway, I have no problem with this being rejected, it doesn't really add value, and to some, it subtracts. -Alex > > regards, > dan carpenter >