From: Jack Stone <jack@hawkeye.stone.uk.eu.org>
To: linux-kernel@vger.kernel.org
Cc: Ian Kent <raven@themaw.net>, hpa@zytor.com
Subject: Re: [PATCH 0/7] Cleanup code to replace DPRINTK with pr_debug
Date: Sat, 09 Jun 2007 08:56:21 +0100 [thread overview]
Message-ID: <466A5D25.3090008@hawkeye.stone.uk.eu.org> (raw)
In-Reply-To: <1181371406.3423.4.camel@shark.themaw.net>
Ian Kent wrote:
> On Fri, 2007-06-08 at 23:18 +0100, Jack Stone wrote:
>> This patch series replaces DPRINTK with pr_debug in alternative.c,
>> autofs, autofs4
>> and ncpfs. A new function called pr_err is also added to keep
>> functionality in
>> ncpfs. The last 2 patches add support for pr_debug_pid and apply it to
>> autofs4 to
>> keep the output the same as the current DPRINTK statements.
>
> And ???
>
> Presenting patches without the reason why they are needed is not a good
> policy.
>
> Not to mention that several appear to be missing headers, I can't
> believe you tested that they applied before posting them.
>
> NACK.
>
> Ian
Sorry, I think I must've miss copied the patches. I'll re-email them.
The reason for these patches is to move the debug printk macros to the
central debug printk macro. This is so future updates are easier and the
code is more uniform.
Jack
next prev parent reply other threads:[~2007-06-09 7:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-08 22:18 Jack Stone
2007-06-08 22:20 ` [PATCH 1/7] Add a new debug function to kernel.h Jack Stone
2007-06-08 22:21 ` [PATCH 2/7] Replace DPRINTK with pr_debug in alternative.c Jack Stone
2007-06-08 22:22 ` [PATCH 3/7] Replace DPRINTK with pr_debug in autofs Jack Stone
2007-06-08 22:40 ` H. Peter Anvin
2007-06-08 22:23 ` [PATCH 4/7] Update DPRINTK macro to use pr_debug in autofs4 Jack Stone
2007-06-08 22:24 ` [PATCH 5/7] Replace DPRINTK with pr_debug in ncpfs Jack Stone
2007-06-08 22:25 ` [PATCH 6/7] Add pr_debug_pid to kernel.h Jack Stone
2007-06-08 22:25 ` [PATCH 7/7] Replace DPRINTK with pr_debug_pid in autofs4 Jack Stone
2007-06-09 6:43 ` [PATCH 0/7] Cleanup code to replace DPRINTK with pr_debug Ian Kent
2007-06-09 7:56 ` Jack Stone [this message]
2007-06-09 8:00 ` Jack Stone
2007-06-09 8:06 ` [PATCH 1/7] Add a new debug function to kernel.h Jack Stone
2007-06-11 4:34 ` Ian Kent
2007-06-09 8:08 ` [PATCH 2/7] Replace DPRINTK with pr_debug in alternative.c Jack Stone
2007-06-09 18:00 ` Alexey Dobriyan
2007-06-09 18:05 ` Jack Stone
2007-06-09 8:10 ` [PATCH 3/7] Replace DPRINTK with pr_debug in autofs Jack Stone
2007-06-09 8:12 ` [PATCH 4/7] Update DPRINTK macro to use pr_debug Jack Stone
2007-06-09 8:15 ` [PATCH 5/7] Replace DPRINTK with pr_debug in ncpfs Jack Stone
2007-06-09 8:18 ` [PATCH 6/7] Add pr_debug_pid to kernel.h Jack Stone
2007-06-09 18:03 ` Alexey Dobriyan
2007-06-09 18:04 ` Jack Stone
2007-06-09 8:20 ` [PATCH 7/7] Replace DPRINTK with pr_debug_pid in autofs4 Jack Stone
2007-06-10 17:50 ` [PATCH 0/7] Cleanup code to replace DPRINTK with pr_debug Randy Dunlap
2007-06-10 19:29 ` Jack Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=466A5D25.3090008@hawkeye.stone.uk.eu.org \
--to=jack@hawkeye.stone.uk.eu.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®