From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751123AbdAaIkm (ORCPT ); Tue, 31 Jan 2017 03:40:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33926 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750805AbdAaIke (ORCPT ); Tue, 31 Jan 2017 03:40:34 -0500 Subject: Re: [PATCH -next] platform: x86: fix silead_dmi build error and depends To: Randy Dunlap , Platform Driver , Darren Hart , Andy Shevchenko References: <8c34389b-9ea3-88af-7d63-db1ca746083b@infradead.org> Cc: LKML From: Hans de Goede Message-ID: <466ab0fe-51fa-4160-0e9f-fa1998734f0b@redhat.com> Date: Tue, 31 Jan 2017 09:39:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <8c34389b-9ea3-88af-7d63-db1ca746083b@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 31 Jan 2017 08:39:54 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 31-01-17 01:44, Randy Dunlap wrote: > From: Randy Dunlap > > This driver cannot be built as a loadable module, so it should not > be built unless I2C=y and INPUT=y. > > Fixes this build error: > drivers/built-in.o: In function `silead_ts_dmi_init': > silead_dmi.c:(.init.text+0xf00e): undefined reference to `i2c_bus_type' > > Signed-off-by: Randy Dunlap > Cc: Hans de Goede Thank you for catching this. However the depends on INPUT is not necessary at all (likely a copy and paste error during development) can you please do a v2 dropping the input dependency all together ? Regards, Hans > --- > drivers/platform/x86/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > I don't see why the "depends on INPUT" was there at all, > but I modified its requirement anyway. Maybe it can be removed... > > --- linux-next-20170130.orig/drivers/platform/x86/Kconfig > +++ linux-next-20170130/drivers/platform/x86/Kconfig > @@ -1079,7 +1079,7 @@ config INTEL_TURBO_MAX_3 > > config SILEAD_DMI > bool "Tablets with Silead touchscreens" > - depends on ACPI && DMI && I2C && INPUT > + depends on ACPI && DMI && I2C=y && INPUT=y > ---help--- > Certain ACPI based tablets with Silead touchscreens do not have > enough data in ACPI tables for the touchscreen driver to handle >