From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEBD43C276D for ; Thu, 19 Mar 2026 10:35:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773916503; cv=none; b=LG6b9SSffD2G14zbXpvLbrU1DRB7wU3ygCrOCEAhM39u5yJBW9nSsJc26gdDMh6UGzLzF6ovUC6hDMI2GLZXKyV7bUAXjJmful3Dj++v5MeyCR558yfcqNtEZUfyyLmW6K4zuqxZN1vJylC9HLSuw+g5E5S9Uw3GRizZNHdYTxY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773916503; c=relaxed/simple; bh=hAWjeG+NsPQursv7HB44cYhVWfuO9vlvMjswBd0DeMY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=H+trnW4HqXOt9mwHlFKhQiManaTpfWgTnRAuwiTWit2JTstBH2KZRx4i82jFyzhttwWpspAy/XjPJN1lEzrLW9WYxoOEfjJmUneyPPV9bz94qZtTB9xGEP4eLOYvBlEeCEXLInh+YmLpXLQI2LzHFH3LCTj/A9WIQ/JHHRbYxbw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=W6Obaquz; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QIdHoE1h; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="W6Obaquz"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QIdHoE1h" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62J73uZF1770574 for ; Thu, 19 Mar 2026 10:35:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dN1EVu/JbF8IkdV0IBCP32D0+7BYZp0d98zQyiRhmWU=; b=W6ObaquzrkpXwG8w ZxxbaPsjH1ndCM94kiTk4eo8cUZ1hypd0js4Nv8APJ14lcCpVfandQsCktlh2t9T pJs/BTKkO75RfUkNWPtR5NwnM17rZrM6hv8LgfhQohv07aZePUVhGtZwSvjFa9IZ elRXiZEY0SiQ9FT3xuLpfy2M2A0EgQSpj4q8ruTX5IzAFIEXMrIZpNplMRlINmVS LhDeYA4NDKIGUsRguzfd9RPO2Oe22L3DOmk88u/uxboSG7M0KIJDIgFyHRi6COOK 9IEKaHODpUUb/P38hfxXzCBDClrrajbKfF0caFfgfPqaKP/duomiwNigtSHU9R9q PTpnnA== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cyy75u494-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 19 Mar 2026 10:34:59 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-50b27636835so6296181cf.3 for ; Thu, 19 Mar 2026 03:34:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773916499; x=1774521299; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dN1EVu/JbF8IkdV0IBCP32D0+7BYZp0d98zQyiRhmWU=; b=QIdHoE1h016maJZbTABK5UOUSvpm8mxKJwns5lnh2JCh5aX4wClPTk359xLLJRaUyX EVXAr6PF3DdG3yX843kd3AS/k/tE23LJ9qaXHcXk/tlwT2A3EUdV5WhSzgP9J+hjHvig tSHirR0qUJCX0tC8ONX/T4MBkvQ8uipHQChf8W4VWk3HmlSxGDQaAQtRlws+ZUjx1iyj H2+hik2/+NOmhJBunH9nY1dWpGKP5bGR88MwaJMFLJ2jH7B7UYLM1jXP/RIMpAVoDaIw nROhF0wPDVI/6P3DFQ2zhIHp5cwGN5K3wUlL/IZeiBqC/A0Xdu7M/XVwzOEH8MjJnfEF QGNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773916499; x=1774521299; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dN1EVu/JbF8IkdV0IBCP32D0+7BYZp0d98zQyiRhmWU=; b=di4KIHVpLpH3egKjU76wdzWr2a/GVXbIcTzsnqQS+XucAmAOky34lQBCaB1IVg0C8q xoCHi8bGIkCGIKHnm2H5p7ED6mGKvdbbmphD4QlvxcT6pDi7YxyR0n+tkKxeg/thIZnh 2jrkSbSzbZ5tZPsdBCqUoweC01iJ8QGX5qghcFODMfVTvBCmwqlAFPEygcwZ/p/T+Awh Qe9JQarkvHZMYVi20oK1CDnvWSxGoLrIiArpeycnFhG/OcZAQu3fdbJOPcAaPeLqdowU TU2RmtnVKteVouJ6CTMUqwYswCd4RCqncOLZ66WkY6l6xYkZG+tlz2cKxfjK1A2KL9M8 XV/Q== X-Forwarded-Encrypted: i=1; AJvYcCXnUtf/s2WUvhfHufE5N4Q5Zl1JDq4+7UIlcODE81phQ3pmKmvppPs90uCRRE6yFgkM/jMp30ijXZ0AT8c=@vger.kernel.org X-Gm-Message-State: AOJu0YzaEmvo98BhsU4AkP/cc+b8gSmbnmHotp/ZYAooZRBZjqR4hCHx 4lYjVuJRmjLi3beh6yYcGdgAltPN+UxupXfOtGUzEAP8zk4m29h++UmcpZTJiZdETdMQkpNwqqG m1p6qddTXSiLjXSaq5VsWct280V1XlwX0qTdTb/btVVG5YuRChR5QdVoSS7LCLm8eHQs= X-Gm-Gg: ATEYQzwq0b3yfF5t9XzZ6DaH4fvHRCVLRwuEUWuoiA5bLmQaurzOcjrJSrAfdlue4nt Oxh2w+myUthKczLUUGsJM5L+5A/SUrrZJn168GphkiHdoUNWY3Vu1bqt9WU9Athu7y2hg3cEXnT KtqsiXkZoV7VwDKYaEirZ7abpgQ++wGPq+ORzYbwm/Tz97deta3BzfWVYD7TQ0t1r6n2fD5FQHH /51Kab379dcruX28EpH3HW0U4aKFREvNtw/FLjXEnG3zKC7qzxwjjFZ3dsiJbsxBtY/5e5qEvJy 2/Gr1aGIpkYmW+A6i9kAs45jAl4de/H7RxJ06oa28lFdx4gELk2QfBOUxEJX0mLFUyEPBbInI33 D8cHy5aDdKh+QLPnN4HQ07HrubNx+HyXN7WDQqtNiLGaElHpGMD0n7mA8Bn+AZ3/1LvZ7RJsdl+ qaS1g= X-Received: by 2002:a05:622a:44e:b0:509:911:3273 with SMTP id d75a77b69052e-50b148b071fmr64099121cf.6.1773916498935; Thu, 19 Mar 2026 03:34:58 -0700 (PDT) X-Received: by 2002:a05:622a:44e:b0:509:911:3273 with SMTP id d75a77b69052e-50b148b071fmr64098751cf.6.1773916498374; Thu, 19 Mar 2026 03:34:58 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97f1738f1asm402338266b.58.2026.03.19.03.34.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Mar 2026 03:34:57 -0700 (PDT) Message-ID: <466e7543-20d1-4015-89c1-1e2bb0f1cb5e@oss.qualcomm.com> Date: Thu, 19 Mar 2026 11:34:55 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] ARM: dts: qcom: msm8960: expressatt: Add camera flash To: guptarud@gmail.com, Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, David Heidelberg References: <20260318-expressatt_camera_flash-v2-0-5c2b9a623dcb@gmail.com> <20260318-expressatt_camera_flash-v2-3-5c2b9a623dcb@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260318-expressatt_camera_flash-v2-3-5c2b9a623dcb@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE5MDA4NCBTYWx0ZWRfX0OqCBR9OkKsD h13B4+QouKQLUGatBK49Elp5uKPhlA+ywrnSscOdVIi1NehzbppYq9qlJwmPpDQYZ1TrSiY5fXb 7u/zhJl8DF9IlpYg3Ak/3+wTZVH7VVWIuC2XBnKkNjcGQHdpqKjlwyGSJ4AFDMWUq27DdExnv2F KAzG4jfSXBpKOtFWMOL9+JAwvn7zwhE3mJ1Z3muQaKPWw29/lQSni9kbXy4JlDXFdNvn5JdRwVJ w4kaj4kaOF6dcOeQMmv2e0FQYizxcIweKus9Jhz8gEIYPMhaRfctp3GkziMBA0q+Y+VGAygrT5y ufveAk61DPUw6l/DyxSRodwbgxtTEun0F5tkgYGzy+oAjI2/oMudSBMVE+hfKMG/t2knCPDkEe8 C41DbSba8bFG37z2M7AWiHcicR9fxxtDwh17GQkXLp5JC8+B6Bz1aGaMYEr3S46P+5t2ZOOkwVX k+vMGAZf9tae7Eyd/mQ== X-Proofpoint-ORIG-GUID: 4uDTfIZIHH2OjlhbsOMKd6oXJdyzO9eX X-Authority-Analysis: v=2.4 cv=A7hh/qWG c=1 sm=1 tr=0 ts=69bbd153 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=OQN141zOAAAA:20 a=pGLkceISAAAA:8 a=b-NmJ6g92bM9CzcnVPEA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=bA3UWDv6hWIuX7UZL3qL:22 X-Proofpoint-GUID: 4uDTfIZIHH2OjlhbsOMKd6oXJdyzO9eX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-19_01,2026-03-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 bulkscore=0 suspectscore=0 impostorscore=0 spamscore=0 phishscore=0 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603190084 On 3/18/26 7:34 PM, Rudraksha Gupta via B4 Relay wrote: > From: Rudraksha Gupta > > Add camera flash support for the Samsung Galaxy Express (expressatt). > > The flash IC uses a one-wire pulse-count protocol on GPIO 3, powered > by a GPIO-controlled fixed regulator on PMIC MPP 4. The regulator is > modeled as a regulator-fixed node and supplied to the flash IC via > vin-supply. > > Downstream references: > Link: https://github.com/LineageOS/android_kernel_samsung_d2/blob/stable/cm-12.0-YNG4N/drivers/leds/Makefile#L51 > Link: https://github.com/LineageOS/android_kernel_samsung_d2/blob/stable/cm-12.0-YNG4N/arch/arm/mach-msm/board-apexq-camera.c#L591 > > Reviewed-by: David Heidelberg > Signed-off-by: Rudraksha Gupta > --- > .../dts/qcom/qcom-msm8960-samsung-expressatt.dts | 43 ++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts b/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts > index c4b98af6955d..ad5169a60937 100644 > --- a/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts > +++ b/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts > @@ -1,5 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0 > #include > +#include > #include > > #include "qcom-msm8960.dtsi" > @@ -61,6 +62,32 @@ touchkey_enable: touchkey-enable { > regulator-boot-on; > }; > > + flash_gpio_reg: regulator-flash { "vreg_flash:" > + compatible = "regulator-fixed"; > + regulator-name = "flash_led_en"; "_en" makes it sound like it's an enable pin - if we don't have a better idea, perhaps VREG_FLASH_3P3? > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&pm8921_mpps 4 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + pinctrl-0 = <&flash_led_unlock>; > + pinctrl-names = "default"; > + }; > + > + camera_flash: led-controller { Let's drop the label since it's unused > + compatible = "richtek,rt8515"; > + enf-gpios = <&tlmm 3 GPIO_ACTIVE_HIGH>; > + vin-supply = <&flash_gpio_reg>; > + richtek,rfs-ohms = <16000>; > + pinctrl-0 = <&cam_flash_en>; > + pinctrl-names = "default"; > + > + led { > + function = LED_FUNCTION_FLASH; > + color = ; > + flash-max-timeout-us = <250000>; > + }; > + }; > + > i2c-gpio-touchkey { > compatible = "i2c-gpio"; > #address-cells = <1>; > @@ -247,6 +274,13 @@ touchkey_irq_pin: touchkey-irq-state { This label from the context seems not to be present in -next, FWIW > drive-strength = <2>; > bias-disable; > }; > + > + cam_flash_en: cam-flash-en-state { > + pins = "gpio3"; Please keep the pinctrl entries sorted by the GPIO index Konrad