From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754568AbbCIOLE (ORCPT ); Mon, 9 Mar 2015 10:11:04 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:55855 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752218AbbCIOLA (ORCPT ); Mon, 9 Mar 2015 10:11:00 -0400 From: Arnd Bergmann To: linuxppc-dev@lists.ozlabs.org Cc: Geert Uytterhoeven , "linux-kernel@vger.kernel.org" Subject: Re: Build regressions/improvements in v4.0-rc3 Date: Mon, 09 Mar 2015 15:10:49 +0100 Message-ID: <4677994.NrntHOKO7A@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1425898222-19721-1-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:Fwg3tG+JV+31zGJzYbMYXq5EobqeF8Ebr9H2NrDXfpMXJvFOt18 Dbv5BOrRj7YJE96V4dDKek37ZyPaJCH4reMYVWM1HoMjnGpIe7zQW6dhJXsSSHv7kLLdVxn pR63T3ucKP9WN3vEE1Qb2ZFRKA/ckyH5WuPoSe2pp6aBaYyqruLKR5ZEzuyML/42piDAViw qmz1JAJvtfv0lC/8UL5fw== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 09 March 2015 11:56:22 Geert Uytterhoeven wrote: > On Mon, Mar 9, 2015 at 11:50 AM, Geert Uytterhoeven > wrote: > > JFYI, when comparing v4.0-rc3[1] to v4.0-rc2[3], the summaries are: > > - build errors: +18/-7 > > + /home/kisskb/slave/src/arch/arm/mach-pxa/idp.c: error: > 'SMC91X_NOWAIT' undeclared here (not in a function): => 85:47 > + /home/kisskb/slave/src/arch/arm/mach-pxa/idp.c: error: > 'SMC91X_USE_32BIT' undeclared here (not in a function): => 85:11 > + /home/kisskb/slave/src/arch/arm/mach-pxa/idp.c: error: > 'SMC91X_USE_DMA' undeclared here (not in a function): => 85:30 > + /home/kisskb/slave/src/arch/arm/mach-pxa/idp.c: error: unknown > field 'flags' specified in initializer: => 85:2 > + /home/kisskb/slave/src/arch/arm/mach-pxa/idp.c: error: variable > 'smc91x_platdata' has initializer but incomplete type: => 84:15 > > pxa255-idp_defconfig > > + /home/kisskb/slave/src/arch/arm/mach-pxa/lpd270.c: error: expected > '}' before ';' token: => 198:43 > > lpd270_defconfig > > + /home/kisskb/slave/src/arch/arm/mach-sa1100/neponset.c: error: > 'smc91c_platdata' undeclared (first use in this function): => 271:12 > > neponset_defconfig > > + /home/kisskb/slave/src/arch/arm/mach-sa1100/pleb.c: error: > 'smc91c_platdata' undeclared here (not in a function): => 57:22 > > pleb_defconfig > > + /home/kisskb/slave/src/drivers/net/ethernet/smsc/smc91x.c: error: > implicit declaration of function 'machine_has_neponset' > [-Werror=implicit-function-declaration]: => 2363:2 > > neponset_defconfig > > smc91x fallout. The lpd270_defconfig failure looks like not covered by > "ARM: fix typos in smc91x platform data" yet? It's not? This should be part of that patch: --- a/arch/arm/mach-pxa/lpd270.c +++ b/arch/arm/mach-pxa/lpd270.c @@ -195,7 +195,7 @@ static struct resource smc91x_resources[] = { }; struct smc91x_platdata smc91x_platdata = { - .flags = SMC91X_USE_16BIT | SMC91X_NOWAIT; + .flags = SMC91X_USE_16BIT | SMC91X_NOWAIT, }; static struct platform_device smc91x_device = { and I thought I had tested all defconfigs as well as hundreds of randconfigs (the right ones) successfully this time. Arnd