mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>,
	dri-devel@lists.freedesktop.org
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Alexey Brodkin <abrodkin@synopsys.com>,
	David Airlie <airlied@gmail.com>,
	Hui Pu <Hui.Pu@gehealthcare.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Simona Vetter <simona.vetter@ffwll.ch>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [PATCH] drm/arcgpu: fix device node leak
Date: Wed, 19 Nov 2025 20:25:13 +0100	[thread overview]
Message-ID: <4677bcd3-8e90-462a-bfe7-25ed35ea07ea@web.de> (raw)
In-Reply-To: <20251119-drm-arcgpu-fix-device-node-leak-v1-1-06229edcfe6e@bootlin.com>

> This function gets a device_node reference via
> of_graph_get_remote_port_parent() and stores it in encoder_node, but necer

                                                                       never?


> puts that reference. Add it.
> +++ b/drivers/gpu/drm/tiny/arcpgu.c
> @@ -250,7 +250,8 @@ DEFINE_DRM_GEM_DMA_FOPS(arcpgu_drm_ops);
>  static int arcpgu_load(struct arcpgu_drm_private *arcpgu)
>  {
>  	struct platform_device *pdev = to_platform_device(arcpgu->drm.dev);
> -	struct device_node *encoder_node = NULL, *endpoint_node = NULL;
> +	struct device_node *encoder_node __free(device_node) = NULL;
> +	struct device_node *endpoint_node = NULL;
>  	struct drm_connector *connector = NULL;
>  	struct drm_device *drm = &arcpgu->drm;
>  	int ret;

May the scopes be reduced for any of these variables?

Regards,
Markus

      reply	other threads:[~2025-11-19 19:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-19 12:03 Luca Ceresoli
2025-11-19 19:25 ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4677bcd3-8e90-462a-bfe7-25ed35ea07ea@web.de \
    --to=markus.elfring@web.de \
    --cc=Hui.Pu@gehealthcare.com \
    --cc=abrodkin@synopsys.com \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=simona.vetter@ffwll.ch \
    --cc=stable@vger.kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®