From: Mark Brown <broonie@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
krzysztof.kozlowski@linaro.org, pierre-louis.bossart@linux.dev,
linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, dmitry.baryshkov@linaro.org
Subject: Re: [PATCH] ASoC: q6apm-dai: schedule all the periods before we start streaming
Date: Mon, 3 Feb 2025 15:07:22 +0000 [thread overview]
Message-ID: <4678ae0d-434e-4e04-bd77-abae1969ff6c@sirena.org.uk> (raw)
In-Reply-To: <35cf66a2-05ef-4e49-a146-ca96ab19fcf8@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 823 bytes --]
On Mon, Feb 03, 2025 at 02:30:26PM +0000, Srinivas Kandagatla wrote:
> On 03/02/2025 14:17, Mark Brown wrote:
> > On Mon, Feb 03, 2025 at 12:49:45PM +0000, srinivas.kandagatla@linaro.org wrote:
> > > Fix this by scheduling all the periods, this will ensure that the dsp
> > > has enough buffer feed and ultimatley fixing the underruns and audio
> > > distortion.
> > Should we be writing all periods or just the minimum number of periods
> > that's configured? Userspace might not have filled the whole buffer
> > yet.
> Just minimum number of periods or 1 period. We are queuing up all the
> periods to the DSP, so that we do not have to wait for period interrupt to
> queue the next one. This significantly reduces the latency in queuing the
> periods to dsp.
What guarantee do you have that the data isn't garbage?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-02-03 15:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 12:49 srinivas.kandagatla
2025-02-03 14:09 ` Dmitry Baryshkov
2025-02-03 14:12 ` Srinivas Kandagatla
2025-02-03 14:17 ` Mark Brown
2025-02-03 14:30 ` Srinivas Kandagatla
2025-02-03 15:07 ` Mark Brown [this message]
2025-02-03 17:04 ` Srinivas Kandagatla
2025-02-03 17:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4678ae0d-434e-4e04-bd77-abae1969ff6c@sirena.org.uk \
--to=broonie@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.dev \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®