From: Jeff Garzik <jeff@garzik.org>
To: perex@suse.cz
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
akpm <akpm@linux-foundation.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: use __devexit_p
Date: Sat, 23 Jun 2007 18:50:57 -0400 [thread overview]
Message-ID: <467DA3D1.6040702@garzik.org> (raw)
In-Reply-To: <20070623144022.94eb0f27.randy.dunlap@oracle.com>
This reminds me...
Someone needs to go through ALSA and audit all delays executed via
$FOO_interruptible().
Several delays within ALSA wait for hardware conditions, and do not
check for signals pending, which means that the wait-for-condition loop
becomes a busy loop:
while (1) {
foo = read_hardware()
if (foo & interesting_bits)
break;
schedule_timeout_interruptible(1);
}
The proper fix is (a) remove "_interruptible" [recommended] or (b) check
for signals.
grep'ing for "_interruptible" quickly finds several such ALSA bugs.
Jeff
next prev parent reply other threads:[~2007-06-23 22:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-23 21:40 Randy Dunlap
2007-06-23 22:50 ` Jeff Garzik [this message]
2007-06-25 10:46 ` Takashi Iwai
2007-06-25 10:45 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=467DA3D1.6040702@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome