From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752475AbdJ0JJm convert rfc822-to-8bit (ORCPT ); Fri, 27 Oct 2017 05:09:42 -0400 Received: from mga05.intel.com ([192.55.52.43]:47182 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752422AbdJ0JJh (ORCPT ); Fri, 27 Oct 2017 05:09:37 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,304,1505804400"; d="scan'208";a="1235995564" From: "Dilger, Andreas" To: NeilBrown CC: "Drokin, Oleg" , James Simmons , Greg Kroah-Hartman , "lustre-devel@lists.lustre.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/9] staging: lustre: ldlm: remove unused 'work_list' arg from ldlm_process_flock_lock() Thread-Topic: [PATCH 2/9] staging: lustre: ldlm: remove unused 'work_list' arg from ldlm_process_flock_lock() Thread-Index: AQHTS5mYo6gNfshD0kC/uLAbIwpi66L35MOA Date: Fri, 27 Oct 2017 09:09:36 +0000 Message-ID: <467F8795-483A-465C-ADD7-9A3D85CC75AA@intel.com> References: <150871988297.3340.4522589460981284121.stgit@noble> <150872002962.3340.16967380600702796184.stgit@noble> In-Reply-To: <150872002962.3340.16967380600702796184.stgit@noble> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.7.56] Content-Type: text/plain; charset="us-ascii" Content-ID: <338BAE561770DE469B4A43A2239A77E5@intel.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Oct 22, 2017, at 18:53, NeilBrown wrote: > > 'work_list' is only set to NULL, and is never used. > So discard it. > > Signed-off-by: NeilBrown Reviewed-by: Andreas Dilger > --- > drivers/staging/lustre/lustre/ldlm/ldlm_flock.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c b/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c > index f719dc05e1ea..766653b4d8a5 100644 > --- a/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c > +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c > @@ -123,8 +123,7 @@ ldlm_flock_destroy(struct ldlm_lock *lock, enum ldlm_mode mode, __u64 flags) > * > */ > static int ldlm_process_flock_lock(struct ldlm_lock *req, __u64 *flags, > - enum ldlm_error *err, > - struct list_head *work_list) > + enum ldlm_error *err) > { > struct ldlm_resource *res = req->l_resource; > struct ldlm_namespace *ns = ldlm_res_to_ns(res); > @@ -594,7 +593,7 @@ ldlm_flock_completion_ast(struct ldlm_lock *lock, __u64 flags, void *data) > /* We need to reprocess the lock to do merges or splits > * with existing locks owned by this process. > */ > - ldlm_process_flock_lock(lock, &noreproc, &err, NULL); > + ldlm_process_flock_lock(lock, &noreproc, &err); > } > unlock_res_and_lock(lock); > return rc; > > Cheers, Andreas -- Andreas Dilger Lustre Principal Architect Intel Corporation