mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Heiner Kallweit <hkallweit1@gmail.com>
To: Ruslan Babayev <ruslan@babayev.com>,
	Russell King <linux@armlinux.org.uk>,
	Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>
Cc: xe-linux-external@cisco.com,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] net: phy: sfp: enable i2c-bus detection on ACPI based systems
Date: Sun, 5 May 2019 23:03:57 +0200	[thread overview]
Message-ID: <468586e7-4ebf-1156-ed61-4c5dca0c0e63@gmail.com> (raw)
In-Reply-To: <20190505205140.17052-2-ruslan@babayev.com>

On 05.05.2019 22:51, Ruslan Babayev wrote:
> Lookup I2C adapter using the "i2c-bus" device property on ACPI based
> systems similar to how it's done with DT.
> 
> An example DSD describing an SFP on an ACPI based system:
> 
> Device (SFP0)
> {
>     Name (_HID, "PRP0001")
>     Name (_DSD, Package ()
>     {
>         ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
>         Package () {
>             Package () { "compatible", "sff,sfp" },
>             Package () { "i2c-bus", \_SB.PCI0.RP01.I2C.MUX.CH0 },
>         },
>     })
> }
> 
> Signed-off-by: Ruslan Babayev <ruslan@babayev.com>
> Cc: xe-linux-external@cisco.com
> ---
>  drivers/net/phy/sfp.c | 33 +++++++++++++++++++++++++--------
>  1 file changed, 25 insertions(+), 8 deletions(-)
> 
If we have a patch series touching more than one sub-system a typical
approach is:
- Send series to all persons / lists being responsible for the affected
  subsystems
- Maintainers will agree through which tree the series will go
- Maintainers of the other subsystems will ACK their respective patches
  of the series

I just received patch 2/2. The complete series (cover letter + two patches)
should have gone to i2c and phylib maintainers + lists.

As an additional hint regarding the commit message:
I suppose you added this code to support a specific device. Wouldn't hurt
if you mention which device it is.

  reply	other threads:[~2019-05-05 21:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-05 19:34 [PATCH] " Ruslan Babayev
2019-05-05 19:51 ` Heiner Kallweit
2019-05-05 20:51 ` [PATCH 1/2] i2c: acpi: export i2c_acpi_find_adapter_by_handle Ruslan Babayev
2019-05-05 20:51 ` [PATCH 2/2] net: phy: sfp: enable i2c-bus detection on ACPI based systems Ruslan Babayev
2019-05-05 21:03   ` Heiner Kallweit [this message]
2019-05-25  0:53 ` [PATCH net-next v2 1/2] i2c: acpi: export i2c_acpi_find_adapter_by_handle Ruslan Babayev
2019-05-27  8:39   ` Mika Westerberg
2019-05-28  2:26     ` Ruslan Babayev
2019-05-27 18:47   ` Wolfram Sang
2019-05-28  2:03     ` Ruslan Babayev
2019-05-25  0:53 ` [PATCH net-next v2 2/2] net: phy: sfp: enable i2c-bus detection on ACPI based systems Ruslan Babayev
2019-05-25  1:04   ` Andrew Lunn
2019-05-27  5:14   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=468586e7-4ebf-1156-ed61-4c5dca0c0e63@gmail.com \
    --to=hkallweit1@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=ruslan@babayev.com \
    --cc=xe-linux-external@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®