Re: [PATCH] I386: Deactivate the test for the dead CONFIG_BALANCED_IRQ_DEBUG variable.

[Stefan Richter <stefanr@s5r6.in-berlin.de>]

Robert P. J. Day wrote:
> --- a/arch/i386/kernel/io_apic.c
> +++ b/arch/i386/kernel/io_apic.c
> @@ -353,7 +353,7 @@ static void set_ioapic_affinity_irq(unsigned int irq, cpumask_t cpumask)
>  # include <linux/slab.h>		/* kmalloc() */
>  # include <linux/timer.h>	/* time_after() */
> 
> -#ifdef CONFIG_BALANCED_IRQ_DEBUG
> +#if 0 /* debug IRQ balancing */
>  #  define TDprintk(x...) do { printk("<%ld:%s:%d>: ", jiffies, __FILE__, __LINE__); printk(x); } while (0)
>  #  define Dprintk(x...) do { TDprintk(x); } while (0)
>  # else

Regarding the Subject:  Perhaps it's not of type "dead (K)config
variable"in the strict sense but rather of the type "local macro whose
name was unbefittingly taken from CONFIG_ namespace".

BTW, when I suggested the "#if 0" to you, I forgot that some developers
might be interested in compiling their kernel with
-DCONFIG_BALANCED_IRQ_DEBUG injected via the commandline. But we'll hear
from them if that's the case.

On the other hand, these debug macros seem to be very old.  I'll have a
closer look with qgit/git-blame later today.  Maybe it's time to remove
them now.
-- 
Stefan Richter
-=====-=-=== -=== --==-
http://arcgraph.de/sr/