From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6F98C43381 for ; Sat, 16 Feb 2019 15:39:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 96B7221925 for ; Sat, 16 Feb 2019 15:39:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730234AbfBPPjB (ORCPT ); Sat, 16 Feb 2019 10:39:01 -0500 Received: from relay1.mentorg.com ([192.94.38.131]:45945 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727151AbfBPPjA (ORCPT ); Sat, 16 Feb 2019 10:39:00 -0500 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-MBX-04.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1gv1m4-0000Lj-IJ from Akash_Gajjar@mentor.com ; Sat, 16 Feb 2019 07:21:04 -0800 Received: from [172.30.152.20] (137.202.0.90) by SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Sat, 16 Feb 2019 15:20:57 +0000 Subject: Re: [PATCH 2/4] arm64: dts: rockchip: rockpro64 dts remove unused node To: =?UTF-8?Q?Heiko_St=c3=bcbner?= CC: Rob Herring , Mark Rutland , Oskari Lemmela , Shohei Maruyama , Levin Du , , , , References: <20190213170651.3210-1-Akash_Gajjar@mentor.com> <4653141.o6ZdamfZ6d@diego> <7155828.jr86DZMtXN@diego> From: agajjar Message-ID: <468cbdb5-954a-bb1b-106f-14e387f6781f@mentor.com> Date: Sat, 16 Feb 2019 20:50:55 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <7155828.jr86DZMtXN@diego> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-05.mgc.mentorg.com (139.181.222.5) To SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/16/2019 2:16 AM, Heiko Stübner wrote: > Am Freitag, 15. Februar 2019, 13:08:16 CET schrieb agajjar: >> On 2/15/2019 2:48 PM, Heiko Stübner wrote: >>> Am Mittwoch, 13. Februar 2019, 18:06:38 CET schrieb Akash Gajjar: >>>> lcd panel pinmux and vcc1v8_s3 regulator is redundant and has a no >>>> impact, >>>> so removing it. >>>> >>>> Signed-off-by: Akash Gajjar >> Hi Heiko, >> >>> vcc1v8_s3 is actually also a emmc supply, so I'd like to keep it around >>> for completenes sake. >> Emmc module is supplied by PMIC vcc3v3_s3 (SWITCH_REG1) and vcc_1v8 >> (DCD_REG4). >> >> So I believe removing vcc1v8_s3 has no impact on emmc supply line. > looking at the rockpro64 schematics page 10, I see vcca1v8_s3 linked > to the emmc_vdd_1v8 input and obviously also as reference for the saradc. You are referring Pilot production release (rockpro64_v20-SCH.pdf), please refer Second batch production release (rockpro64_v21-SCH.pdf). both the schematic release is available at http://wiki.pine64.org/index.php/ROCKPro64_Main_Page > > So I think we really could keep it around, so that the power-tree resembles > the schematics more. Thanks, Akash