From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D2CBC468C6 for ; Thu, 19 Jul 2018 17:38:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ED20F20671 for ; Thu, 19 Jul 2018 17:38:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED20F20671 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732118AbeGSSW0 convert rfc822-to-8bit (ORCPT ); Thu, 19 Jul 2018 14:22:26 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:55182 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731680AbeGSSW0 (ORCPT ); Thu, 19 Jul 2018 14:22:26 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8282C40252ED; Thu, 19 Jul 2018 17:38:14 +0000 (UTC) Received: from llong.remote.csb (dhcp-17-175.bos.redhat.com [10.18.17.175]) by smtp.corp.redhat.com (Postfix) with ESMTP id A385F2026D6B; Thu, 19 Jul 2018 17:38:13 +0000 (UTC) Subject: Re: [PATCH v11 7/9] cpuset: Expose cpus.effective and mems.effective on cgroup v2 root To: Tejun Heo , Peter Zijlstra Cc: Li Zefan , Johannes Weiner , Ingo Molnar , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kernel-team@fb.com, pjt@google.com, luto@amacapital.net, Mike Galbraith , torvalds@linux-foundation.org, Roman Gushchin , Juri Lelli , Patrick Bellasi References: <1529825440-9574-8-git-send-email-longman@redhat.com> <20180702165322.GI533219@devbig577.frc2.facebook.com> <20180703155823.GS533219@devbig577.frc2.facebook.com> <20180719135224.GE2494@hirez.programming.kicks-ass.net> <1107494a-9667-df58-dcac-9366e969dc3a@redhat.com> <20180719153045.GT72677@devbig577.frc2.facebook.com> <20180719165201.GU72677@devbig577.frc2.facebook.com> <69903192-8711-6a1e-0cd0-fbb249a4204b@redhat.com> <20180719172551.GW72677@devbig577.frc2.facebook.com> From: Waiman Long Organization: Red Hat Message-ID: <468d70b2-c3d8-53c6-bbda-050106bcf60d@redhat.com> Date: Thu, 19 Jul 2018 13:38:13 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20180719172551.GW72677@devbig577.frc2.facebook.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Content-Language: en-US X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Thu, 19 Jul 2018 17:38:14 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Thu, 19 Jul 2018 17:38:14 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'longman@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/19/2018 01:25 PM, Tejun Heo wrote: > Hello, Waiman. > > On Thu, Jul 19, 2018 at 01:22:36PM -0400, Waiman Long wrote: > ... >> Do you want a way at the parent level to take CPUs away from child >> partitions? The "cpus.subpart" file can probably be used also for this >> purpose, but we have to decide what taking CPUs away from child >> partition means. Does that mean automatically turn off the partition >> flag in the children if there is no CPU left in the partition? There are > Yeah, I think so. That's what we do when cpuset.cpus or mems go empty > - ignoring the config. > >> some implementation details that need to be fleshed out. I would prefer >> not doing this as this will complicate the code without too much benefit >> that I can see. > So, given how long this has been dragging along and it isn't yet super > clear to me why this needs to be fully hierarchical, I'd actually > prefer just restricting it to the first level children. > > Thanks. > Yes, I would prefer to check in the v11 cpuset patch as it is today, including the incremental patch to limit partition to first level child minus the debug patch. I do need to make cpuset v2 enabled ASAP. This will give me more times to work on extending partition to be hierarchical if the need arises as well as other cpuset v2 features. We usually can't get all the things right in one single step. Peter, are you OK with that? I can promise you that I will work to make this happen at a later date if you really want it. Cheers, Longman