From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753183AbdHJRaJ (ORCPT ); Thu, 10 Aug 2017 13:30:09 -0400 Received: from mx2.suse.de ([195.135.220.15]:40221 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752559AbdHJRaI (ORCPT ); Thu, 10 Aug 2017 13:30:08 -0400 Subject: Re: [PATCH 1/3] paravirt,xen: remove xen_patch() To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, hpa@zytor.com, mingo@redhat.com, tglx@linutronix.de, boris.ostrovsky@oracle.com, rusty@rustcorp.com.au, lguest@lists.ozlabs.org References: <20170810125254.1347-1-jgross@suse.com> <20170810125254.1347-2-jgross@suse.com> <20170810162453.umt72mwdvvzitene@hirez.programming.kicks-ass.net> <20170810162920.a3jkgibz4iygi3g7@hirez.programming.kicks-ass.net> From: Juergen Gross Message-ID: <468e9f1c-a3fc-aa86-ee79-da9683f7d926@suse.com> Date: Thu, 10 Aug 2017 19:30:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170810162920.a3jkgibz4iygi3g7@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/08/17 18:29, Peter Zijlstra wrote: > On Thu, Aug 10, 2017 at 06:24:53PM +0200, Peter Zijlstra wrote: >> -ENTRY(xen_irq_enable_direct) >> - FRAME_BEGIN >> - /* Unmask events */ >> - movb $0, PER_CPU_VAR(xen_vcpu_info) + XEN_vcpu_info_mask >> - >> - /* >> - * Preempt here doesn't matter because that will deal with any >> - * pending interrupts. The pending check may end up being run >> - * on the wrong CPU, but that doesn't hurt. >> - */ >> - >> - /* Test for pending */ >> - testb $0xff, PER_CPU_VAR(xen_vcpu_info) + XEN_vcpu_info_pending >> - jz 1f >> - >> -2: call check_events >> -1: >> -ENDPATCH(xen_irq_enable_direct) >> - FRAME_END >> - ret >> - ENDPROC(xen_irq_enable_direct) >> - RELOC(xen_irq_enable_direct, 2b+1) > > Oh my bad, part of that is still used. > > arch/x86/xen/enlighten_pv.c: pv_irq_ops.irq_enable = __PV_IS_CALLEE_SAVE(xen_irq_enable_direct); > > It just needs cleanups for the ENDPATCH and such. Ah yes, of course. Juergen