mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Scott Ashcroft <scott.ashcroft@talk21.com>
To: Kernel development list <linux-kernel@vger.kernel.org>
Subject: Always zero test in arch/i386/pci/mmconfig-shared.c
Date: Tue, 10 Jul 2007 19:22:27 +0100	[thread overview]
Message-ID: <4693CE63.1090102@talk21.com> (raw)

I don't think it makes any change to subsequent flow but the code in 
pci_mmcfg_check_hostbridge is:

pci_mmcfg_config_num = 0;

...

if (name) {
	printk(KERN_INFO "PCI: Found %s %s MMCONFIG support.\n",
	       name, pci_mmcfg_config_num ? "with" : "without");
}

So it will always prints "without".

I'd make a patch but I'm not sure what this fix is. Just drop the test, 
the printk or make it say "which might possibly have"?

Cheers,
Scott

             reply	other threads:[~2007-07-10 18:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-10 18:22 Scott Ashcroft [this message]
     [not found] <fa.nwpKC6+7UvIqGGeRe+rNP7ZO5P4@ifi.uio.no>
2007-07-13 23:42 ` Robert Hancock
2007-07-14  0:18   ` Scott Ashcroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4693CE63.1090102@talk21.com \
    --to=scott.ashcroft@talk21.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome