From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752991AbbKQI6M (ORCPT ); Tue, 17 Nov 2015 03:58:12 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:56069 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751940AbbKQI6K (ORCPT ); Tue, 17 Nov 2015 03:58:10 -0500 From: Arnd Bergmann To: Catalin Marinas , will.deacon@arm.com Cc: kernel-build-reports@lists.linaro.org, olof@lixom.net, David Miller , eric.dumazet@gmail.com, netdev@vger.kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: next build: 235 warnings 3 failures (next/next-20151117) Date: Tue, 17 Nov 2015 09:57:30 +0100 Message-ID: <4694362.ZPL12j6kR2@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <564a9961.878b420a.331b8.fffffd62@mx.google.com> References: <564a9961.878b420a.331b8.fffffd62@mx.google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:TxfW5Vj31R+Lh2eW5/adaneiaVsfGUZtTIk4KKoL4wKCRb1DrdY PmYNpA3g80YBh+8EsxN4qWMgguxGDiE24XUoLtP/sxWq8CAkvhea3GC7qWm99SWCSpApdY0 AMTh/PCTHL5mnAnODFciodTc/ZaLCH5Wm/m4MS3KBlU3hjrTJ2nMmhCx7NDhifQ9m+Vyf0r UkLb0WuRzpZOMy2HRTD+A== X-UI-Out-Filterresults: notjunk:1;V01:K0:v1Jk7pGQnkE=:JzPU7+JrnS8P6w6useHu3n 814n1ufScAG0wkTwTh08CDdSSFdJutmiFrU3AGO104qPQFNdb+ZGWpZfyb0quTzB/el381j+r dFl1kpIp0fv4izuxK28RPMo4fdvPRtM/FqqbfXj3gDD5wNInqCny4HInN/vzpZeFTvhXDZhmt f9Uj/G6TFHwcYbDcAiQweqpEq3sZTSErfn6jfFNzcke1gpDJ73Mn1Fs0EEirfoqFQTMdtGgvX W5bE/Nb2N4hHua45hYPnaEKi3ipWR0xaBsC97+CArcrfU72K3tUAXpizSgrzX8ppe/lLe43PH a4Na/mffZUCqLYq/TanCEEQc1+oNpODoAShk05PEnqo+quEmj6cSCmjh2zkhrqLvyhp9X9YRl DuOkQWYWqH6ez2TqvKHPG4o7t9IPNdIAK48XIJ8kL2uyZSt1pKBicWdZH/dnWWRChj9GVCxej Zw+wB6VwqBfFaIo1cfKq5Sv33Z4TJi4zN1rAyli+tfV/Ostlg6xwXY5EzhfA+1jj1TLRTWkfM JiOK2tEPuwQ0R/MOqbcJoazlhyWCq4PRwratNrDwgaL4l3E/g6mhUYK9RzuoAA8gATXZE3cRU xcS/V5MOAfudhU5xy49BVsg9eyBObw4Ojg5tseR3jt0BdsuOhc2lOqdpiqfE+Zu/osCuf5xK9 mlGNAE/T8BCnCKUi+a92G6I5FK+qTUvTlXQuDruYYrVFQsnTqYH1bK30P9jZ1Qhwp98dYC3pt oNY+0YGDlyJWrkwb Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 16 November 2015 19:05:05 Olof's autobuilder wrote: > > Errors: > > arm64.allmodconfig: > arch/arm64/include/asm/barrier.h:71:3: error: read-only variable '___p1' used as 'asm' output > arch/arm64/include/asm/barrier.h:75:3: error: read-only variable '___p1' used as 'asm' output > arch/arm64/include/asm/barrier.h:79:3: error: read-only variable '___p1' used as 'asm' output > arch/arm64/include/asm/barrier.h:83:3: error: read-only variable '___p1' used as 'asm' output > arch/arm64/include/asm/barrier.h:71:3: error: read-only variable '___p1' used as 'asm' output > arch/arm64/include/asm/barrier.h:75:3: error: read-only variable '___p1' used as 'asm' output > arch/arm64/include/asm/barrier.h:79:3: error: read-only variable '___p1' used as 'asm' output > arch/arm64/include/asm/barrier.h:83:3: error: read-only variable '___p1' used as 'asm' output > arch/arm64/include/asm/barrier.h:71:3: error: read-only variable '___p1' used as 'asm' output The patch below seems to fix it. Please review/apply. 8<---- Subject: ARM64: make smp_load_acquire() work with const arguments smp_load_acquire() uses typeof() to declare a local variable for temporarily storing the output of the memory access. This fails when the argument is constant, because the assembler complains about using a constant register as output: arch/arm64/include/asm/barrier.h:71:3: error: read-only variable '___p1' used as 'asm' output This changes the implementation to use an 'unsigned long' for the temporary value and only cast it to the original type in the end. Signed-off-by: Arnd Bergmann diff --git a/arch/arm64/include/asm/barrier.h b/arch/arm64/include/asm/barrier.h index 624f9679f4b0..05fa329467f6 100644 --- a/arch/arm64/include/asm/barrier.h +++ b/arch/arm64/include/asm/barrier.h @@ -64,7 +64,7 @@ do { \ #define smp_load_acquire(p) \ ({ \ - typeof(*p) ___p1; \ + unsigned long ___p1; \ compiletime_assert_atomic_type(*p); \ switch (sizeof(*p)) { \ case 1: \ @@ -84,7 +84,7 @@ do { \ : "=r" (___p1) : "Q" (*p) : "memory"); \ break; \ } \ - ___p1; \ + (typeof(*p))___p1; \ }) #define read_barrier_depends() do { } while(0)