From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1441D3E5571 for ; Fri, 24 Apr 2026 17:21:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777051320; cv=none; b=Fv0oEJjo0M7Xt9NSe7vYHJm+jlGgyWSBN8+cxi1yNaEZOF8f33zYn/L1DUXVuOlVpxMnqfcy9k7KYgcae/aqaluUQUJIsl/uoCzIj0Fh4y11ZtkKXjTkNLJB5Jf7hwROfP+o/32jE8IpBHM21qbi568aEFIIZTLrcliDDSz8mk8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777051320; c=relaxed/simple; bh=95z0XIt4PiRM0mSi8tZF2ggc5CB4vKKWpTlHtvX8NmU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=vCuAlBgh7AVhlMHAOljho1elQYuRp18zYGYinBwtC13ITD1zMasjjqnpyJar09ou0rIq4cFBHVewhT1C7RhKQqX2xcafSEpZTmJ53RT86oNuoZBMQD7sDuaIkd7bk+VROkULBo9F7kU4K+VZ9TVjKuxk5prjWZB5CLpy7WeRssc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Zwxv67CE; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Zwxv67CE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777051317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XlT2C+6GgdAk9z52bJe0h440fytJPDoIRU7OOb/gQQI=; b=Zwxv67CEy2a1D7us8oLi4ITPQvcIq366EUXpvk7nOogKiFHT/F8CpmzqqIHaIgEChsgDyw KofjioqVH2Uapb4tMgWTHOkMvxjWZoYI/sxWQNNoUuDgXP19K2OGS04ALwnP3ePy5jZxTN xWy5ryIX9vSENuVVoxNrm1AIwlabJA0= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-614-O7jv_eNhPyChhavdbyIjlw-1; Fri, 24 Apr 2026 13:21:56 -0400 X-MC-Unique: O7jv_eNhPyChhavdbyIjlw-1 X-Mimecast-MFC-AGG-ID: O7jv_eNhPyChhavdbyIjlw_1777051316 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8a22dbeeb96so163435156d6.3 for ; Fri, 24 Apr 2026 10:21:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777051316; x=1777656116; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XlT2C+6GgdAk9z52bJe0h440fytJPDoIRU7OOb/gQQI=; b=BTmQJ1gf3bL1BXEi3dBd7UACjW+37UAPKzwbSxz0UW75BHwcRT7yvUqVyos/0dQdwC 0hsB1jSHYL/fmf8oIjQZiwtiRH4pqxVgrUrl5m92XOgbNdRWI8RvHB61mSODFMg3tJqv awQ7qL53c/rTVnuyys+v3jfurTc8Hsi3/GSa9gXIuv5Ivadj0NYik73AwvgorY2+wYKp X2pUHeOw4ZlvTx1a22tegwleHyuIkj1kUZ6XQ+3sDeg+Xo3+dqRUtJGnmKB150Zxp2bB lODqQ84RYdw6Brsaiw4Af9Wa4+/YGXBGdVnSi6AjbzA4O9MZr4Q+gQzBj/I13PncPeeG dlQQ== X-Forwarded-Encrypted: i=1; AFNElJ8PL9sPua8CtOhwO3ryXDL0xQhaObyH5S2cRwhqtacZf1jK+gLvarnaaYhBLvUbA9sgCiZsEAUyUKr4lEg=@vger.kernel.org X-Gm-Message-State: AOJu0YyquwkECC6+wdtmhSvBK/FmzWagKnGM5MiI5jqFEaHwdO4kkLzi Gz42Xhc1lsOY+b13+o0p3Cbf/Dynt8RhPlvG2cQijNpJCMJuef8ZpTDTZEF825/wKhiImGf547I 52HYojWhPFNrozsCcI5oRB3H0LoX1gMfLcbXflhPXl5lU1t5vVjfjLtQKG0roW1QGeg== X-Gm-Gg: AeBDiev6XjU6hCd6d3ej5Gl3Buvbk78tRzd5R3Oi+Om9fR1u/iwNQenop2AgliG/qKu RmJRX4BSZz8OrFL3PDohivVGIsMwPq//aZMY+WvgM7emhe9pKoTrEV7l+xF0iT0LGntuGnSOqYw FD9ds53op2TGhAPEFXD9wlqRST0zBE84th9v0w1ZKFYDxWyNOWJ7hAmxZyGlRLm1EgWhv5ZtZFd xInSBVFQIUBEQkHr8lnPOe7572dBLBN54zsiZqVtEYZXFH0PTxE0QesM3MhhFi2wJxE7jyTqSVm 5a9TOdwYrg0SdZXtvJNsYRO5wJ/rYoVuV4hM24CVgcviyT7aF408IPYEVhRhdJwwXmySZI5wgKJ +40wfFCuLRxoOybjBUpTOUY/7NGuo7p8IqpcK X-Received: by 2002:a05:6214:1d0a:b0:8ac:d13c:1938 with SMTP id 6a1803df08f44-8b0280ffd78mr487358106d6.17.1777051316154; Fri, 24 Apr 2026 10:21:56 -0700 (PDT) X-Received: by 2002:a05:6214:1d0a:b0:8ac:d13c:1938 with SMTP id 6a1803df08f44-8b0280ffd78mr487357426d6.17.1777051315590; Fri, 24 Apr 2026 10:21:55 -0700 (PDT) Received: from [192.168.2.110] ([69.159.169.238]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8b02ae97d89sm193980186d6.42.2026.04.24.10.21.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Apr 2026 10:21:55 -0700 (PDT) Message-ID: <46971f34-a287-4209-8716-880926e0b8d2@redhat.com> Date: Fri, 24 Apr 2026 13:21:43 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 51/53] selftests/mm: va_high_addr_switch.sh: drop huge pages setup To: Mike Rapoport , Andrew Morton , David Hildenbrand Cc: Baolin Wang , Barry Song , Dev Jain , Donet Tom , Jason Gunthorpe , John Hubbard , "Liam R. Howlett" , Lance Yang , Leon Romanovsky , Lorenzo Stoakes , Mark Brown , Michal Hocko , Nico Pache , Peter Xu , Ryan Roberts , Sarthak Sharma , Shuah Khan , Suren Baghdasaryan , Vlastimil Babka , Zi Yan , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org References: <20260418105539.1261536-1-rppt@kernel.org> <20260418105539.1261536-52-rppt@kernel.org> Content-Language: en-US, en-CA From: Luiz Capitulino In-Reply-To: <20260418105539.1261536-52-rppt@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026-04-18 06:55, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Since va_high_addr_switch takes care of setting up huge pages, there is > no need to set them up in the va_high_addr_switch.sh wrapper script. > > Signed-off-by: Mike Rapoport (Microsoft) > --- > .../selftests/mm/va_high_addr_switch.sh | 39 +------------------ > 1 file changed, 1 insertion(+), 38 deletions(-) > > diff --git a/tools/testing/selftests/mm/va_high_addr_switch.sh b/tools/testing/selftests/mm/va_high_addr_switch.sh > index 9492c2d72634..d66c0fd3cb4d 100755 > --- a/tools/testing/selftests/mm/va_high_addr_switch.sh > +++ b/tools/testing/selftests/mm/va_high_addr_switch.sh > @@ -9,7 +9,6 @@ > > # Kselftest framework requirement - SKIP code is 4. > ksft_skip=4 > -orig_nr_hugepages=0 > > skip() > { > @@ -77,43 +76,7 @@ check_test_requirements() > esac > } > > -save_nr_hugepages() > -{ > - orig_nr_hugepages=$(cat /proc/sys/vm/nr_hugepages) > -} > - > -restore_nr_hugepages() > -{ > - echo "$orig_nr_hugepages" > /proc/sys/vm/nr_hugepages > -} > - > -setup_nr_hugepages() > -{ > - local needpgs=$1 > - while read -r name size unit; do > - if [ "$name" = "HugePages_Free:" ]; then > - freepgs="$size" > - break > - fi > - done < /proc/meminfo > - if [ "$freepgs" -ge "$needpgs" ]; then > - return > - fi > - local hpgs=$((orig_nr_hugepages + needpgs)) > - echo $hpgs > /proc/sys/vm/nr_hugepages > - > - local nr_hugepgs=$(cat /proc/sys/vm/nr_hugepages) > - if [ "$nr_hugepgs" != "$hpgs" ]; then > - restore_nr_hugepages > - skip "$0: no enough hugepages for testing" > - fi > -} > - > check_test_requirements > -save_nr_hugepages > -# The HugeTLB tests require 6 pages > -setup_nr_hugepages 6 > -./va_high_addr_switch --run-hugetlb > +./va_high_addr_switch > retcode=$? > -restore_nr_hugepages > exit $retcode The retcode=$? and the last line are deadcode now and can be removed.