From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932443AbcDYMZN (ORCPT ); Mon, 25 Apr 2016 08:25:13 -0400 Received: from mail-lf0-f53.google.com ([209.85.215.53]:34337 "EHLO mail-lf0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932330AbcDYMZH (ORCPT ); Mon, 25 Apr 2016 08:25:07 -0400 Subject: Re: [PATCH RESEND 2/5] USB: serial: cp210x: Made sure SERIAL_XOFF_CONTINUE flag is clear. To: Konstantin Shkolnyy , johan@kernel.org References: <1461517750-6205-1-git-send-email-konstantin.shkolnyy@gmail.com> Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Message-ID: <469850ff-86e5-85ad-0144-e19a788d7752@cogentembedded.com> Date: Mon, 25 Apr 2016 15:25:04 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <1461517750-6205-1-git-send-email-konstantin.shkolnyy@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 4/24/2016 8:09 PM, Konstantin Shkolnyy wrote: > The CRTCTS flag code intended to clear the SERIAL_XOFF_CONTINUE flag, but CRTSCTS? Also, "is" missing before "intended"? > did it inconsistently. This change is non-functional for existing chips > because the driver never set the flag and it's clear by default. Sets. > Signed-off-by: Konstantin Shkolnyy [...] MBR, Sergei