From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C1D61EFFB4 for ; Mon, 22 Dec 2025 19:36:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766432184; cv=none; b=TnPqWO9uAnOp3d/fjSfaFQHhq4GbN6+bMAxPxm9mDWvTFG6ak64RMW83FFU2St7NFv8Dalsk1R2V8xT+PZtOT3myAqlbDftSA1yGwe75kzca8TdK3a+cDef7Ykco9EQsez5JrJ8w9iuzZT+Z4zqW2pZINt7VVnv5+EKaJ3jDKls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766432184; c=relaxed/simple; bh=MqLniN46ga/T49jfTrH3dp7jmvmuld5OUNS6EMMd26I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NeK4ZZmMJWjcBpiqXUhl6sefc2t7mz1T3SLb9+aWNqzZOezOSvSdk4bG9S2gT/hMWPCrAyuNUIWfeO0nl1d320IGHZUMS2rDjdlD4IjnQ6cf+YGyNbMHx2rbeds/InS8EvjZTVN0uRTScf4E/1Hicsy+MSArnH1zVJ+/dD5ZkOU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=W0yNtcWr; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="W0yNtcWr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766432182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZWFglRNrhHIkSED0pY4mFYnNdUnj8iod8G1skdCiVi0=; b=W0yNtcWrKwB2jTV1x/YC5hfqjeop5GLQxSNFgvXDpMg2+0vexHFxv42BhtMUz+RBOpIWp2 QKB0ndizpFgsQA/STzqlAGMxTieCo9HgYiCJr6WuGnS159WvVidYdbk20gbLtVU3+iW+87 CHgRhtYGLe7RHegYMdxXTiZSFIGfxlc= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-628-4r35dkwbOIO8XOYcpHlT_Q-1; Mon, 22 Dec 2025 14:36:20 -0500 X-MC-Unique: 4r35dkwbOIO8XOYcpHlT_Q-1 X-Mimecast-MFC-AGG-ID: 4r35dkwbOIO8XOYcpHlT_Q_1766432180 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4ed6855557aso116018431cf.1 for ; Mon, 22 Dec 2025 11:36:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766432180; x=1767036980; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZWFglRNrhHIkSED0pY4mFYnNdUnj8iod8G1skdCiVi0=; b=nw9WNHjZm6sFooSq7qmt/F93Iu6bGvLWSq3N+t9dzAGT1MPB14/qULn1b968pmWB2C aIodoI5Zd1gnYMYfLc+1jL476n1pf2zBSZya5ClaqTgm4NEHFKm3kNkEq58bmWKFlEzo CavMpovSOi9uXR1cCubr2Jr/naBQHT9xt0PqloBQXL+PYGZKHee2znFKrAR99uQoHDPx zRoPfY3HoVVcQIf7UJCbJrNT280NVph3qxgS5km1d7JmV4zs4xYGe/NocuQK7Hz+D78K ClRrsBxcgknNKWzSwBTK3cLv+n+4MRBvGCpCn13dRiObTdvJmn5TuLrWqinrEhg+U886 5mug== X-Forwarded-Encrypted: i=1; AJvYcCVtbctp9X4nUIv+CwAFlAQXtUJmiQsNNSQV3t9j27xqxcL0NgVL1nuHjirJxZ9JyDIZACevp9Cq5dLUq64=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7FQInEcQRLKg56+t3wu88Pq2FPD7VLmXUIhQAVgw3nX8LPS+U xlqO6l6NCuo2Czd/n/lwcX4A8jL+W0Lx1j4O/gbH90sZoOJzS6uVAdVuorWVjjSHQ5TDWsYdHOg 994vaniOIkH2W8/kD68jY5ZUQFPwJkCKIFuPaZmVLtIqn6xxYBQHyZrQi9sd73WhAqXTjAwzllg == X-Gm-Gg: AY/fxX4zepZqd9EqU4REHLa8e4NxioOmoKkqh93E2Nd2u37Cj1Da/CwWYZaLwnYK8nx pkIXZTmDArITH+OPPnJHO450AdkqYjeerd9yN3WlkCWxQwFh+tHj9yG5EVtg4to/Ml/OpMILiQ9 0HZUTgfrlfMBU0IjtXOaGdbQsCWYVsBbs6AnqZJ9jcjLpFixo35UwMUKjtChVQg847eyc8EbZgK 7GldNPrFpMMuoQ83ra3TQOHWX7gSC4jDduWRKHrbVgdL4r6W/3CLGVh263csqZqUl4vLrq98koy Jmj4NOTV3mNPQlCL0z35vAgC3rV9fn/uY4g7OyGbUyBwQUxR2ocgGjBrW+3oFyLnw4NeK8la2dR PSAomGmFvpN0+EuMLvKi8WHJ7/Wrsa+8ZALCXASiMMk60xPNuH4SWlFcgV5pN9+nYJGz+daKWrw == X-Received: by 2002:ac8:594e:0:b0:4ee:ce3:6c9c with SMTP id d75a77b69052e-4f4aac5d23bmr164621771cf.2.1766432179674; Mon, 22 Dec 2025 11:36:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IEDk3FjtineRhvc1jPppKJR8ZeFRYgYn64r+f+ezu6FGdQbbfW4MbqUOXuDnwzesgGVYYYTRg== X-Received: by 2002:ac8:594e:0:b0:4ee:ce3:6c9c with SMTP id d75a77b69052e-4f4aac5d23bmr164621571cf.2.1766432179295; Mon, 22 Dec 2025 11:36:19 -0800 (PST) Received: from [192.168.2.110] (bras-base-aylmpq0104w-grc-48-76-65-77-217.dsl.bell.ca. [76.65.77.217]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4f4b1302d44sm79789771cf.29.2025.12.22.11.36.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Dec 2025 11:36:19 -0800 (PST) Message-ID: <469acbcf-22f2-4774-8cf3-7f68c7095c0a@redhat.com> Date: Mon, 22 Dec 2025 14:36:18 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/5] selftests/mm: va_high_addr_switch return fail when either test failed To: Chunyu Hu , akpm@linux-foundation.org, david@kernel.org, shuah@kernel.org, linux-mm@kvack.org Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com References: <20251221040025.3159990-1-chuhu@redhat.com> <20251221040025.3159990-2-chuhu@redhat.com> <20251221040025.3159990-3-chuhu@redhat.com> <20251221040025.3159990-4-chuhu@redhat.com> Content-Language: en-US, en-CA From: Luiz Capitulino In-Reply-To: <20251221040025.3159990-4-chuhu@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2025-12-20 23:00, Chunyu Hu wrote: > When the first test failed, and the hugetlb test passed, the result would > be pass, but we expect a fail. Fix this issue by returning fail if either > is not KSFT_PASS. > > CC: Luiz Capitulino > Signed-off-by: Chunyu Hu > --- > tools/testing/selftests/mm/va_high_addr_switch.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/mm/va_high_addr_switch.c b/tools/testing/selftests/mm/va_high_addr_switch.c > index 02f290a69132..51401e081b20 100644 > --- a/tools/testing/selftests/mm/va_high_addr_switch.c > +++ b/tools/testing/selftests/mm/va_high_addr_switch.c > @@ -322,7 +322,7 @@ static int supported_arch(void) > > int main(int argc, char **argv) > { > - int ret; > + int ret, hugetlb_ret = KSFT_PASS; > > if (!supported_arch()) > return KSFT_SKIP; > @@ -331,6 +331,10 @@ int main(int argc, char **argv) > > ret = run_test(testcases, sz_testcases); > if (argc == 2 && !strcmp(argv[1], "--run-hugetlb")) > - ret = run_test(hugetlb_testcases, sz_hugetlb_testcases); Maybe you could just have used: ret |= run_test(hugetlb_testcases, sz_hugetlb_testcases); But anyways, as this is just testing code: Reviewed-by: Luiz Capitulino > - return ret; > + hugetlb_ret = run_test(hugetlb_testcases, sz_hugetlb_testcases); > + > + if (ret == KSFT_PASS && hugetlb_ret == KSFT_PASS) > + return KSFT_PASS; > + else > + return KSFT_FAIL; > }